From 31c5c141b97e0ac1c744f9675f0648ba4324684f Mon Sep 17 00:00:00 2001
From: kenjis <kenji.uui@gmail.com>
Date: Mon, 18 Dec 2023 17:32:15 +0900
Subject: [PATCH] refactor: replace empty()

---
 system/CodeIgniter.php                  |  9 ++++-----
 system/Validation/StrictRules/Rules.php |  6 ++++--
 system/Validation/Validation.php        |  6 +++---
 system/Validation/Views/list.php        |  2 +-
 system/View/Filters.php                 |  2 +-
 system/View/Parser.php                  | 10 +++++-----
 6 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/system/CodeIgniter.php b/system/CodeIgniter.php
index 1dcf55d2fb..39a3029f39 100644
--- a/system/CodeIgniter.php
+++ b/system/CodeIgniter.php
@@ -848,11 +848,10 @@ class CodeIgniter
      */
     protected function determinePath()
     {
-        if (isset($this->path)) {
-            return $this->path;
-        }
-
-        return method_exists($this->request, 'getPath') ? $this->request->getPath() : $this->request->getUri()->getPath();
+        return $this->path ??
+            (method_exists($this->request, 'getPath')
+                ? $this->request->getPath()
+                : $this->request->getUri()->getPath());
     }
 
     /**
diff --git a/system/Validation/StrictRules/Rules.php b/system/Validation/StrictRules/Rules.php
index 70d081975a..3086ca5a1d 100644
--- a/system/Validation/StrictRules/Rules.php
+++ b/system/Validation/StrictRules/Rules.php
@@ -157,7 +157,8 @@ class Rules
             ->limit(1);
 
         if (
-            ! empty($whereField) && ! empty($whereValue)
+            $whereField !== null && $whereField !== ''
+            && $whereValue !== null && $whereValue !== ''
             && ! preg_match('/^\{(\w+)\}$/', $whereValue)
         ) {
             $row = $row->where($whereField, $whereValue);
@@ -216,7 +217,8 @@ class Rules
             ->limit(1);
 
         if (
-            ! empty($ignoreField) && ! empty($ignoreValue)
+            $ignoreField !== null && $ignoreField !== ''
+            && $ignoreValue !== null && $ignoreValue !== ''
             && ! preg_match('/^\{(\w+)\}$/', $ignoreValue)
         ) {
             $row = $row->where("{$ignoreField} !=", $ignoreValue);
diff --git a/system/Validation/Validation.php b/system/Validation/Validation.php
index 6e71aadb23..83bb361e70 100644
--- a/system/Validation/Validation.php
+++ b/system/Validation/Validation.php
@@ -148,7 +148,7 @@ class Validation implements ValidationInterface
 
         // If no rules exist, we return false to ensure
         // the developer didn't forget to set the rules.
-        if (empty($this->rules)) {
+        if ($this->rules === []) {
             return false;
         }
 
@@ -707,7 +707,7 @@ class Validation implements ValidationInterface
      */
     protected function loadRuleSets()
     {
-        if (empty($this->ruleSetFiles)) {
+        if ($this->ruleSetFiles === [] || $this->ruleSetFiles === null) {
             throw ValidationException::forNoRuleSets();
         }
 
@@ -918,7 +918,7 @@ class Validation implements ValidationInterface
         $message = str_replace('{field}', ($label === null || $label === '') ? $field : lang($label), $message);
         $message = str_replace(
             '{param}',
-            empty($this->rules[$param]['label']) ? $param : lang($this->rules[$param]['label']),
+            (! isset($this->rules[$param]['label'])) ? $param : lang($this->rules[$param]['label']),
             $message
         );
 
diff --git a/system/Validation/Views/list.php b/system/Validation/Views/list.php
index cc95156cd5..3669f038e8 100644
--- a/system/Validation/Views/list.php
+++ b/system/Validation/Views/list.php
@@ -1,4 +1,4 @@
-<?php if (! empty($errors)) : ?>
+<?php if (isset($errors) && $errors !== []) : ?>
 	<div class="errors" role="alert">
 		<ul>
 		<?php foreach ($errors as $error) : ?>
diff --git a/system/View/Filters.php b/system/View/Filters.php
index 65dfe6dff9..fa03a1919a 100644
--- a/system/View/Filters.php
+++ b/system/View/Filters.php
@@ -66,7 +66,7 @@ class Filters
      */
     public static function default($value, string $default): string
     {
-        return empty($value)
+        return empty($value) // @phpstan-ignore-line
             ? $default
             : $value;
     }
diff --git a/system/View/Parser.php b/system/View/Parser.php
index 8410ef969f..87f0e96bdc 100644
--- a/system/View/Parser.php
+++ b/system/View/Parser.php
@@ -103,7 +103,7 @@ class Parser extends View
         }
 
         $fileExt = pathinfo($view, PATHINFO_EXTENSION);
-        $view    = empty($fileExt) ? $view . '.php' : $view; // allow Views as .html, .tpl, etc (from CI3)
+        $view    = ($fileExt === '') ? $view . '.php' : $view; // allow Views as .html, .tpl, etc (from CI3)
 
         $cacheName = $options['cache_name'] ?? str_replace('.php', '', $view);
 
@@ -120,8 +120,8 @@ class Parser extends View
             $fileOrig = $file;
             $file     = $this->loader->locateFile($view, 'Views');
 
-            // locateFile will return an empty string if the file cannot be found.
-            if (empty($file)) {
+            // locateFile() will return false if the file cannot be found.
+            if ($file === false) {
                 throw ViewException::forInvalidFile($fileOrig);
             }
         }
@@ -534,7 +534,7 @@ class Parser extends View
 
         // Our regex earlier will leave all chained values on a single line
         // so we need to break them apart so we can apply them all.
-        $filters = ! empty($matches[1]) ? explode('|', $matches[1]) : [];
+        $filters = (isset($matches[1]) && $matches[1] !== '') ? explode('|', $matches[1]) : [];
 
         if ($escape && $filters === [] && ($context = $this->shouldAddEscaping($orig))) {
             $filters[] = "esc({$context})";
@@ -589,7 +589,7 @@ class Parser extends View
             preg_match('/\([\w<>=\/\\\,:.\-\s\+]+\)/u', $filter, $param);
 
             // Remove the () and spaces to we have just the parameter left
-            $param = ! empty($param) ? trim($param[0], '() ') : null;
+            $param = ($param !== []) ? trim($param[0], '() ') : null;
 
             // Params can be separated by commas to allow multiple parameters for the filter
             if ($param !== null && $param !== '') {