malhuda/CodeIgniter4
1
0
Fork 0
mirror of https://github.com/codeigniter4/CodeIgniter4.git synced 2025-02-20 11:44:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #8639 from kenjis/improve-validation-error-msg

Browse Source 
refactor: improve Validation Placeholder error message
This commit is contained in:
kenjis 2024-03-26 08:20:02 +09:00 committed by GitHub
commit 446aa0beeb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 38 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
system/Validation/Validation.php
View File

@ -790,7 +790,9 @@ class Validation implements ValidationInterface
// Check if the validation rule for the placeholder exists
if ($placeholderRules === null) {
throw new LogicException(
'No validation rules for the placeholder: ' . $field
'No validation rules for the placeholder: "' . $field
. '". You must set the validation rules for the field.'
. ' See <https://codeigniter4.github.io/userguide/libraries/validation.html#validation-placeholders>.'
);
}

29
tests/system/Validation/StrictRules/DatabaseRelatedRulesTest.php
View File

@ -17,6 +17,7 @@ use CodeIgniter\Validation\Validation;
use Config\Database;
use Config\Services;
use InvalidArgumentException;
use LogicException;
use Tests\Support\Validation\TestRules;
/**
@ -139,6 +140,34 @@ class DatabaseRelatedRulesTest extends CIUnitTestCase
$this->assertTrue($this->validation->run($data));
}
public function testIsUniqueWithPlaceholderAndNoValidationRulesForIt(): void
{
$this->expectException(LogicException::class);
$this->expectExceptionMessage('No validation rules for the placeholder: "id". You must set the validation rules for the field.');
$this->hasInDatabase('user', [
'name' => 'Derek',
'email' => 'derek@world.co.uk',
'country' => 'GB',
]);
$row = Database::connect()
->table('user')
->limit(1)
->get()
->getRow();
$data = [
'id' => $row->id,
'email' => 'derek@world.co.uk',
];
$this->validation->setRules([
'email' => 'is_unique[user.email,id,{id}]',
]);
$this->validation->run($data);
}
public function testIsUniqueByManualRun(): void
{
Database::connect()

9
user_guide_src/source/libraries/validation.rst
View File

@ -517,15 +517,18 @@ Validation Placeholders
=======================
The Validation class provides a simple method to replace parts of your rules based on data that's being passed into it. This
sounds fairly obscure but can be especially handy with the ``is_unique`` validation rule. Placeholders are simply
sounds fairly obscure but can be especially handy with the ``is_unique`` validation rule.
Placeholders are simply
the name of the field (or array key) that was passed in as ``$data`` surrounded by curly brackets. It will be
replaced by the **value** of the matched incoming field. An example should clarify this:
.. literalinclude:: validation/020.php
:lines: 2-
.. note:: Since v4.3.5, you must set the validation rules for the placeholder
field (the ``id`` field in the sample code above) for security.
.. warning:: Since v4.3.5, you must set the validation rules for the placeholder
field (the ``id`` field in the sample code above) for security reasons. Because
attackers can send any data to your application.
In this set of rules, it states that the email address should be unique in the database, except for the row
that has an id matching the placeholder's value. Assuming that the form POST data had the following: