malhuda/CodeIgniter4
1
0
Fork 0
mirror of https://github.com/codeigniter4/CodeIgniter4.git synced 2025-02-20 11:44:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Replace unused Entity private method (#5029)

Browse Source
This commit is contained in:
John Paul E. Balandan, CPA 2021-08-27 21:13:05 +08:00 committed by GitHub
parent 82d39def0b
commit 7be28cdfc3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 25 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
rector.php
View File

@ -78,7 +78,6 @@ return static function (ContainerConfigurator $containerConfigurator): void {
// private method called via getPrivateMethodInvoker
RemoveUnusedPrivateMethodRector::class => [
__DIR__ . '/system/Entity/Entity.php',
__DIR__ . '/tests/system/Test/ReflectionHelperTest.php',
],

14
system/Entity/Entity.php
View File

@ -390,20 +390,6 @@ class Entity implements JsonSerializable
return $handlers[$type]::$method($value, $params);
}
/**
* Cast as JSON
*
* @param mixed $value
*
* @throws CastException
*
* @return mixed
*/
private function castAsJson($value, bool $asArray = false)
{
return JsonCast::get($value, $asArray ? ['array'] : []);
}
/**
* Support for json_encode()
*

43
tests/system/Entity/EntityTest.php
View File

@ -11,6 +11,7 @@
namespace CodeIgniter\Entity;
use Closure;
use CodeIgniter\Entity\Exceptions\CastException;
use CodeIgniter\HTTP\URI;
use CodeIgniter\I18n\Time;
@ -589,54 +590,60 @@ final class EntityTest extends CIUnitTestCase
public function testCastAsJSONSyntaxError()
{
$entity = new Entity();
$method = $this->getPrivateMethodInvoker($entity, 'castAsJson');
$this->expectException(CastException::class);
$this->expectExceptionMessage('Syntax error, malformed JSON');
$method('{ this is bad string', true);
(Closure::bind(static function (string $value) {
$entity = new Entity();
$entity->casts['dummy'] = 'json[array]';
return $entity->castAs($value, 'dummy');
}, null, Entity::class))('{ this is bad string');
}
public function testCastAsJSONAnotherErrorDepth()
{
$entity = new Entity();
$method = $this->getPrivateMethodInvoker($entity, 'castAsJson');
$this->expectException(CastException::class);
$this->expectExceptionMessage('Maximum stack depth exceeded');
$string = '{' . str_repeat('"test":{', 513) . '"test":"value"' . str_repeat('}', 513) . '}';
$method($string, true);
(Closure::bind(static function (string $value) {
$entity = new Entity();
$entity->casts['dummy'] = 'json[array]';
return $entity->castAs($value, 'dummy');
}, null, Entity::class))($string);
}
public function testCastAsJSONControlCharCheck()
{
$entity = new Entity();
$method = $this->getPrivateMethodInvoker($entity, 'castAsJson');
$this->expectException(CastException::class);
$this->expectExceptionMessage('Unexpected control character found');
$string = "{\n\t\"property1\": \"The quick brown fox\njumps over the lazy dog\",\n\t\"property2\":\"value2\"\n}";
$method($string, true);
(Closure::bind(static function (string $value) {
$entity = new Entity();
$entity->casts['dummy'] = 'json[array]';
return $entity->castAs($value, 'dummy');
}, null, Entity::class))($string);
}
public function testCastAsJSONStateMismatch()
{
$entity = new Entity();
$method = $this->getPrivateMethodInvoker($entity, 'castAsJson');
$this->expectException(CastException::class);
$this->expectExceptionMessage('Underflow or the modes mismatch');
$string = '[{"name":"jack","product_id":"1234"]';
$method($string, true);
(Closure::bind(static function (string $value) {
$entity = new Entity();
$entity->casts['dummy'] = 'json[array]';
return $entity->castAs($value, 'dummy');
}, null, Entity::class))($string);
}
public function testCastSetter()