malhuda/CodeIgniter4
1
0
Fork 0
mirror of https://github.com/codeigniter4/CodeIgniter4.git synced 2025-02-20 11:44:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: move if conditions to isValidDSN()

Browse Source
This commit is contained in:
kenjis 2024-06-22 17:46:59 +09:00
parent 5ee0df20c4
commit 99346b48aa
No known key found for this signature in database
GPG Key ID: BD254878922AF198
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
system/Database/OCI8/Connection.php
View File

@ -104,6 +104,10 @@ class Connection extends BaseConnection
*/
private function isValidDSN(): bool
{
if ($this->DSN === null || $this->DSN === '') {
return false;
}
foreach ($this->validDSNs as $regexp) {
if (preg_match($regexp, $this->DSN)) {
return true;
@ -120,7 +124,7 @@ class Connection extends BaseConnection
*/
public function connect(bool $persistent = false)
{
if ($this->DSN === null || $this->DSN === '' || ! $this->isValidDSN()) {
if (! $this->isValidDSN()) {
$this->buildDSN();
}