malhuda/CodeIgniter4
1
0
Fork 0
mirror of https://github.com/codeigniter4/CodeIgniter4.git synced 2025-02-20 11:44:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix resultID check

Browse Source
This commit is contained in:
michalsn 2020-07-05 07:39:42 +02:00
parent e184cd7f09
commit a050c89a66
No known key found for this signature in database
GPG Key ID: 0E4DB53924E59366
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
system/Database/BaseBuilder.php
View File

@ -2454,7 +2454,7 @@ class BaseBuilder
$result = $this->db->query($sql, $this->binds, false);
if ($result->resultID)
if ($result->resultID !== false)
{
// Clear our binds so we don't eat up memory
$this->binds = [];

2
system/Model.php
View File

@ -558,7 +558,7 @@ class Model
if ($response instanceof BaseResult)
{
$response = $response->resultID;
$response = $response->resultID !== false;
}
elseif ($response !== false)
{

4
tests/system/Database/Live/ModelTest.php
View File

@ -471,7 +471,7 @@ class ModelTest extends CIDatabaseTestCase
$this->seeInDatabase('job', ['name' => 'Developer']);
$result = $model->delete(1);
$this->assertTrue($result->resultID);
$this->assertTrue($result->resultID !== false);
$this->dontSeeInDatabase('job', ['name' => 'Developer']);
}
@ -1529,7 +1529,7 @@ class ModelTest extends CIDatabaseTestCase
$result = $model->protect(false)
->insert($data, false);
$this->assertTrue($result->resultID);
$this->assertTrue($result->resultID !== false);
$lastInsertId = $model->getInsertID();