From d2bf2099e2b5465c5c43ee3737b6906791fbaf34 Mon Sep 17 00:00:00 2001
From: Denny Septian Panggabean <97607754+ddevsr@users.noreply.github.com>
Date: Wed, 12 Feb 2025 18:36:53 +0700
Subject: [PATCH] refactor: get upper first protocol only one call in Email

---
 system/Email/Email.php | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/system/Email/Email.php b/system/Email/Email.php
index 17b24c9de5..24c3af4cd3 100644
--- a/system/Email/Email.php
+++ b/system/Email/Email.php
@@ -1689,8 +1689,9 @@ class Email
     protected function spoolEmail()
     {
         $this->unwrapSpecials();
-        $protocol = $this->getProtocol();
-        $method   = 'sendWith' . ucfirst($protocol);
+        $protocol           = $this->getProtocol();
+        $upperFirstProtocol = ucfirst($protocol);
+        $method             = 'sendWith' . $upperFirstProtocol;
 
         try {
             $success = $this->{$method}();
@@ -1700,7 +1701,7 @@ class Email
         }
 
         if (! $success) {
-            $message = lang('Email.sendFailure' . ($protocol === 'mail' ? 'PHPMail' : ucfirst($protocol)));
+            $message = lang('Email.sendFailure' . ($protocol === 'mail' ? 'PHPMail' : $upperFirstProtocol));
 
             log_message('error', 'Email: ' . $message);
             log_message('error', $this->printDebuggerRaw());