malhuda/CodeIgniter4
1
0
Fork 0
mirror of https://github.com/codeigniter4/CodeIgniter4.git synced 2025-02-20 11:44:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: do not unset statement after closing it, instead set to null

Browse Source
This commit is contained in:
Dyno 2022-10-14 11:38:11 +02:00
parent 78a34c9427
commit dbe460ec9c
No known key found for this signature in database
GPG Key ID: 2C9348AA0D6EF676
2 changed files with 2 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
phpstan-baseline.neon.dist
View File

@ -115,11 +115,6 @@ parameters:
count: 1
path: system/Database/Migration.php
-
message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Database/BasePreparedQuery.php
-
message: "#^Cannot access property \\$errno on bool\\|object\\|resource\\.$#"
count: 1
@ -225,11 +220,6 @@ parameters:
count: 1
path: system/Database/MySQLi/PreparedQuery.php
-
message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Database/MySQLi/PreparedQuery.php
-
message: "#^Cannot access property \\$field_count on object\\|resource\\|false\\.$#"
count: 1
@ -270,21 +260,11 @@ parameters:
count: 1
path: system/Database/MySQLi/Result.php
-
message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Database/OCI8/PreparedQuery.php
-
message: "#^Strict comparison using \\=\\=\\= between array and false will always evaluate to false\\.$#"
count: 1
path: system/Database/Postgre/Connection.php
-
message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Database/Postgre/PreparedQuery.php
-
message: "#^Access to an undefined property CodeIgniter\\\\Database\\\\BaseConnection\\:\\:\\$schema\\.$#"
count: 2
@ -295,11 +275,6 @@ parameters:
count: 13
path: system/Database/SQLSRV/Forge.php
-
message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Database/SQLSRV/PreparedQuery.php
-
message: "#^Cannot call method changes\\(\\) on bool\\|object\\|resource\\.$#"
count: 1
@ -370,11 +345,6 @@ parameters:
count: 1
path: system/Database/SQLite3/PreparedQuery.php
-
message: "#^Property CodeIgniter\\\\Database\\\\BasePreparedQuery\\:\\:\\$statement \\(object\\|resource\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Database/SQLite3/PreparedQuery.php
-
message: "#^Cannot call method columnName\\(\\) on object\\|resource\\|false\\.$#"
count: 2

4
system/Database/BasePreparedQuery.php
View File

@ -25,7 +25,7 @@ abstract class BasePreparedQuery implements PreparedQueryInterface
/**
* The prepared statement itself.
*
* @var object|resource
* @var object|resource|null
*/
protected $statement;
@ -158,7 +158,7 @@ abstract class BasePreparedQuery implements PreparedQueryInterface
try {
return $this->_close();
} finally {
unset($this->statement);
$this->statement = null;
}
}