malhuda/CodeIgniter4
1
0
Fork 0
mirror of https://github.com/codeigniter4/CodeIgniter4.git synced 2025-02-20 11:44:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add unit test to ensure named binds don't get replaced in binded values

Browse Source 
Using str_replace() instead of strtr() in Database\Query->matchNamedBinds() would make this test fail.

For this test to be effective, the overlapping marker (here :foobar:) has to be after the replaced string (here :content:) in the binds array.
This commit is contained in:
vlakoff 2021-10-07 11:33:58 +02:00
parent 4c52a378dc
commit df74c1ecdc
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/system/Database/BaseQueryTest.php
View File

@ -294,6 +294,20 @@ final class BaseQueryTest extends CIUnitTestCase
$this->assertSame($expected, $query->getQuery()); $this->assertSame($expected, $query->getQuery());
} }
public function testNamedBindsDontGetReplacedAgain()
{
$query = new Query($this->db);
$query->setQuery(
'SELECT * FROM posts WHERE content = :content: OR foobar = :foobar:',
['content' => 'a placeholder looks like :foobar:', 'foobar' => 'bazqux']
);
$expected = "SELECT * FROM posts WHERE content = 'a placeholder looks like :foobar:' OR foobar = 'bazqux'";
$this->assertSame($expected, $query->getQuery());
}
/** /**
* @see https://github.com/codeigniter4/CodeIgniter4/issues/1705 * @see https://github.com/codeigniter4/CodeIgniter4/issues/1705
*/ */