malhuda/CodeIgniter4
1
0
Fork 0
mirror of https://github.com/codeigniter4/CodeIgniter4.git synced 2025-02-20 11:44:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #4862 from samsonasik/apply-rector-r

Browse Source 
[Rector] Apply Rector: RemoveExtraParametersRector
This commit is contained in:
Abdul Malik Ikhsan 2021-06-23 09:14:29 +07:00 committed by GitHub
commit e73f750f22
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rector.php
View File

@ -26,6 +26,7 @@ use Rector\EarlyReturn\Rector\If_\ChangeIfElseValueAssignToEarlyReturnRector;
use Rector\EarlyReturn\Rector\If_\RemoveAlwaysElseRector;
use Rector\EarlyReturn\Rector\Return_\PreparedValueToEarlyReturnRector;
use Rector\Php70\Rector\Ternary\TernaryToNullCoalescingRector;
use Rector\Php71\Rector\FuncCall\RemoveExtraParametersRector;
use Rector\Php71\Rector\List_\ListToArrayDestructRector;
use Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector;
use Rector\Php73\Rector\FuncCall\StringifyStrNeedlesRector;
@ -97,4 +98,5 @@ return static function (ContainerConfigurator $containerConfigurator): void {
$services->set(RemoveVarTagFromClassConstantRector::class);
$services->set(AddPregQuoteDelimiterRector::class);
$services->set(SimplifyRegexPatternRector::class);
$services->set(RemoveExtraParametersRector::class);
};

2
tests/system/Database/Builder/InsertTest.php
View File

@ -117,7 +117,7 @@ class InsertTest extends CIUnitTestCase
{
$builder = $this->db->table('jobs');
$this->expectException('\CodeIgniter\Database\Exceptions\DatabaseException', 'You must use the "set" method to update an entry.');
$this->expectException('\CodeIgniter\Database\Exceptions\DatabaseException');
$this->expectExceptionMessage('You must use the "set" method to update an entry.');
$builder->insertBatch();
}

5
tests/system/Database/Builder/UpdateTest.php
View File

@ -91,9 +91,10 @@ class UpdateTest extends CIUnitTestCase
{
$builder = new BaseBuilder('jobs', $this->db);
$this->expectException('CodeIgniter\Database\Exceptions\DatabaseException', 'You must use the "set" method to update an entry.');
$this->expectException('CodeIgniter\Database\Exceptions\DatabaseException');
$this->expectExceptionMessage('You must use the "set" method to update an entry.');
$builder->update(null, null, null, true);
$builder->update(null, null, null);
}
public function testUpdateBatch()

2
tests/system/Helpers/URLHelper/SiteUrlTest.php
View File

@ -266,6 +266,6 @@ final class SiteUrlTest extends CIUnitTestCase
Services::injectMock('request', $request);
$this->assertEquals('http://example.com/ci/v4/index.php/controller/method', site_url('controller/method', null, $this->config));
$this->assertEquals('http://example.com/ci/v4/controller/method', base_url('controller/method', null, $this->config));
$this->assertEquals('http://example.com/ci/v4/controller/method', base_url('controller/method', null));
}
}

2
tests/system/Router/RouterTest.php
View File

@ -181,7 +181,7 @@ class RouterTest extends CIUnitTestCase
{
$router = new Router($this->collection, $this->request);
$router->handle('closure/123/alpha', $this->request);
$router->handle('closure/123/alpha');
$closure = $router->controllerName();