malhuda/CodeIgniter4
1
0
Fork 0
mirror of https://github.com/codeigniter4/CodeIgniter4.git synced 2025-02-20 11:44:28 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: fix Throttler::check() $tokens

Browse Source
This commit is contained in:
John Paul E. Balandan, CPA 2024-07-24 19:18:13 +08:00
parent 9597237af9
commit eeb71f1723
No known key found for this signature in database
GPG Key ID: 697D84680E3738DA
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
system/Throttle/Throttler.php
View File

@ -102,8 +102,11 @@ class Throttler implements ThrottlerInterface
// Number of seconds to get one token
$refresh = 1 / $rate;
/** @var float|int|null $tokens */
$tokens = $this->cache->get($tokenName);
// Check to see if the bucket has even been created yet.
if (($tokens = $this->cache->get($tokenName)) === null) {
if ($tokens === null) {
// If it hasn't been created, then we'll set it to the maximum
// capacity - 1, and save it to the cache.
$tokens = $capacity - $cost;
@ -124,7 +127,7 @@ class Throttler implements ThrottlerInterface
// should be refilled, then checked against capacity
// to be sure the bucket didn't overflow.
$tokens += $rate * $elapsed;
$tokens = $tokens > $capacity ? $capacity : $tokens;
$tokens = min($tokens, $capacity);
// If $tokens >= 1, then we are safe to perform the action, but
// we need to decrement the number of available tokens.