136 Commits

Author SHA1 Message Date
John Paul E. Balandan, CPA
119330c56f
refactor: Use strtolower with str_contains/str_**_with as replacement for stripos (#9414)
* Use `modernize_stripos` option

* Fix impossible conditional in test
2025-01-17 22:51:06 +08:00
John Paul E. Balandan, CPA
c3ac0f9483
chore: add more trailing commas in more places (#9395)
* Apply to parameters

* Apply to array destructuring

* Apply to match

* Apply for arguments
2025-01-13 11:03:02 +08:00
Abdul Malik Ikhsan
f29210c0f0
refactor: use compare equals 1 for preg_match() return on array_filter 2024-12-29 01:13:34 +07:00
Abdul Malik Ikhsan
a2ec5054d7
refactor: enable AddArrowFunctionReturnTypeRector 2024-12-28 23:00:15 +07:00
Abdul Malik Ikhsan
ee4ee987b1
refactor: enable instanceof and strictBooleans rector set (#9339)
* refactor: enable instanceof and strictBooleans rector set

* refactor: bump to rector 2.0.4

* refactor: clean condition check

* refactor: revert ThirdParty change

* refactor: re-run phpstan baseline

* refactor: fix never empty array on Image

* refactor: avoid repetitive call pg_last_error()

* refactor: pg_last_error() always returns string

* refactor: use return empty string on pg_last_error() got empty "0"

* refactor: various compare !== 1 on preg_match()

* refactor: use falsy check on getenv()

* refactor: more !== 1 compare on preg_match()

* refactor: use empty string check on guessExtension

* refactor: run cs fix

* refactor: more !== 1 compare on preg_match()

* use direct result of pg_last_error()

* refactor: use str_contains() over strpos on Forge

* refactor: fix unused variable

* refactor: check empty string on ResponseTrait

* refactor: more preg_match() and empty string only check

* refactor: compare to 0 on preg_match_all()

* refactor: re-run rector

* refactor: preg_match_all() likely less to return false
2024-12-28 23:16:32 +08:00
neznaika0
8cff0995de
refactor: fix phpstan only boolean allowed (#9302)
* refactor: Fix `phpstan` boolean errors

* fix: Check predis response

* refactor: Improve comparison with an empty string

* dev: Update phpstan-baseline

* fix: Revert comparison with null
2024-12-28 20:21:06 +08:00
Abdul Malik Ikhsan
3f8feaa589
refactor: clean up parentheses on assign and ternary 2024-10-30 16:43:51 +07:00
Abdul Malik Ikhsan
dede747236
refactor: enable SimplifyBoolIdenticalTrueRector 2024-10-30 16:37:37 +07:00
kenjis
e1cf987bb8
fix: TypeError in form() 2024-04-09 15:54:12 +09:00
kenjis
e843fec493
refactor: run rector (2nd time) 2024-04-06 09:24:48 +09:00
kenjis
e78c92994f
Merge remote-tracking branch 'upstream/develop' into 4.5 2024-04-05 16:59:18 +09:00
Abdul Malik Ikhsan
1455e8dac6
remove !== "0" check 2024-04-04 15:38:56 +07:00
Abdul Malik Ikhsan
0987c9ac0b
chore: [Rector] Apply ExplicitBoolCompareRector 2024-04-03 22:25:35 +07:00
kenjis
cc01dd2775
Merge remote-tracking branch 'upstream/develop' into 4.5 2024-03-23 08:29:42 +09:00
Abdul Malik Ikhsan
1c02496e8a
chore: remove unnecessary if check 2024-03-22 01:50:16 +07:00
kenjis
3880337c93
refactor: use service() in framework code 2024-03-04 17:45:22 +09:00
kenjis
99a9148b0a
Merge remote-tracking branch 'upstream/develop' into 4.5
Conflicts:
	psalm-baseline.xml
	system/Router/AutoRouterImproved.php
	system/Router/Router.php
2024-02-26 09:42:51 +09:00
kenjis
e1df9f5bcd
Merge remote-tracking branch 'upstream/develop' into 4.5
Conflicts:
	system/Router/AutoRouterImproved.php
	system/Router/Router.php
2024-02-26 06:59:33 +09:00
John Paul E. Balandan, CPA
06353a4037
style: Enable phpdoc_list_type fixer 2024-02-26 00:19:02 +08:00
John Paul E. Balandan, CPA
609be527ce
style: enable phpdoc_array_type (#8580) 2024-02-25 22:58:47 +08:00
kenjis
09b48d5c4e
Merge remote-tracking branch 'upstream/develop' into 4.5
Conflicts:
	system/Helpers/array_helper.php
2024-02-12 18:44:43 +09:00
Denny Septian Panggabean
eec94a4ab3
run rector 2024-02-09 09:50:43 +07:00
Denny Septian Panggabean
345eb4a005
refactor: possible one liner in Helper 2024-02-09 09:43:45 +07:00
kenjis
bb9e60e916
Merge remote-tracking branch 'upstream/develop' into 4.5
Conflicts:
	phpstan-baseline.php
	system/BaseModel.php
	system/Controller.php
	system/Helpers/array_helper.php
2023-12-19 11:35:20 +09:00
kenjis
cec682b049
refactor: apply SimplifyEmptyCheckOnEmptyArrayRector 2023-12-17 17:32:04 +09:00
kenjis
25ec3df976
refactor: add declare(strict_types=1) to system files 2023-11-30 16:14:48 +09:00
Paulo Esteves
87796a0979
remove $_SESSION from methods and functions 2023-10-02 09:39:06 +01:00
kenjis
f2f7dcf223
fix: set_checkbox() incorrect checking
set_checkbox() with default true checks unchecked checkbox
when redirected back with input.
2023-08-16 14:46:05 +09:00
kenjis
3bdb53f374
refactor: use ::class to config() param 2023-06-24 09:20:24 +09:00
Samuel Asor
09e267db52
add support for display of error message using wildcard (*) 2023-02-05 09:52:45 +01:00
Denny Septian Panggabean
a2a7a3892d
refactor: make it void element to valid schema HTML 2022-10-30 22:19:32 +07:00
kenjis
7ec5d1191f
refactor: replace config(App::class) with config('App')
We use config('App') more often.
2022-10-29 09:34:50 +09:00
kenjis
763a5d94df
Merge remote-tracking branch 'upstream/develop' into 4.3 2022-10-20 16:47:58 +09:00
kenjis
0df554b958
refactor: remove unneeded elseif
$defaults['checked'] always does not exists.
2022-10-20 08:56:31 +09:00
kenjis
3a3afd4314
docs: fix PHPDoc types 2022-10-20 08:47:29 +09:00
kenjis
af3b84358a
Merge remote-tracking branch 'upstream/develop' into 4.3 2022-10-15 07:00:41 +09:00
John Paul E. Balandan, CPA
84b538678f
Enable no_useless_concat_operator 2022-10-14 10:00:51 +08:00
kenjis
8a8ef7d56f
refactor: remove return type
Maybe it will be changed to ErrorBag.
2022-08-21 10:57:04 +09:00
kenjis
a70f84331b
docs: fix doc comment 2022-08-21 10:57:02 +09:00
kenjis
04f603c478
refactor: remove unnecessary serialize() 2022-08-21 10:56:22 +09:00
kenjis
d8b337ec5f
feat: add validation_show_error() in Form helper 2022-08-21 10:56:22 +09:00
kenjis
70fda50426
feat: add validation_list_errors() in Form helper 2022-08-21 10:56:21 +09:00
kenjis
d1ff2e0b4d
feat: validation_errors() also returns the errors from Validation 2022-08-21 10:56:21 +09:00
kenjis
30f8f4fee1
refactor: run rector 2022-08-21 10:56:21 +09:00
kenjis
07a6ec51e4
feat: add validation_errors() in Form helper 2022-08-21 10:56:21 +09:00
Abdul Malik Ikhsan
0e598d1cc3
re-run rector with enable RemoveAlwaysTrueIfConditionRector with skip only in trait 2022-08-03 22:53:38 +07:00
kenjis
6bb449a4ad
fix: set_radio() implementation 2022-05-27 17:56:17 +09:00
kenjis
62441b9cf8
docs: remove out of dated comments 2022-05-27 17:55:27 +09:00
Alex Schmitz
ab580bae71
Fix key casting in form_dropdown helper. (#5035) 2021-08-31 18:33:14 +08:00
John Paul E. Balandan, CPA
b7ec33cd56
Remove superfluous phpdoc tags (#4941) 2021-07-24 19:30:51 +08:00