1826 Commits

Author SHA1 Message Date
John Paul E. Balandan, CPA
80719d473b
Merge branch 'develop' into 4.6 2025-01-18 01:42:58 +08:00
John Paul E. Balandan, CPA
119330c56f
refactor: Use strtolower with str_contains/str_**_with as replacement for stripos (#9414)
* Use `modernize_stripos` option

* Fix impossible conditional in test
2025-01-17 22:51:06 +08:00
John Paul E. Balandan, CPA
797d37751a
Merge branch 'develop' into 4.6 2025-01-13 11:15:24 +08:00
John Paul E. Balandan, CPA
c3ac0f9483
chore: add more trailing commas in more places (#9395)
* Apply to parameters

* Apply to array destructuring

* Apply to match

* Apply for arguments
2025-01-13 11:03:02 +08:00
neznaika0
9de985651a
refactor: Fix phpstan isset.offset (#9383) 2025-01-09 00:10:43 +08:00
michalsn
c3bfac5261
Merge remote-tracking branch 'upstream/develop' into 4.6
# Conflicts:
#	composer.json
#	utils/phpstan-baseline/missingType.iterableValue.neon
2025-01-06 09:51:34 +01:00
Michal Sniatala
046967af08
fix: gather affected rows after query call failed (#9363)
* fix: gather affected rows after query call failed

* update user guide

* fix test

* fix test

* fix failing tests for mysqli - enable strict mode

* cs fix
2025-01-03 06:57:55 +01:00
Abdul Malik Ikhsan
82340aa1c7
refactor: use more strict result on preg_match_all() result 2025-01-01 20:16:32 +07:00
John Paul E. Balandan, CPA
eec3739823
Merge remote-tracking branch 'upstream/develop' into 4.6 2024-12-31 20:22:12 +08:00
John Paul E. Balandan, CPA
d7ce2ba7d3
fix: Forge::dropColumn() always returns false on SQLite3 driver (#9351) 2024-12-31 18:41:07 +08:00
John Paul E. Balandan, CPA
c7548a3771
Merge branch 'develop' into 4.6 2024-12-29 00:21:53 +08:00
Abdul Malik Ikhsan
a2ec5054d7
refactor: enable AddArrowFunctionReturnTypeRector 2024-12-28 23:00:15 +07:00
Abdul Malik Ikhsan
ee4ee987b1
refactor: enable instanceof and strictBooleans rector set (#9339)
* refactor: enable instanceof and strictBooleans rector set

* refactor: bump to rector 2.0.4

* refactor: clean condition check

* refactor: revert ThirdParty change

* refactor: re-run phpstan baseline

* refactor: fix never empty array on Image

* refactor: avoid repetitive call pg_last_error()

* refactor: pg_last_error() always returns string

* refactor: use return empty string on pg_last_error() got empty "0"

* refactor: various compare !== 1 on preg_match()

* refactor: use falsy check on getenv()

* refactor: more !== 1 compare on preg_match()

* refactor: use empty string check on guessExtension

* refactor: run cs fix

* refactor: more !== 1 compare on preg_match()

* use direct result of pg_last_error()

* refactor: use str_contains() over strpos on Forge

* refactor: fix unused variable

* refactor: check empty string on ResponseTrait

* refactor: more preg_match() and empty string only check

* refactor: compare to 0 on preg_match_all()

* refactor: re-run rector

* refactor: preg_match_all() likely less to return false
2024-12-28 23:16:32 +08:00
neznaika0
8cff0995de
refactor: fix phpstan only boolean allowed (#9302)
* refactor: Fix `phpstan` boolean errors

* fix: Check predis response

* refactor: Improve comparison with an empty string

* dev: Update phpstan-baseline

* fix: Revert comparison with null
2024-12-28 20:21:06 +08:00
Michal Sniatala
6cbbf601b0
fix: handling binary data for prepared statement (#9337)
* fix prepare statement sqlite

* fix prepare statement postgre

* fix prepare statement sqlsrv

* fix prepare statement oci8

* tests

* abstract isBinary() method

* fix prepare statement mysqli

* fix prepare statement oci8

* sqlsrv blob support

* fix tests

* add changelog

* fix rector

* make sqlsrv happy

* make oci8 happy - hopefully

* add a note about options for prepared statement

* ignore PreparedQueryTest.php file

* apply code suggestion for oci8
2024-12-27 08:14:06 +01:00
Abdul Malik Ikhsan
345e1c3b9c
refactor: enable code quality level 34 for rector (#9311)
* refactor: enable code quality level 34 for rector

* refactor: run cs fix

* refactor: fix phpstan and regenerate baseline

* refactor: cs fix

* refactor: Cors: before never returns string

* refactor: return EXIT_ERROR on check verify command

* refactor: returns null on DebugToolbar and HoneyPot
2024-12-21 19:40:05 +08:00
John Paul E. Balandan, CPA
bd5945df9b
Merge branch 'develop' into 4.6 2024-12-19 16:39:09 +08:00
John Paul E. Balandan, CPA
f48aa6f61e
refactor: fix Forge::processIndexes() for empty $this->fields (#9330) 2024-12-19 16:07:05 +08:00
Andi Fahruddin Akas
17f7a9d8b9
docs: phpdoc incorrect explanation regarding variable naming (#9326)
* Update FileHandler.php

* Update BaseConnection.php

* Update Connection.php

* Update filesystem_helper.php

* Update Security.php

* Update SecurityInterface.php
2024-12-16 19:30:37 +08:00
John Paul E. Balandan, CPA
2927788803
refactor: fix phpdoc.parseError errors 2024-12-11 18:58:28 +08:00
neznaika0
dae379fad2
refactor: fix phpstan signature for Closure (#9304) 2024-12-10 22:11:08 +08:00
Michal Sniatala
35c578496b
feat: add SQLite3 config synchronous (#9202)
* feat: add SQLite3 config synchronous

* add synchronous value validation

* Update system/Database/SQLite3/Connection.php

Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>

* add type for the synchronous property

* use InvalidArgumentException from the CodeIgniter namespace

* fix rector

---------

Co-authored-by: John Paul E. Balandan, CPA <paulbalandan@gmail.com>
2024-12-02 07:28:31 +01:00
John Paul E. Balandan, CPA
9fba8c7a49
Merge branch 'develop' into 4.6 2024-12-02 00:20:53 +08:00
ping-yee
ace329fe5a
fix: rebase. 2024-11-30 22:08:35 +08:00
ping-yee
99b10314c8
fix: fix the reconnect function. 2024-11-30 22:08:05 +08:00
michalsn
c32dcd4329
Merge remote-tracking branch 'upstream/develop' into 4.6
# Conflicts:
#	system/Autoloader/Autoloader.php
#	system/BaseModel.php
#	system/CLI/CLI.php
#	system/Database/MigrationRunner.php
#	system/Exceptions/PageNotFoundException.php
#	system/Router/RouteCollection.php
#	system/Validation/FileRules.php
#	tests/system/Autoloader/AutoloaderTest.php
#	tests/system/Filters/FiltersTest.php
#	tests/system/Test/ControllerTestTraitTest.php
#	tests/system/Test/FeatureTestTraitTest.php
#	tests/system/Validation/CreditCardRulesTest.php
#	tests/system/Validation/FileRulesTest.php
#	tests/system/Validation/StrictRules/DatabaseRelatedRulesTest.php
#	tests/system/Validation/StrictRules/FileRulesTest.php
#	tests/system/View/ViewTest.php
2024-11-17 12:21:31 +01:00
Abdul Malik Ikhsan
c8b3804f7d
refactor: use compare empty array on Forge on keys property 2024-11-12 09:12:54 +07:00
neznaika0
583e7b61da
refactor: up performance service() 2024-11-09 08:44:46 +03:00
Abdul Malik Ikhsan
3e672fadc6
refactor: enable FlipTypeControlToUseExclusiveTypeRector 2024-11-05 05:03:14 +07:00
michalsn
3e78c58f0b
Merge remote-tracking branch 'upstream/develop' into 4.6 2024-11-03 20:21:21 +01:00
Michal Sniatala
fc19b690f8
fix: case-insensitivity in the like() method when in use with accented characters (#9238)
* fix: case-insensitivity in the like() method when in use with accented characters

* Update system/Database/BaseBuilder.php

Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>

* add more cases for tests

* even more tests

* fix types

* set collation for sqlsrv

---------

Co-authored-by: Pooya Parsa <pooya_parsa_dadashi@yahoo.com>
2024-11-03 19:48:50 +01:00
Abdul Malik Ikhsan
3f8feaa589
refactor: clean up parentheses on assign and ternary 2024-10-30 16:43:51 +07:00
Abdul Malik Ikhsan
dede747236
refactor: enable SimplifyBoolIdenticalTrueRector 2024-10-30 16:37:37 +07:00
kenjis
904e4f2a6b
Merge remote-tracking branch 'upstream/develop' into 4.6 2024-09-13 17:24:56 +09:00
Abdul Malik Ikhsan
3f29f2883a
refactor: enable ClosureReturnTypeRector 2024-09-10 16:18:25 +07:00
kenjis
4a4a6489b5
Merge remote-tracking branch 'upstream/develop' into 4.6 2024-09-06 09:15:59 +09:00
Thomas Meschke
06958be352
Fix typo in BaseConnection.php 2024-09-05 12:28:12 +02:00
kenjis
31e8f9f9c4
Merge remote-tracking branch 'upstream/develop' into 4.6
Conflicts:
	system/Database/Database.php
2024-09-05 10:30:40 +09:00
kenjis
a9925c740e
fix: pass through custom drivers
Because we can name any classname.
2024-08-30 10:22:55 +09:00
kenjis
59aca8ed47
feat: add function to check PHP DB extension
To improve the error message.
2024-08-30 09:53:58 +09:00
kenjis
dc45e4246e
Merge remote-tracking branch 'upstream/develop' into 4.6 2024-08-30 09:05:14 +09:00
kenjis
1938a7cc02
Merge remote-tracking branch 'upstream/develop' into 4.6 2024-08-29 10:11:14 +09:00
kenjis
9e97a0c6d4
refactor: break long lines 2024-08-28 17:30:49 +09:00
kenjis
694b031996
fix: remove uneeded if condition 2024-08-28 17:30:46 +09:00
kenjis
87acaf7917
docs: update comment 2024-08-28 17:30:13 +09:00
Abdul Malik Ikhsan
87eb71ce29
refactor: enable AddMethodCallBasedStrictParamTypeRector 2024-08-28 08:54:48 +07:00
kenjis
640de452ed
refactor: change 1st param type
Remove dependency on BaseConnection.
2024-08-05 09:46:14 +09:00
kenjis
58197a4374
docs: add @internal to TableName class 2024-07-31 11:23:29 +09:00
kenjis
0cb31bbb1e
fix!: spark db:table causes errors w/z table name including speciali chars 2024-07-31 11:16:56 +09:00
kenjis
583a080705
feat: add TableName class 2024-07-31 11:16:56 +09:00