John Paul E. Balandan, CPA
797d37751a
Merge branch 'develop' into 4.6
2025-01-13 11:15:24 +08:00
John Paul E. Balandan, CPA
c3ac0f9483
chore: add more trailing commas in more places ( #9395 )
...
* Apply to parameters
* Apply to array destructuring
* Apply to match
* Apply for arguments
2025-01-13 11:03:02 +08:00
John Paul E. Balandan, CPA
eec3739823
Merge remote-tracking branch 'upstream/develop' into 4.6
2024-12-31 20:22:12 +08:00
Abdul Malik Ikhsan
f29210c0f0
refactor: use compare equals 1 for preg_match() return on array_filter
2024-12-29 01:13:34 +07:00
John Paul E. Balandan, CPA
c7548a3771
Merge branch 'develop' into 4.6
2024-12-29 00:21:53 +08:00
Abdul Malik Ikhsan
a2ec5054d7
refactor: enable AddArrowFunctionReturnTypeRector
2024-12-28 23:00:15 +07:00
Abdul Malik Ikhsan
ee4ee987b1
refactor: enable instanceof and strictBooleans rector set ( #9339 )
...
* refactor: enable instanceof and strictBooleans rector set
* refactor: bump to rector 2.0.4
* refactor: clean condition check
* refactor: revert ThirdParty change
* refactor: re-run phpstan baseline
* refactor: fix never empty array on Image
* refactor: avoid repetitive call pg_last_error()
* refactor: pg_last_error() always returns string
* refactor: use return empty string on pg_last_error() got empty "0"
* refactor: various compare !== 1 on preg_match()
* refactor: use falsy check on getenv()
* refactor: more !== 1 compare on preg_match()
* refactor: use empty string check on guessExtension
* refactor: run cs fix
* refactor: more !== 1 compare on preg_match()
* use direct result of pg_last_error()
* refactor: use str_contains() over strpos on Forge
* refactor: fix unused variable
* refactor: check empty string on ResponseTrait
* refactor: more preg_match() and empty string only check
* refactor: compare to 0 on preg_match_all()
* refactor: re-run rector
* refactor: preg_match_all() likely less to return false
2024-12-28 23:16:32 +08:00
neznaika0
8cff0995de
refactor: fix phpstan only boolean allowed ( #9302 )
...
* refactor: Fix `phpstan` boolean errors
* fix: Check predis response
* refactor: Improve comparison with an empty string
* dev: Update phpstan-baseline
* fix: Revert comparison with null
2024-12-28 20:21:06 +08:00
John Paul E. Balandan, CPA
bd5945df9b
Merge branch 'develop' into 4.6
2024-12-19 16:39:09 +08:00
John Paul E. Balandan, CPA
242745c661
refactor: split phpstan-baseline into smaller files ( #9299 )
...
* refactor: split phpstan-baseline into smaller files
* Checkout base branch to resolve codeigniter4/framework
* Fix rector changes
2024-12-15 08:38:40 +08:00
neznaika0
dae379fad2
refactor: fix phpstan signature for Closure ( #9304 )
2024-12-10 22:11:08 +08:00
Amel Junuzović
86278d9ab2
feat: Add optional dbGroup support in validation rules for multiple database connections
...
cs fixer
docs format
fix rules
add test testIsNotUniqueWithDBConnectionAsParameter
docs: update v4.5.6.rst
docs: fix tabs
docs update for v4.6.0
Update validation.rst
Update user_guide_src/source/changelogs/v4.6.0.rst
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
Add a test case for `InvalidArgumentException` and remove the duplicate comment.
refactor: code for is_unique and is_not_unique methods; extracted common code into prepareUniqueQuery method
rector and phpstan fix
2024-12-02 01:03:46 +08:00
Michal Sniatala
857673b3c3
fix: code issues after merging develop ( #9284 )
...
* cs-fix
* fix services call
* apply rector rules
2024-11-17 13:12:13 +01:00
michalsn
c32dcd4329
Merge remote-tracking branch 'upstream/develop' into 4.6
...
# Conflicts:
# system/Autoloader/Autoloader.php
# system/BaseModel.php
# system/CLI/CLI.php
# system/Database/MigrationRunner.php
# system/Exceptions/PageNotFoundException.php
# system/Router/RouteCollection.php
# system/Validation/FileRules.php
# tests/system/Autoloader/AutoloaderTest.php
# tests/system/Filters/FiltersTest.php
# tests/system/Test/ControllerTestTraitTest.php
# tests/system/Test/FeatureTestTraitTest.php
# tests/system/Validation/CreditCardRulesTest.php
# tests/system/Validation/FileRulesTest.php
# tests/system/Validation/StrictRules/DatabaseRelatedRulesTest.php
# tests/system/Validation/StrictRules/FileRulesTest.php
# tests/system/View/ViewTest.php
2024-11-17 12:21:31 +01:00
Michal Sniatala
bb5f925ca4
fix: respect complex language strings when using validation ( #9201 )
...
* fix: respect complex language strings when using validation
* cs fix
* changelog update
2024-11-17 10:50:15 +01:00
neznaika0
583e7b61da
refactor: up performance service()
2024-11-09 08:44:46 +03:00
Abdul Malik Ikhsan
3e672fadc6
refactor: enable FlipTypeControlToUseExclusiveTypeRector
2024-11-05 05:03:14 +07:00
michalsn
3e78c58f0b
Merge remote-tracking branch 'upstream/develop' into 4.6
2024-11-03 20:21:21 +01:00
Abdul Malik Ikhsan
dede747236
refactor: enable SimplifyBoolIdenticalTrueRector
2024-10-30 16:37:37 +07:00
michalsn
c830d5fe2f
Merge remote-tracking branch 'upstream/develop' into 4.6
2024-10-23 15:31:59 +02:00
Denny Septian Panggabean
4a7fbd1229
fix: getValidated() when validation multiple asterisk ( #9220 )
...
* fix: validation multiple asterisk
* docs: changelog
* Update user_guide_src/source/changelogs/v4.5.6.rst
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
* tests: multiple asterisk for fail
* fix: PHPStan errors appear
---------
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
2024-10-22 08:23:28 +02:00
kenjis
b352e31f95
Merge remote-tracking branch 'upstream/develop' into 4.6
2024-08-28 08:21:17 +09:00
kenjis
2979ece9a3
docs: make @var more precise
2024-08-23 08:30:22 +09:00
kenjis
99f41ee353
fix: TypeError when there is numeric field name
...
TypeError: str_contains(): Argument #1 ($haystack) must be of type string, int given
2024-08-23 08:28:17 +09:00
kenjis
bc616946b5
Merge remote-tracking branch 'upstream/develop' into 4.6
2024-08-06 09:19:18 +09:00
kenjis
156e45bab1
fix: rule differs and matches with dot array
2024-08-03 10:04:59 +09:00
kenjis
dc9adb1334
Merge remote-tracking branch 'upstream/develop' into 4.6
...
Conflicts:
system/Filters/Filters.php
2024-06-30 11:36:56 +09:00
Abdul Malik Ikhsan
073306c0dc
refactor: use first class callable on function call
2024-06-26 11:59:01 +07:00
kenjis
bbeda77c95
refactor: if conditions
...
We accept only booleans.
2024-06-20 09:55:45 +09:00
kenjis
5ab9e9c634
refactor: move FileRules code to StrictRules\FileRules
...
StrictRules are now the default.
2024-06-20 09:36:48 +09:00
kenjis
7604c25a23
Merge pull request #8966 from christianberkman/feat-min-dims
...
feat: [Validation] add `min_dims` rule in FileRules
2024-06-20 09:13:11 +09:00
Christian Berkman
fcbf7dd13e
rewrie if-ste if-statement
...
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
2024-06-19 22:36:23 +02:00
kenjis
cd82a0de4b
Merge remote-tracking branch 'upstream/develop' into 4.6
2024-06-19 11:17:27 +09:00
Christian Berkman
6c7f63cc0f
[FileRules] add min_dims validation rule
...
Signed-off-by: Christian Berkman <christianberkman@gmail.com>
2024-06-15 07:58:14 +02:00
kenjis
cdec7d0b39
fix: revert rule alpha
2024-06-13 08:04:39 +09:00
kenjis
1ca24da3d4
fix: if_exist does not work with array data
2024-06-13 07:55:58 +09:00
kenjis
d33d3c7fd6
fix: replace \TypeError with InvalidArgumentException
2024-05-06 19:19:23 +09:00
kenjis
4b8a50e693
refactor: use CodeIgniter\Exceptions\LogicException
2024-05-06 19:19:21 +09:00
kenjis
049fb2be4d
refactor: use CodeIgniter\Exceptions\InvalidArgumentException
2024-05-06 19:19:21 +09:00
kenjis
e25bc7e7a7
refactor: run rector
2024-04-06 09:24:47 +09:00
kenjis
6d595e01b1
Merge remote-tracking branch 'upstream/develop' into 4.5
...
Conflicts:
user_guide_src/source/database/configuration.rst
2024-03-26 08:23:46 +09:00
kenjis
5ebe2b7eeb
refactor: improve Validation error message for placeholder
2024-03-20 09:22:31 +09:00
kenjis
452543e813
Merge pull request #8607 from kenjis/feat-Services-get
...
perf: add Services::get()
2024-03-07 16:35:49 +09:00
kenjis
15ad0a3983
Merge remote-tracking branch 'upstream/develop' into 4.5
2024-03-05 16:09:50 +09:00
kenjis
3880337c93
refactor: use service() in framework code
2024-03-04 17:45:22 +09:00
kenjis
e60466dabc
fix: ErrorException is thrown if getimagesize() returns false
...
ErrorException
Trying to access array offset on value of type bool
2024-02-28 06:27:38 +09:00
kenjis
99a9148b0a
Merge remote-tracking branch 'upstream/develop' into 4.5
...
Conflicts:
psalm-baseline.xml
system/Router/AutoRouterImproved.php
system/Router/Router.php
2024-02-26 09:42:51 +09:00
kenjis
e1df9f5bcd
Merge remote-tracking branch 'upstream/develop' into 4.5
...
Conflicts:
system/Router/AutoRouterImproved.php
system/Router/Router.php
2024-02-26 06:59:33 +09:00
John Paul E. Balandan, CPA
06353a4037
style: Enable phpdoc_list_type fixer
2024-02-26 00:19:02 +08:00
John Paul E. Balandan, CPA
609be527ce
style: enable phpdoc_array_type ( #8580 )
2024-02-25 22:58:47 +08:00
