refactoring and fixed missing init in struct

This commit is contained in:
Annika Hannig 2024-11-20 17:22:19 +01:00
parent b91420dac9
commit 436a080c04
No known key found for this signature in database
GPG Key ID: 62E226E47DDCE58D

View File

@ -23,8 +23,7 @@ type metrics struct {
// Initialize // Initialize
func initMetrics(s *NeighborsStore) *metrics { func initMetrics(s *NeighborsStore) *metrics {
log.Println( log.Println("[metrics] Initializing export.")
"[metrics] Initializing export")
labels := []string{ labels := []string{
// The route server ID // The route server ID
@ -101,6 +100,7 @@ func initMetrics(s *NeighborsStore) *metrics {
routesReceived: routesReceived, routesReceived: routesReceived,
routesFiltered: routesFiltered, routesFiltered: routesFiltered,
routesPreferred: routesPreferred, routesPreferred: routesPreferred,
routesAccepted: routesAccepted,
} }
} }
@ -111,7 +111,11 @@ func (m *metrics) update(ctx context.Context) error {
// For all route servers, fetch neighbors list and // For all route servers, fetch neighbors list and
// update statistics. // update statistics.
for _, rsID := range rsIDs { for _, rsID := range rsIDs {
if !m.neighborsStore.IsInitialized(rsID) {
continue // No data from RS yet
}
rs := m.neighborsStore.sources.Get(rsID) rs := m.neighborsStore.sources.Get(rsID)
neighbors, err := m.neighborsStore.GetNeighborsAt(ctx, rsID) neighbors, err := m.neighborsStore.GetNeighborsAt(ctx, rsID)
if err != nil { if err != nil {
return err return err
@ -170,9 +174,7 @@ func StartMetrics(
m := initMetrics(neighborsStore) m := initMetrics(neighborsStore)
// Every 5 second, update the metrics // Every 5 second, update the metrics
log.Println( log.Println("[metrics] Starting refresh.")
"[metrics] Starting refresh.")
go func() {
for { for {
select { select {
case <-ctx.Done(): case <-ctx.Done():
@ -185,5 +187,4 @@ func StartMetrics(
} }
} }
} }
}()
} }