malhuda/alice-lg
1
0
Fork 0
Code Issues 39 Pull Requests 11 Actions Packages Projects Releases 2 Wiki Activity

Fix issue #83 and implement peer description comming from openbgpd #84

Merged
emil-palm merged 1 commits from fix-issue-83-Erroneous-peer-description into master 2021-11-15 18:18:43 +08:00
Conversation 3 Commits 1 Files Changed 1 +8 -3
emil-palm commented 2021-11-15 17:29:04 +08:00 (Migrated from github.com)
Copy Link

Before
Screenshot 2021-11-15 at 10 28 14
After:
Screenshot 2021-11-15 at 10 25 45

Closes #83

Before <img width="493" alt="Screenshot 2021-11-15 at 10 28 14" src="https://user-images.githubusercontent.com/103286/141756704-2632f316-98ff-404d-b1b6-623cccb248e1.png"> After: <img width="540" alt="Screenshot 2021-11-15 at 10 25 45" src="https://user-images.githubusercontent.com/103286/141756730-04f70958-fdbd-42ab-bf50-9138c28ecd92.png"> Closes #83
annikahannig commented 2021-11-15 18:17:16 +08:00 (Migrated from github.com)
Copy Link

Awesome! :)
Thank you!

Awesome! :) Thank you!
annikahannig (Migrated from github.com) reviewed 2021-11-15 18:18:02 +08:00
pkg/sources/openbgpd/decoders.go
@ -63,0 +63,4 @@
} else {
addr := decoders.MapGetString(nb, "remote_addr", "invalid_address")
asn := decoders.MapGetString(nb, "remote_as", "")
return fmt.Sprintf("PEER AS%s %s", asn, addr)
annikahannig (Migrated from github.com) commented 2021-11-15 18:18:01 +08:00
Copy Link

technically this else is not required :)

technically this else is not required :)
annikahannig (Migrated from github.com) approved these changes 2021-11-15 18:18:22 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
annikahannig
Labels
Clear labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
duplicate
This issue or pull request already exists
enhancement
New feature or request
go
Pull requests that update Go code
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
javascript
Pull requests that update Javascript code
priority
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: malhuda/alice-lg#84
No description provided.
Delete Branch "fix-issue-83-Erroneous-peer-description"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?