From 0304d228ae10ab25d2d8194b5fefaa2306c41fbb Mon Sep 17 00:00:00 2001
From: Tetrakern <26898880+Tetrakern@users.noreply.github.com>
Date: Thu, 17 Oct 2024 13:39:35 +0200
Subject: [PATCH] Remove `=` from base search page URL

Apparently, LiteSpeed Cache doesn't like that.
---
 includes/functions/_helpers-templates.php       | 2 +-
 includes/functions/hooks/_mobile_menu_hooks.php | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/includes/functions/_helpers-templates.php b/includes/functions/_helpers-templates.php
index 3b0ed871..9a0732f4 100644
--- a/includes/functions/_helpers-templates.php
+++ b/includes/functions/_helpers-templates.php
@@ -2398,7 +2398,7 @@ function fictioneer_render_icon_menu( $args ) {
   if ( $location === 'in-navigation' && FICTIONEER_SHOW_SEARCH_IN_MENUS ) {
     $output['search'] = sprintf(
       '<div class="menu-item menu-item-icon"><a href="%1$s" title="%2$s" rel="nofollow" aria-label="%3$s"><i class="fa-solid fa-magnifying-glass"></i></a></div>',
-      esc_url( home_url( '/?s=' ) ),
+      esc_url( home_url( '/?s' ) ),
       esc_attr__( 'Search Page', 'fictioneer' ),
       esc_attr__( 'Link to search page', 'fictioneer' )
     );
diff --git a/includes/functions/hooks/_mobile_menu_hooks.php b/includes/functions/hooks/_mobile_menu_hooks.php
index c46279e3..b8b22e72 100644
--- a/includes/functions/hooks/_mobile_menu_hooks.php
+++ b/includes/functions/hooks/_mobile_menu_hooks.php
@@ -385,7 +385,7 @@ function fictioneer_mobile_user_menu() {
   if ( FICTIONEER_SHOW_SEARCH_IN_MENUS ) {
     $output['search'] = sprintf(
       '<a href="%s" rel="nofollow"><i class="fa-solid fa-magnifying-glass mobile-menu__item-icon"></i> %s</a>',
-      esc_url( home_url( '/?s=' ) ),
+      esc_url( home_url( '/?s' ) ),
       __( 'Search', 'fictioneer' )
     );
   }