malhuda/fictioneer
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 112 Wiki Activity

Properly escape attributes in feeds

Browse Source
This commit is contained in:
Tetrakern 2024-03-26 00:15:40 +01:00
parent fca831c61d
commit 12172a0aea
2 changed files with 16 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
rss-rss-main.php
View File

@ -97,9 +97,15 @@ do_action( 'rss_tag_pre', 'rss2' );
<sy:updatePeriod><?php echo apply_filters( 'rss_update_period', 'hourly' ); ?></sy:updatePeriod>
<sy:updateFrequency><?php echo apply_filters( 'rss_update_frequency', '1' ); ?></sy:updateFrequency>
<?php if ( $cover ) : ?>
<webfeeds:cover image="<?php echo wp_get_attachment_image_src( $cover, 'full' )[0]; ?>" />
<?php endif; ?>
<?php
if ( $cover ) {
$cover_src = wp_get_attachment_image_src( $cover, 'full' );
if ( $cover_src ) {
echo '<webfeeds:cover image="' . esc_url( $cover_src[0] ) . '" />';
}
}
?>
<?php if ( has_site_icon() ) : ?>
<webfeeds:icon><?php echo get_site_icon_url(); ?></webfeeds:icon>
@ -118,7 +124,6 @@ do_action( 'rss_tag_pre', 'rss2' );
<?php
foreach ( $posts as $post ) {
// Setup
// $posts->the_post();
setup_postdata( $post );
// Data
@ -137,9 +142,9 @@ do_action( 'rss_tag_pre', 'rss2' );
<?php if ( $og_image ) : ?>
<webfeeds:featuredImage
url="<?php echo $og_image['url']; ?>"
width="<?php echo $og_image['width']; ?>"
height="<?php echo $og_image['height']; ?>"
url="<?php echo esc_url( $og_image['url'] ); ?>"
width="<?php echo esc_attr( $og_image['width'] ); ?>"
height="<?php echo esc_attr( $og_image['height'] ); ?>"
/>
<?php endif; ?>

8
rss-rss-story.php
View File

@ -80,7 +80,7 @@ do_action( 'rss_tag_pre', 'rss2' );
<sy:updateFrequency><?php echo apply_filters( 'rss_update_frequency', '1' ); ?></sy:updateFrequency>
<?php if ( $cover && is_array( $cover ) ) : ?>
<webfeeds:cover image="<?php echo $cover['url']; ?>" />
<webfeeds:cover image="<?php echo esc_url( $cover['url'] ); ?>" />
<?php endif; ?>
<?php if ( has_site_icon() ) : ?>
@ -177,9 +177,9 @@ do_action( 'rss_tag_pre', 'rss2' );
<?php if ( $og_image ) : ?>
<webfeeds:featuredImage
url="<?php echo $og_image['url']; ?>"
width="<?php echo $og_image['width']; ?>"
height="<?php echo $og_image['height']; ?>"
url="<?php echo esc_url( $og_image['url'] ); ?>"
width="<?php echo esc_attr( $og_image['width'] ); ?>"
height="<?php echo esc_attr( $og_image['height'] ); ?>"
/>
<?php endif; ?>