malhuda/fictioneer
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 112 Wiki Activity

Escape aria labels for checkmarks

Browse Source
This commit is contained in:
Tetrakern 2024-12-02 15:54:59 +01:00
parent 8d15f5ccdc
commit b9fbcd51ae
3 changed files with 30 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
includes/functions/_helpers-templates.php
View File

@ -294,6 +294,24 @@ if ( ! function_exists( 'fictioneer_get_safe_title' ) ) {
}
}
function custom_blur_title_with_spoiler( $title, $post_id, $context ) {
// Check if the context is relevant to modify the title (don't affect checkmarks)
if ( ! in_array( $context, ['story-chapter-list', 'shortcode-chapter-list'] ) ) {
return $title;
}
// Check if the title should be treated as a spoiler
// $has_spoiler = get_post_meta( $post_id, '_has_spoiler', true ); // Custom meta to mark spoilers
if ( true ) {
// Adds the class to the title without changing the HTML structure
$title = '<span class="spoiler-title">' . $title . '</span>'; // Using a neutral tag like <span>
}
return $title;
}
add_filter( 'fictioneer_filter_safe_title', 'custom_blur_title_with_spoiler', 10, 3 );
/**
* Returns sanitized safe title
*

7
includes/functions/_setup-shortcodes.php
View File

@ -1334,7 +1334,12 @@ function fictioneer_shortcode_chapter_list( $attr ) {
data-id="<?php echo $chapter_id; ?>"
role="checkbox"
aria-checked="false"
aria-label="<?php printf( esc_attr__( 'Chapter checkmark for %s.', 'fictioneer' ), $title ); ?>"
aria-label="<?php
printf(
esc_attr__( 'Chapter checkmark for %s.', 'fictioneer' ),
esc_attr( wp_strip_all_tags( $title ) )
);
?>"
><i class="fa-solid fa-check"></i></button>
<?php endif; ?>
</li>

7
includes/functions/hooks/_story_hooks.php
View File

@ -671,7 +671,12 @@ function fictioneer_story_chapters( $args ) {
data-id="<?php echo $chapter['id']; ?>"
role="checkbox"
aria-checked="false"
aria-label="<?php printf( esc_attr__( 'Chapter checkmark for %s.', 'fictioneer' ), $chapter['title'] ); ?>"
aria-label="<?php
printf(
esc_attr__( 'Chapter checkmark for %s.', 'fictioneer' ),
esc_attr( wp_strip_all_tags( $chapter['title'] ) )
);
?>"
><i class="fa-solid fa-check"></i></button>
<?php endif; ?>