malhuda/fictioneer
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 112 Wiki Activity

[BUG] Chapter permalinks issue #53

New Issue
Closed
opened 2024-09-26 03:57:42 +08:00 by iniznet · 2 comments
iniznet commented 2024-09-26 03:57:42 +08:00 (Migrated from github.com)
Copy Link

I'm not sure when it's start happens, but chapter links in the series page or table of content return the id like ?p= instead of proper permalink like /chapter/slug or /story/story-slug/slug.

The demo site also have the issue,
https://fictioneer-theme.com/story/the-sapphire-shadow/

There's a few sites I managed in the past and still running older version right now, they seems doesn't have this issue.

I'm not sure when it's start happens, but chapter links in the series page or table of content return the id like `?p=` instead of proper permalink like `/chapter/slug` or `/story/story-slug/slug`. The demo site also have the issue, https://fictioneer-theme.com/story/the-sapphire-shadow/ There's a few sites I managed in the past and still running older version right now, they seems doesn't have this issue.
Tetrakern commented 2024-09-26 04:48:05 +08:00 (Migrated from github.com)
Copy Link

Sigh... at least it's technically not broken.

Sigh... at least it's technically not broken.
Tetrakern commented 2024-09-26 04:59:48 +08:00 (Migrated from github.com)
Copy Link

Thanks for letting me know. Fixed in 2e8b81df98.

Thanks for letting me know. Fixed in https://github.com/Tetrakern/fictioneer/commit/2e8b81df98fb2191805359031054fb89b21e351b.
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
customization
Can be achieved with actions, filters, and some CSS.
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: malhuda/fictioneer#53
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?