malhuda/fictioneer
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 112 Wiki Activity

Also render footnotes in tooltip shortcode #60

Merged
iniznet merged 21 commits from feat/footnote into main 2024-10-16 01:53:41 +08:00
Conversation 13 Commits 21 Files Changed 18 +253 -47
iniznet commented 2024-10-14 00:07:50 +08:00 (Migrated from github.com)
Copy Link

Still in a draft state before my ssd broke, I will get it done tomorrow, some of them still need to be properly placed in their respective locations. So far, what do you think?

I'm also unsure where the fictioneer_after_tooltip_shortcode and the_content hooks should belong.

  • Proper code placement
  • Proper hook naming
  • Checkbox to toggle the footnote in settings
  • Docs

Preview:
image

Still in a draft state before my ssd broke, I will get it done tomorrow, some of them still need to be properly placed in their respective locations. So far, what do you think? I'm also unsure where the `fictioneer_after_tooltip_shortcode` and `the_content` hooks should belong. - [x] Proper code placement - [x] Proper hook naming - [x] Checkbox to toggle the footnote in settings - [x] Docs Preview: ![image](https://github.com/user-attachments/assets/7e001c45-8203-43aa-9b45-3163065d7cdc)
Tetrakern commented 2024-10-14 05:52:00 +08:00 (Migrated from github.com)
Copy Link

I have to take a deeper look later, but I immediately encountered one style problem. You surround the link with a block inside the paragraph. Should probably just need a span.

image
I have to take a deeper look later, but I immediately encountered one style problem. You surround the link with a block inside the paragraph. Should probably just need a span. <img width="762" alt="image" src="https://github.com/user-attachments/assets/8cab7f42-b0ea-4a16-bbee-a2b8f82a3f06">
iniznet commented 2024-10-15 00:18:04 +08:00 (Migrated from github.com)
Copy Link

I have to take a deeper look later, but I immediately encountered one style problem. You surround the link with a block inside the paragraph. Should probably just need a span.

You’re right, I totally forgot about that.

> I have to take a deeper look later, but I immediately encountered one style problem. You surround the link with a block inside the paragraph. Should probably just need a span. You’re right, I totally forgot about that.
iniznet commented 2024-10-15 00:38:15 +08:00 (Migrated from github.com)
Copy Link

Ready for a proper review! I believe this is good enough for the initial/basic footnote feature. I’ll leave the design style and appropriate user messages to you. Let me know if something needs to change.

Ready for a proper review! I believe this is good enough for the initial/basic footnote feature. I’ll leave the design style and appropriate user messages to you. Let me know if something needs to change.
Tetrakern (Migrated from github.com) reviewed 2024-10-15 00:54:40 +08:00
ACTIONS.md
Tetrakern (Migrated from github.com) commented 2024-10-15 00:54:40 +08:00
Copy Link

I believe you somehow ended up in the wrong line while editing.

I believe you somehow ended up in the wrong line while editing.
iniznet (Migrated from github.com) reviewed 2024-10-15 00:55:42 +08:00
ACTIONS.md
iniznet (Migrated from github.com) commented 2024-10-15 00:55:42 +08:00
Copy Link

gonna fix it asap!

gonna fix it asap!
Tetrakern commented 2024-10-15 01:09:36 +08:00 (Migrated from github.com)
Copy Link

I'm currently unsure what's the best style approach and whether this should be in the content (and therefore subject to the custom formatting) or its own box.

I'm currently unsure what's the best style approach and whether this should be in the content (and therefore subject to the custom formatting) or its own box.
iniznet commented 2024-10-15 01:29:53 +08:00 (Migrated from github.com)
Copy Link

I took a look at a few tl sites, most of them have simpler approach by either use the current style or add a horizontal line to separate the content from the footnote section.

I took a look at a few tl sites, most of them have simpler approach by either use the current style or add a horizontal line to separate the content from the footnote section.
Tetrakern commented 2024-10-15 02:03:28 +08:00 (Migrated from github.com)
Copy Link

I'm gong to ponder that for a bit. I'm currently stuck trying to figure out why scroll-margin-top does not work on the super link. It's a minor thing but I believe it would be better the footnote to not be hidden behind the nav bar if you scroll up again. I just don't want to add JS for that.

I'm gong to ponder that for a bit. I'm currently stuck trying to figure out why `scroll-margin-top` does not work on the super link. It's a minor thing but I believe it would be better the footnote to not be hidden behind the nav bar if you scroll up again. I just don't want to add JS for that.
iniznet commented 2024-10-15 02:29:39 +08:00 (Migrated from github.com)
Copy Link

Are you still have the issue? I tried to add .scroll-margin-top as tooltip anchor class, it's seems working fine.

https://github.com/user-attachments/assets/884ac58d-aad5-4d50-b883-512657f7b3fd

Are you still have the issue? I tried to add `.scroll-margin-top` as tooltip anchor class, it's seems working fine. https://github.com/user-attachments/assets/884ac58d-aad5-4d50-b883-512657f7b3fd
Tetrakern commented 2024-10-15 03:01:25 +08:00 (Migrated from github.com)
Copy Link

Somehow, the very same thing does not work for me. Typical.

Somehow, the very same thing does not work for me. Typical.
Tetrakern commented 2024-10-15 19:42:23 +08:00 (Migrated from github.com)
Copy Link

@iniznet What do you think about the style and changes? I believe it can be merged now.

@iniznet What do you think about the style and changes? I believe it can be merged now.
iniznet commented 2024-10-15 19:58:27 +08:00 (Migrated from github.com)
Copy Link

Looks great! I think the only thing left is to explain the shortcode somewhere, like in DOCUMENTATION.md.

Looks great! I think the only thing left is to explain the shortcode somewhere, like in `DOCUMENTATION.md`.
Tetrakern (Migrated from github.com) approved these changes 2024-10-16 01:53:23 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
Tetrakern
Labels
Clear labels
bug
Something isn't working
customization
Can be achieved with actions, filters, and some CSS.
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: malhuda/fictioneer#60
No description provided.
Delete Branch "feat/footnote"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?