malhuda/gitea
1
0
Fork 0
mirror of https://github.com/go-gitea/gitea.git synced 2025-02-20 11:43:57 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Fix

Browse Source
This commit is contained in:
hiifong 2025-01-11 15:48:13 +08:00
parent 35a2b9b3a5
commit 1660737ec8
No known key found for this signature in database
GPG Key ID: 0814559E2F97194D
2 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
modules/git/ref.go
View File

@ -105,7 +105,7 @@ func (ref RefName) IsFor() bool {
return strings.HasPrefix(string(ref), ForPrefix)
}
var forReviewPattern = regexp.MustCompile(ForReviewPrefix + `^[1-9][0-9]\d*$`)
var forReviewPattern = regexp.MustCompile(ForReviewPrefix + `[1-9]\d*$`)
func (ref RefName) IsForReview() bool {
return forReviewPattern.MatchString(string(ref))

11
modules/git/ref_test.go
View File

@ -26,6 +26,17 @@ func TestRefName(t *testing.T) {
assert.Equal(t, "main", RefName("refs/for/main").ForBranchName())
assert.Equal(t, "my/branch", RefName("refs/for/my/branch").ForBranchName())
// Test for review name
assert.Equal(t, false, RefName("refs/for-review/-1").IsForReview())
assert.Equal(t, false, RefName("refs/for-review/0").IsForReview())
assert.Equal(t, false, RefName("refs/for-review/01").IsForReview())
assert.Equal(t, true, RefName("refs/for-review/1").IsForReview())
assert.Equal(t, true, RefName("refs/for-review/10").IsForReview())
assert.Equal(t, true, RefName("refs/for-review/10999").IsForReview())
assert.Equal(t, false, RefName("refs/for-review/a10").IsForReview())
assert.Equal(t, false, RefName("refs/for-review/10a").IsForReview())
assert.Equal(t, false, RefName("refs/for-review/abc").IsForReview())
// Test commit hashes.
assert.Equal(t, "c0ffee", RefName("c0ffee").ShortName())
}