malhuda/jikan-rest
1
0
Fork 0
mirror of https://github.com/jikan-me/jikan-rest.git synced 2025-02-20 11:23:35 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

added tests for invalid score searches

Browse Source
This commit is contained in:
pushrbx 2022-12-16 18:53:01 +00:00
parent aca707a508
commit 2d2a1c97ed
2 changed files with 97 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

65
database/factories/AnimeFactory.php
View File

@ -49,7 +49,13 @@ class AnimeFactory extends JikanModelFactory
"airing" => $status == "Currently Airing",
"aired" => new CarbonDateRange($aired_from, $aired_to),
"duration" => "",
"rating" => $this->faker->randomElement(["R - 17+ (violence & profanity)", "PG"]),
"rating" => $this->faker->randomElement([
"R - 17+ (violence & profanity)",
"PG - Children",
"PG-13 - Teens 13 or older",
"R+ - Mild Nudity",
"Rx - Hentai"
]),
"score" => $this->faker->randomFloat(2, 1.00, 9.99),
"scored_by" => $this->faker->randomDigitNotNull(),
"rank" => $this->faker->randomDigitNotNull(),
@ -127,6 +133,11 @@ class AnimeFactory extends JikanModelFactory
return $this->state($this->serializeStateDefinition($overrides));
}
private function isScoreValueValid($score): bool
{
return $score <= 9.99 && $score >= 0.0;
}
private function getOppositeOverridesFromQueryStringParameters(Collection $additionalParams): array
{
$overrides = [];
@ -141,18 +152,30 @@ class AnimeFactory extends JikanModelFactory
}
if ($additionalParams->has("min_score") && !$additionalParams->has("max_score")) {
$overrides["score"] = $this->faker->randomFloat(2, 1.00, floatval($additionalParams["min_score"]));
$min_score = floatval($additionalParams["min_score"]);
if ($this->isScoreValueValid($min_score)) {
$overrides["score"] = $this->faker->randomFloat(2, 1.00, floatval($additionalParams["min_score"]));
}
}
if (!$additionalParams->has("min_score") && $additionalParams->has("max_score")) {
$overrides["score"] = $this->faker->randomFloat(2, floatval($additionalParams["max_score"]), 9.99);
$max_score = $additionalParams["max_score"];
if ($this->isScoreValueValid($max_score)) {
$overrides["score"] = $this->faker->randomFloat(2, floatval($additionalParams["max_score"]), 9.99);
}
}
if ($additionalParams->has("min_score") && $additionalParams->has("max_score")) {
$overrides["score"] = $this->faker->randomElement([
$this->faker->randomFloat(2, 1.00, floatval($additionalParams["min_score"])),
$this->faker->randomFloat(2, floatval($additionalParams["max_score"]), 9.99)
]);
$min_score = floatval($additionalParams["min_score"]);
$max_score = floatval($additionalParams["max_score"]);
if ($this->isScoreValueValid($min_score) && $this->isScoreValueValid($max_score))
{
$overrides["score"] = $this->faker->randomElement([
$this->faker->randomFloat(2, 1.00, floatval($additionalParams["min_score"])),
$this->faker->randomFloat(2, floatval($additionalParams["max_score"]), 9.99)
]);
}
}
if ($additionalParams->has("status")) {
@ -162,7 +185,8 @@ class AnimeFactory extends JikanModelFactory
"upcoming" => "Not yet aired"
];
$overrides["status"] = $this->faker->randomElement(array_diff(array_keys($statuses), [strtolower($additionalParams["status"])]));
$rndKey = $this->faker->randomElement(array_diff(array_keys($statuses), [strtolower($additionalParams["status"])]));
$overrides["status"] = $statuses[$rndKey];
}
if (($additionalParams->has("genres") && $additionalParams->has("genres_exclude")) || (
@ -254,22 +278,39 @@ class AnimeFactory extends JikanModelFactory
}
if ($additionalParams->has("min_score") && !$additionalParams->has("max_score")) {
$overrides["score"] = $this->faker->randomFloat(2, floatval($additionalParams["min_score"]), 9.99);
$min_score = floatval($additionalParams["min_score"]);
if ($this->isScoreValueValid($min_score)) {
$overrides["score"] = $this->faker->randomFloat(2, floatval($additionalParams["min_score"]), 9.99);
}
}
if (!$additionalParams->has("min_score") && $additionalParams->has("max_score")) {
$overrides["score"] = $this->faker->randomFloat(2, 1.00, floatval($additionalParams["max_score"]));
$max_score = floatval($additionalParams["max_score"]);
if ($this->isScoreValueValid($max_score)) {
$overrides["score"] = $this->faker->randomFloat(2, 1.00, floatval($additionalParams["max_score"]));
}
}
if ($additionalParams->has(["min_score", "max_score"])) {
$overrides["score"] = $this->faker->randomFloat(2, floatval($additionalParams["min_score"]), floatval($additionalParams["max_score"]));
$min_score = floatval($additionalParams["min_score"]);
$max_score = floatval($additionalParams["max_score"]);
if ($this->isScoreValueValid($min_score) && $this->isScoreValueValid($max_score)) {
$overrides["score"] = $this->faker->randomFloat(2, floatval($additionalParams["min_score"]), floatval($additionalParams["max_score"]));
}
}
if ($additionalParams->has("status")) {
$overrides["status"] = match (strtolower($additionalParams["status"])) {
"complete" => "Finished Airing",
"airing" => "Currently Airing",
"upcoming" => "Not yet aired"
"upcoming" => "Not yet aired",
default => $this->faker->randomElement([
"Finished Airing",
"Currently Airing",
"Not yet aired"
])
};
}

47
tests/Integration/AnimeSearchEndpointTest.php
View File

@ -100,7 +100,7 @@ class AnimeSearchEndpointTest extends TestCase
];
}
public function statusParameterProvider(): array
public function commonParameterProvider(): array
{
return [
[["status" => "airing"]],
@ -109,6 +109,18 @@ class AnimeSearchEndpointTest extends TestCase
[["status" => "Airing"]],
[["status" => "Complete"]],
[["status" => "Upcoming"]],
[["max_score" => "8"]],
[["min_score" => "6"]],
[["max_score" => "7", "min_score" => "3"]]
];
}
public function invalidScoreParameterProvider(): array
{
return [
[["max_score" => "634638"], 15],
[["min_score" => "673473"], 0],
[["max_score" => "72344", "min_score" => "3532325"], 0]
];
}
@ -277,10 +289,39 @@ class AnimeSearchEndpointTest extends TestCase
$this->assertCount(5, $content["data"]);
}
public function testSearchByInvalidStatusParameter()
{
$params = [
"status" => "gibberish"
];
$this->generateFiveSpecificAndTenRandomElementsInDb($params);
$content = $this->getJsonResponse($params);
$this->seeStatusCode(200);
$this->assertPaginationData(15);
$this->assertIsArray($content["data"]);
// it should return all, and disregard the gibberish filter
$this->assertCount(15, $content["data"]);
}
/**
* @dataProvider statusParameterProvider
* @dataProvider invalidScoreParameterProvider
*/
public function testSearchByStatus($params)
public function testSearchByInvalidScoreParameters($params, $expectedCount)
{
$this->generateFiveSpecificAndTenRandomElementsInDb($params);
$content = $this->getJsonResponse($params);
$this->seeStatusCode(200);
$this->assertPaginationData($expectedCount);
$this->assertIsArray($content["data"]);
$this->assertCount($expectedCount, $content["data"]);
}
/**
* @dataProvider commonParameterProvider
*/
public function testSearchByCommonParams($params)
{
$this->generateFiveSpecificAndTenRandomElementsInDb($params);