malhuda/jikan-rest
1
0
Fork 0
mirror of https://github.com/jikan-me/jikan-rest.git synced 2025-02-20 11:23:35 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixed flags in the URL

Browse Source
This commit is contained in:
pushrbx 2024-05-31 16:52:15 +01:00
parent acf1af823c
commit 5425426c66
No known key found for this signature in database
GPG Key ID: A16A474BBC2C91D9
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Dto/Concerns/PreparesData.php
View File

@ -43,7 +43,7 @@ trait PreparesData
}
}
// if the property is optional and the value is an empty string, we want to ignore it.
if ($property->type->isOptional && $propertyVal === "") {
if ($property->type->isOptional && $propertyVal === "" && !$property->type->acceptsType("bool")) {
$propertyVal = null;
}

16
tests/Integration/SeasonControllerTest.php
View File

@ -15,6 +15,14 @@ class SeasonControllerTest extends TestCase
use SyntheticMongoDbTransaction;
use ScoutFlush;
private function continuingUrlProvider(): array
{
return [
"?continuing=true" => ["/v4/seasons/2024/winter?continuing=true"],
"?continuing" => ["/v4/seasons/2024/winter?continuing"],
];
}
public function testShouldFilterOutAnimeWithGarbledAiredString()
{
Carbon::setTestNow(Carbon::parse("2024-01-11"));
@ -95,7 +103,11 @@ class SeasonControllerTest extends TestCase
$this->assertCount(2, $content["data"]);
}
public function testShouldNotFilterOutContinuingItemsFromPreviousSeasons()
/**
* @return void
* @dataProvider continuingUrlProvider
*/
public function testShouldNotFilterOutContinuingItemsFromPreviousSeasons($requestUrl)
{
Carbon::setTestNow(Carbon::parse("2024-01-11"));
// an item in the future airing
@ -131,7 +143,7 @@ class SeasonControllerTest extends TestCase
$state["airing"] = true;
$f->create($state);
$content = $this->getJsonResponse([], "/v4/seasons/2024/winter?continuing=true");
$content = $this->getJsonResponse([], $requestUrl);
$this->seeStatusCode(200);
$this->assertIsArray($content["data"]);
$this->assertCount(3, $content["data"]);