malhuda/jikan-rest
1
0
Fork 0
mirror of https://github.com/jikan-me/jikan-rest.git synced 2025-02-20 11:23:35 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fixed buggy tests

Browse Source
This commit is contained in:
pushrbx 2023-02-05 17:39:00 +00:00
parent baa5e9c557
commit e48d23520f
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
database/factories/JikanMediaModelFactory.php
View File

@ -203,7 +203,7 @@ abstract class JikanMediaModelFactory extends JikanModelFactory implements Media
if ($this->descriptor->hasRatingParam() && $additionalParams->has("rating")) {
$v = AnimeRatingEnum::tryFrom(strtolower($additionalParams["rating"]));
if (!is_null($v)) {
$overrides["rating"] = $v->value;
$overrides["rating"] = $v->label;
}
}

9
tests/Integration/TopAnimeEndpointTest.php
View File

@ -3,6 +3,7 @@
namespace Tests\Integration;
use App\Anime;
use App\Enums\AnimeRatingEnum;
use App\Testing\ScoutFlush;
use App\Testing\SyntheticMongoDbTransaction;
use Illuminate\Database\Eloquent\Factories\Sequence;
@ -36,7 +37,7 @@ class TopAnimeEndpointTest extends TestCase
["rank", false, ["type" => "ona"]],
["rank", false, ["type" => "special"]],
["rank", false, ["type" => "music"]],
["members", true, ["filter" => "upcoming"]],
["rank", false, ["filter" => "upcoming"]],
["members", true, ["filter" => "bypopularity"]],
["favorites", true, ["filter" => "favorite"]]
];
@ -68,7 +69,7 @@ class TopAnimeEndpointTest extends TestCase
// create a model factory and pin the rating attribute's value to "G - All Ages".
$f = Anime::factory($expectedCount)
->state([
"rating" => "G - All Ages"
"rating" => AnimeRatingEnum::g()->label
]);
// pin attribute values in the model factory and create data in the database
@ -103,8 +104,8 @@ class TopAnimeEndpointTest extends TestCase
}
$content = $this->getJsonResponse($params);
$expectedItems = $items->map(fn($elem) => data_get($elem, $fieldToOrderBy));
$actualItems = collect($content["data"])->map(fn($elem) => data_get($elem, $fieldToOrderBy));
$expectedItems = $items->map(fn($elem) => data_get($elem, $fieldToOrderBy))->values();
$actualItems = collect($content["data"])->map(fn($elem) => data_get($elem, $fieldToOrderBy))->values();
$this->seeStatusCode(200);
$this->assertPaginationData($expectedCount);