From fcea1262721b78a55b42e6845a752406a0d05e4e Mon Sep 17 00:00:00 2001 From: pushrbx Date: Sat, 17 Dec 2022 16:13:38 +0000 Subject: [PATCH] fixed orderBy parameter tests --- database/factories/AnimeFactory.php | 6 +++--- tests/Integration/AnimeSearchEndpointTest.php | 5 +++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/database/factories/AnimeFactory.php b/database/factories/AnimeFactory.php index 8e393f7..7f666d1 100644 --- a/database/factories/AnimeFactory.php +++ b/database/factories/AnimeFactory.php @@ -145,9 +145,9 @@ class AnimeFactory extends JikanModelFactory return fn($i) => $randomDate->copy()->addDays($i); })()), "rating" => ((function() { - $validRatingNumbers = array_map(fn($el) => floatval($el), range(1, 9)); - $validRatingNumbersCount = count($validRatingNumbers); - return fn($i) => $validRatingNumbers[$i % $validRatingNumbersCount]; + $validRatingItems = array_values(AnimeSearchQueryBuilder::MAP_RATING); + $validRatingItemsCount = count($validRatingItems); + return fn($i) => $validRatingItems[$i % $validRatingItemsCount]; })()), "title" => ((function() { $alphabet = range("a", "z"); diff --git a/tests/Integration/AnimeSearchEndpointTest.php b/tests/Integration/AnimeSearchEndpointTest.php index 39afee4..75630f4 100644 --- a/tests/Integration/AnimeSearchEndpointTest.php +++ b/tests/Integration/AnimeSearchEndpointTest.php @@ -368,7 +368,7 @@ class AnimeSearchEndpointTest extends TestCase /** * @dataProvider orderByFieldMappingProvider */ - public function testOrdering(string $paramName, string $orderByField) + public function testOrderByQueryStringParameter(string $paramName, string $orderByField) { $expectedCount = 3; $f = Anime::factory($expectedCount); @@ -377,7 +377,7 @@ class AnimeSearchEndpointTest extends TestCase */ $items = $f->createManyWithOrder($orderByField); $content = $this->getJsonResponse([ - "orderBy" => $paramName + "order_by" => $paramName ]); $this->seeStatusCode(200); @@ -393,6 +393,7 @@ class AnimeSearchEndpointTest extends TestCase } $this->assertEquals(0, $expectedItems->diff($actualItems)->count()); + $this->assertTrue($expectedItems->toArray() === $actualItems->toArray()); } /**