malhuda/lookingglass
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 16 Wiki Activity

Fix ss command on newer versions of iproute2 #38

Merged
abrenner merged 1 commits from fix-ss-command-on-iproute2-v6.7.0 into main 2024-02-04 17:37:45 +08:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
abrenner commented 2024-02-04 00:55:31 +08:00 (Migrated from github.com)
Copy Link

The iproute2 package starting in version 6.7.0 changed the way the ss command outputs internal TCP information via the -i/--info option which LookingGlass uses to display latency information.

In prior versions the flags: -Hint would show internal TCP information. However starting in version 6.7.0 an additional flag -p/--processes needs to be passed in to get the same information.

The changes were committed upstream in
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/misc/ss.c?id=87d804ca0854b09c07872e9fd6036bf5d3e0cc85 and effects all versions of iproute2 6.7.0 and later.

Old versions continue to work with and without the -p/--processes flag. In my limited testing it appears adding extra flag is backwards compatible and should not break anything.

The iproute2 package starting in version 6.7.0 changed the way the `ss` command outputs internal TCP information via the `-i/--info` option which LookingGlass uses to display latency information. In prior versions the flags: `-Hint` would show internal TCP information. However starting in version 6.7.0 an additional flag `-p/--processes` needs to be passed in to get the same information. The changes were committed upstream in https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/misc/ss.c?id=87d804ca0854b09c07872e9fd6036bf5d3e0cc85 and effects all versions of iproute2 6.7.0 and later. Old versions continue to work with and without the `-p/--processes` flag. In my limited testing it appears adding extra flag is backwards compatible and should not break anything.
dqos commented 2024-02-04 17:37:40 +08:00 (Migrated from github.com)
Copy Link

Hi @abrenner thank you for your PR. This looks valid and seems to be working fine, so let's merge it!

Hi @abrenner thank you for your PR. This looks valid and seems to be working fine, so let's merge it!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: malhuda/lookingglass#38
No description provided.
Delete Branch "fix-ss-command-on-iproute2-v6.7.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?