malhuda/lookingglass
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 16 Wiki Activity

Fix ipv6 issues #8

Merged
kimma merged 2 commits from fix-ipv6-issues into main 2022-12-27 17:23:42 +08:00
Conversation 2 Commits 2 Files Changed 2 +2 -2
kimma commented 2022-12-27 07:27:48 +08:00 (Migrated from github.com)
Copy Link

Discovered some ipv6 issues:

  • Ping may default to ipv4 since -4 is not specified
  • Incorrect use of || instead of && for the isValidIpv6/isValidHost check
Discovered some ipv6 issues: * Ping may default to ipv4 since `-4` is not specified * Incorrect use of || instead of && for the isValidIpv6/isValidHost check
dqos commented 2022-12-27 17:22:59 +08:00 (Migrated from github.com)
Copy Link

Hello @kimma, thank you for your contribution. You are correct, I will merge this PR and create a new release as soon as possible 😃

Hello @kimma, thank you for your contribution. You are correct, I will merge this PR and create a new release as soon as possible 😃
dqos (Migrated from github.com) approved these changes 2022-12-27 17:23:13 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
dqos
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: malhuda/lookingglass#8
No description provided.
Delete Branch "fix-ipv6-issues"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?