malhuda/msm-4.14
1
0
Fork 0
mirror of https://github.com/rd-stuffs/msm-4.14.git synced 2025-02-20 11:45:48 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

USB: fix error handling in trancevibrator

Browse Source 
trancevibrator should not pretend success if it returns an error.

Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Oliver Neukum 2008-01-30 16:06:03 +01:00 committed by Greg Kroah-Hartman
parent efa66f14e2
commit 0cc5e2e7c3
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/usb/misc/trancevibrator.c
View File

@ -59,13 +59,14 @@ static ssize_t set_speed(struct device *dev, struct device_attribute *attr,
{ {
struct usb_interface *intf = to_usb_interface(dev); struct usb_interface *intf = to_usb_interface(dev);
struct trancevibrator *tv = usb_get_intfdata(intf); struct trancevibrator *tv = usb_get_intfdata(intf);
int temp, retval; int temp, retval, old;
temp = simple_strtoul(buf, NULL, 10); temp = simple_strtoul(buf, NULL, 10);
if (temp > 255) if (temp > 255)
temp = 255; temp = 255;
else if (temp < 0) else if (temp < 0)
temp = 0; temp = 0;
old = tv->speed;
tv->speed = temp; tv->speed = temp;
dev_dbg(&tv->udev->dev, "speed = %d\n", tv->speed); dev_dbg(&tv->udev->dev, "speed = %d\n", tv->speed);
@ -77,6 +78,7 @@ static ssize_t set_speed(struct device *dev, struct device_attribute *attr,
tv->speed, /* speed value */ tv->speed, /* speed value */
0, NULL, 0, USB_CTRL_GET_TIMEOUT); 0, NULL, 0, USB_CTRL_GET_TIMEOUT);
if (retval) { if (retval) {
tv->speed = old;
dev_dbg(&tv->udev->dev, "retval = %d\n", retval); dev_dbg(&tv->udev->dev, "retval = %d\n", retval);
return retval; return retval;
} }