From 238de8f97899fb0f945493f7075c3cd3483f69f1 Mon Sep 17 00:00:00 2001 From: Juhyung Park Date: Sat, 1 Feb 2025 23:18:39 +0900 Subject: [PATCH] qcacld-3.0: Fix conditional umac_stop_complete_cb() implementation After turning the location services off (to actually turn off or on the Wi-Fi device), users started reporting a 30 seconds delay when their PCIe Wi-Fi device is brought back up. This is due to Qualcomm's improper conditional umac_stop_complete_cb() implementation that simply neglects `qdf_event_set(stop_evt)` when QDF_ENABLE_TRACING is not defined. As our local modification disables QDF_ENABLE_TRACING, this implementation bug triggers a 30 seconds delayed reset. All functions/APIs used within umac_stop_complete_cb() are available without QDF_ENABLE_TRACING defined, so remove the conditional implementation. Fixes: bcd3d019d8e1 ("qcacld-3.0: Execute sme_stop and mac_stop in mc thread context") Change-Id: I6055404c5df4e0232ea344e1c2669871e61cb9a7 Signed-off-by: Juhyung Park Signed-off-by: Richard Raya --- .../qcacld-3.0/core/mac/src/sys/common/src/wlan_qct_sys.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/qcacld-3.0/core/mac/src/sys/common/src/wlan_qct_sys.c b/drivers/staging/qcacld-3.0/core/mac/src/sys/common/src/wlan_qct_sys.c index 2e9f8490c6ea..728bf42ba2b3 100644 --- a/drivers/staging/qcacld-3.0/core/mac/src/sys/common/src/wlan_qct_sys.c +++ b/drivers/staging/qcacld-3.0/core/mac/src/sys/common/src/wlan_qct_sys.c @@ -56,7 +56,6 @@ QDF_STATUS sys_build_message_header(SYS_MSG_ID msg_id, * * Return: none */ -#ifdef QDF_ENABLE_TRACING static void umac_stop_complete_cb(void *user_data) { qdf_event_t *stop_evt = (qdf_event_t *) user_data; @@ -64,12 +63,6 @@ static void umac_stop_complete_cb(void *user_data) QDF_ASSERT(QDF_IS_STATUS_SUCCESS(qdf_status)); } -#else -static void umac_stop_complete_cb(void *user_data) -{ - return; -} -#endif static inline QDF_STATUS umac_stop_flush_cb(struct scheduler_msg *msg) {