From 2c66335c0c74d7994bb3a5d41f6f6ae46079cdd9 Mon Sep 17 00:00:00 2001
From: Rupesh Gujare <rupesh.gujare@atmel.com>
Date: Tue, 13 Aug 2013 18:24:23 +0100
Subject: [PATCH] staging: ozwpan: Simply if condition
Making code simpler for readability.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/ozwpan/ozhcd.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c
index 5a417c833400..4b658d4adabc 100644
--- a/drivers/staging/ozwpan/ozhcd.c
+++ b/drivers/staging/ozwpan/ozhcd.c
@@ -478,7 +478,7 @@ static int oz_enqueue_ep_urb(struct oz_port *port, u8 ep_addr, int in_dir,
struct urb *urb, u8 req_id)
{
struct oz_urb_link *urbl;
- struct oz_endpoint *ep;
+ struct oz_endpoint *ep = NULL;
int err = 0;
if (ep_addr >= OZ_NB_ENDPOINTS) {
@@ -506,11 +506,12 @@ static int oz_enqueue_ep_urb(struct oz_port *port, u8 ep_addr, int in_dir,
oz_free_urb_link(urbl);
return 0;
}
- if (in_dir && port->in_ep[ep_addr])
+
+ if (in_dir)
ep = port->in_ep[ep_addr];
- else if (!in_dir && port->out_ep[ep_addr])
+ else
ep = port->out_ep[ep_addr];
- else {
+ if (!ep) {
err = -ENOMEM;
goto out;
}