malhuda/msm-4.14
1
0
Fork 0
mirror of https://github.com/rd-stuffs/msm-4.14.git synced 2025-02-20 11:45:48 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

kconfig: Delete unnecessary checks before the function call "sym_calc_value"

Browse Source 
The sym_calc_value() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Michal Marek <mmarek@suse.com>
This commit is contained in:
Markus Elfring 2015-07-07 21:48:23 +02:00 committed by Michal Marek
parent d770e558e2
commit 35ffd08d9b
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
scripts/kconfig/confdata.c
View File

@ -268,8 +268,7 @@ int conf_read_simple(const char *name, int def)
goto load;
sym_add_change_count(1);
if (!sym_defconfig_list) {
if (modules_sym)
sym_calc_value(modules_sym);
sym_calc_value(modules_sym);
return 1;
}
@ -404,9 +403,7 @@ setsym:
}
free(line);
fclose(in);
if (modules_sym)
sym_calc_value(modules_sym);
sym_calc_value(modules_sym);
return 0;
}

3
scripts/kconfig/symbol.c
View File

@ -467,8 +467,7 @@ void sym_clear_all_valid(void)
for_all_symbols(i, sym)
sym->flags &= ~SYMBOL_VALID;
sym_add_change_count(1);
if (modules_sym)
sym_calc_value(modules_sym);
sym_calc_value(modules_sym);
}
bool sym_tristate_within_range(struct symbol *sym, tristate val)