malhuda/msm-4.14
1
0
Fork 0
mirror of https://github.com/rd-stuffs/msm-4.14.git synced 2025-03-23 19:57:01 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

staging: comedi: adv_pci_dio: remove board reset during (*detach)

Browse Source 
The board reset function disables and clears all interrupts. It also
resets all the digital output channels to 0.

Interrupts are not used by this driver so the disable/clear during the
(*detach) is not necessary.

Reseting all the digital outputs to 0 might not be desired depending
on what the outputs are connected to.

Remove the board reset and just use comedi_pci_detach() directly for
the driver (*detach).

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
H Hartley Sweeten 2015-11-18 10:07:15 -07:00 committed by Greg Kroah-Hartman
parent e01b70bc13
commit 4190c22008
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/staging/comedi/drivers/adv_pci_dio.c
View File

@ -548,18 +548,11 @@ static int pci_dio_auto_attach(struct comedi_device *dev,
return 0;
}
static void pci_dio_detach(struct comedi_device *dev)
{
if (dev->iobase)
pci_dio_reset(dev);
comedi_pci_detach(dev);
}
static struct comedi_driver adv_pci_dio_driver = {
.driver_name = "adv_pci_dio",
.module = THIS_MODULE,
.auto_attach = pci_dio_auto_attach,
.detach = pci_dio_detach,
.detach = comedi_pci_detach,
};
static int adv_pci_dio_pci_probe(struct pci_dev *dev,