malhuda/msm-4.14
1
0
Fork 0
mirror of https://github.com/rd-stuffs/msm-4.14.git synced 2025-02-20 11:45:48 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

BACKPORT: Makefile: default to LLVM_IAS=1

Browse Source 
LLVM_IAS=1 controls enabling clang's integrated assembler via
-integrated-as. This was an explicit opt in until we could enable
assembler support in Clang for more architecures. Now we have support
and CI coverage of LLVM_IAS=1 for all architecures except a few more
bugs affecting s390 and powerpc.

This commit flips the default from opt in via LLVM_IAS=1 to opt out via
LLVM_IAS=0.  CI systems or developers that were previously doing builds
with CC=clang or LLVM=1 without explicitly setting LLVM_IAS must now
explicitly opt out via LLVM_IAS=0, otherwise they will be implicitly
opted-in.

This finally shortens the command line invocation when cross compiling
with LLVM to simply:

$ make ARCH=arm64 LLVM=1

Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Bug: 209655537
[nd: conflict in Documentation/kbuild/llvm.rst]
(cherry picked from commit f12b034afeb3a977bbb1c6584dedc0f3dc666f14)
[cyberknight777: Flip the last LLVM_IAS check aswell]
Signed-off-by: Cyber Knight <cyberknight755@gmail.com>
This commit is contained in:
Nick Desaulniers 2021-08-06 10:27:01 -07:00 committed by Richard Raya
parent ca08dd2065
commit 900179848c
2 changed files with 12 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Documentation/kbuild/llvm.rst
View File

@ -59,18 +59,14 @@ They can be enabled individually. The full list of the parameters: ::
READELF=llvm-readelf HOSTCC=clang HOSTCXX=clang++ HOSTAR=llvm-ar \ READELF=llvm-readelf HOSTCC=clang HOSTCXX=clang++ HOSTAR=llvm-ar \
HOSTLD=ld.lld HOSTLD=ld.lld
Currently, the integrated assembler is disabled by default. You can pass The integrated assembler is enabled by default. You can pass ``LLVM_IAS=0`` to
``LLVM_IAS=1`` to enable it. disable it.
Omitting CROSS_COMPILE Omitting CROSS_COMPILE
---------------------- ----------------------
As explained above, ``CROSS_COMPILE`` is used to set ``--target=<triple>``. As explained above, ``CROSS_COMPILE`` is used to set ``--target=<triple>``.
Unless ``LLVM_IAS=1`` is specified, ``CROSS_COMPILE`` is also used to derive
``--prefix=<path>`` to search for the GNU assembler and linker.
If ``CROSS_COMPILE`` is not specified, the ``--target=<triple>`` is inferred If ``CROSS_COMPILE`` is not specified, the ``--target=<triple>`` is inferred
from ``ARCH``. from ``ARCH``.
@ -78,7 +74,12 @@ That means if you use only LLVM tools, ``CROSS_COMPILE`` becomes unnecessary.
For example, to cross-compile the arm64 kernel:: For example, to cross-compile the arm64 kernel::
make ARCH=arm64 LLVM=1 LLVM_IAS=1 make ARCH=arm64 LLVM=1
If ``LLVM_IAS=0`` is specified, ``CROSS_COMPILE`` is also used to derive
``--prefix=<path>`` to search for the GNU assembler and linker. ::
make ARCH=arm64 LLVM=1 LLVM_IAS=0 CROSS_COMPILE=aarch64-linux-gnu-
Supported Architectures Supported Architectures
----------------------- -----------------------

6
Makefile
View File

@ -544,10 +544,12 @@ else
CLANG_FLAGS += --target=$(notdir $(CROSS_COMPILE:%-=%)) CLANG_FLAGS += --target=$(notdir $(CROSS_COMPILE:%-=%))
endif # CROSS_COMPILE endif # CROSS_COMPILE
ifneq ($(LLVM_IAS),1) ifeq ($(LLVM_IAS),0)
CLANG_FLAGS += -no-integrated-as CLANG_FLAGS += -no-integrated-as
GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)elfedit)) GCC_TOOLCHAIN_DIR := $(dir $(shell which $(CROSS_COMPILE)elfedit))
CLANG_FLAGS += --prefix=$(GCC_TOOLCHAIN_DIR)$(notdir $(CROSS_COMPILE)) CLANG_FLAGS += --prefix=$(GCC_TOOLCHAIN_DIR)$(notdir $(CROSS_COMPILE))
else
CLANG_FLAGS += -integrated-as
endif endif
CLANG_FLAGS += -Werror=unknown-warning-option CLANG_FLAGS += -Werror=unknown-warning-option
CLANG_FLAGS += $(call cc-option, -Wno-misleading-indentation) CLANG_FLAGS += $(call cc-option, -Wno-misleading-indentation)
@ -910,7 +912,7 @@ KBUILD_CFLAGS += $(call cc-option, -gsplit-dwarf, -g)
else else
KBUILD_CFLAGS += -g KBUILD_CFLAGS += -g
endif endif
ifneq ($(LLVM_IAS),1) ifeq ($(LLVM_IAS),0)
KBUILD_AFLAGS += -Wa,-gdwarf-2 KBUILD_AFLAGS += -Wa,-gdwarf-2
endif endif
endif endif