malhuda/msm-4.14
1
0
Fork 0
mirror of https://github.com/rd-stuffs/msm-4.14.git synced 2025-02-20 11:45:48 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

staging: ozwpan: Deletion of unnecessary checks before the function call "oz_free_urb_link"

Browse Source 
The oz_free_urb_link() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Markus Elfring 2014-11-25 16:51:08 +01:00 committed by Greg Kroah-Hartman
parent c1e433accd
commit 968bf0cf0c
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/staging/ozwpan/ozhcd.c
View File

@ -354,8 +354,7 @@ static void oz_complete_urb(struct usb_hcd *hcd, struct urb *urb,
}
spin_lock(&g_tasklet_lock);
spin_unlock_irqrestore(&g_tasklet_lock, irq_state);
if (cancel_urbl)
oz_free_urb_link(cancel_urbl);
oz_free_urb_link(cancel_urbl);
}
/*
@ -523,8 +522,7 @@ static int oz_dequeue_ep_urb(struct oz_port *port, u8 ep_addr, int in_dir,
}
}
spin_unlock_bh(&port->ozhcd->hcd_lock);
if (urbl)
oz_free_urb_link(urbl);
oz_free_urb_link(urbl);
return urbl ? 0 : -EIDRM;
}