mirror of
https://github.com/rd-stuffs/msm-4.14.git
synced 2025-02-20 11:45:48 +08:00
[ Upstream commit 5d44ab9e204200a78ad55cdf185aa2bb109b5950 ] On most devices using the btqcomsmd driver (e.g. the DragonBoard 410c and other devices based on the Qualcomm MSM8916/MSM8909/... SoCs) the Bluetooth firmware seems to become unresponsive for a while after setting the BD address. On recent kernel versions (at least 5.17+) this often causes timeouts for subsequent commands, e.g. the HCI reset sent by the Bluetooth core during initialization: Bluetooth: hci0: Opcode 0x c03 failed: -110 Unfortunately this behavior does not seem to be documented anywhere. Experimentation suggests that the minimum necessary delay to avoid the problem is ~150us. However, to be sure add a sleep for > 1ms in case it is a bit longer on other firmware versions. Older kernel versions are likely also affected, although perhaps with slightly different errors or less probability. Side effects can easily hide the issue in most cases, e.g. unrelated incoming interrupts that cause the necessary delay. Fixes: 1511cc750c3d ("Bluetooth: Introduce Qualcomm WCNSS SMD based HCI driver") Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
245 lines
5.5 KiB
C
245 lines
5.5 KiB
C
/*
|
|
* Copyright (c) 2016, Linaro Ltd.
|
|
* Copyright (c) 2015, Sony Mobile Communications Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 and
|
|
* only version 2 as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/rpmsg.h>
|
|
#include <linux/soc/qcom/wcnss_ctrl.h>
|
|
#include <linux/platform_device.h>
|
|
|
|
#include <net/bluetooth/bluetooth.h>
|
|
#include <net/bluetooth/hci_core.h>
|
|
|
|
#include "btqca.h"
|
|
|
|
struct btqcomsmd {
|
|
struct hci_dev *hdev;
|
|
|
|
bdaddr_t bdaddr;
|
|
struct rpmsg_endpoint *acl_channel;
|
|
struct rpmsg_endpoint *cmd_channel;
|
|
};
|
|
|
|
static int btqcomsmd_recv(struct hci_dev *hdev, unsigned int type,
|
|
const void *data, size_t count)
|
|
{
|
|
struct sk_buff *skb;
|
|
|
|
/* Use GFP_ATOMIC as we're in IRQ context */
|
|
skb = bt_skb_alloc(count, GFP_ATOMIC);
|
|
if (!skb) {
|
|
hdev->stat.err_rx++;
|
|
return -ENOMEM;
|
|
}
|
|
|
|
hci_skb_pkt_type(skb) = type;
|
|
skb_put_data(skb, data, count);
|
|
|
|
return hci_recv_frame(hdev, skb);
|
|
}
|
|
|
|
static int btqcomsmd_acl_callback(struct rpmsg_device *rpdev, void *data,
|
|
int count, void *priv, u32 addr)
|
|
{
|
|
struct btqcomsmd *btq = priv;
|
|
|
|
btq->hdev->stat.byte_rx += count;
|
|
return btqcomsmd_recv(btq->hdev, HCI_ACLDATA_PKT, data, count);
|
|
}
|
|
|
|
static int btqcomsmd_cmd_callback(struct rpmsg_device *rpdev, void *data,
|
|
int count, void *priv, u32 addr)
|
|
{
|
|
struct btqcomsmd *btq = priv;
|
|
|
|
return btqcomsmd_recv(btq->hdev, HCI_EVENT_PKT, data, count);
|
|
}
|
|
|
|
static int btqcomsmd_send(struct hci_dev *hdev, struct sk_buff *skb)
|
|
{
|
|
struct btqcomsmd *btq = hci_get_drvdata(hdev);
|
|
int ret;
|
|
|
|
switch (hci_skb_pkt_type(skb)) {
|
|
case HCI_ACLDATA_PKT:
|
|
ret = rpmsg_send(btq->acl_channel, skb->data, skb->len);
|
|
hdev->stat.acl_tx++;
|
|
hdev->stat.byte_tx += skb->len;
|
|
break;
|
|
case HCI_COMMAND_PKT:
|
|
ret = rpmsg_send(btq->cmd_channel, skb->data, skb->len);
|
|
hdev->stat.cmd_tx++;
|
|
break;
|
|
default:
|
|
ret = -EILSEQ;
|
|
break;
|
|
}
|
|
|
|
if (!ret)
|
|
kfree_skb(skb);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int btqcomsmd_open(struct hci_dev *hdev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int btqcomsmd_close(struct hci_dev *hdev)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static int btqcomsmd_setup(struct hci_dev *hdev)
|
|
{
|
|
struct btqcomsmd *btq = hci_get_drvdata(hdev);
|
|
struct sk_buff *skb;
|
|
int err;
|
|
|
|
skb = __hci_cmd_sync(hdev, HCI_OP_RESET, 0, NULL, HCI_INIT_TIMEOUT);
|
|
if (IS_ERR(skb))
|
|
return PTR_ERR(skb);
|
|
kfree_skb(skb);
|
|
|
|
/* Devices do not have persistent storage for BD address. If no
|
|
* BD address has been retrieved during probe, mark the device
|
|
* as having an invalid BD address.
|
|
*/
|
|
if (!bacmp(&btq->bdaddr, BDADDR_ANY)) {
|
|
set_bit(HCI_QUIRK_INVALID_BDADDR, &hdev->quirks);
|
|
return 0;
|
|
}
|
|
|
|
/* When setting a configured BD address fails, mark the device
|
|
* as having an invalid BD address.
|
|
*/
|
|
err = qca_set_bdaddr_rome(hdev, &btq->bdaddr);
|
|
if (err) {
|
|
set_bit(HCI_QUIRK_INVALID_BDADDR, &hdev->quirks);
|
|
return 0;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int btqcomsmd_set_bdaddr(struct hci_dev *hdev, const bdaddr_t *bdaddr)
|
|
{
|
|
int ret;
|
|
|
|
ret = qca_set_bdaddr_rome(hdev, bdaddr);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* The firmware stops responding for a while after setting the bdaddr,
|
|
* causing timeouts for subsequent commands. Sleep a bit to avoid this.
|
|
*/
|
|
usleep_range(1000, 10000);
|
|
return 0;
|
|
}
|
|
|
|
static int btqcomsmd_probe(struct platform_device *pdev)
|
|
{
|
|
struct btqcomsmd *btq;
|
|
struct hci_dev *hdev;
|
|
void *wcnss;
|
|
int ret;
|
|
|
|
btq = devm_kzalloc(&pdev->dev, sizeof(*btq), GFP_KERNEL);
|
|
if (!btq)
|
|
return -ENOMEM;
|
|
|
|
wcnss = dev_get_drvdata(pdev->dev.parent);
|
|
|
|
btq->acl_channel = qcom_wcnss_open_channel(wcnss, "APPS_RIVA_BT_ACL",
|
|
btqcomsmd_acl_callback, btq);
|
|
if (IS_ERR(btq->acl_channel))
|
|
return PTR_ERR(btq->acl_channel);
|
|
|
|
btq->cmd_channel = qcom_wcnss_open_channel(wcnss, "APPS_RIVA_BT_CMD",
|
|
btqcomsmd_cmd_callback, btq);
|
|
if (IS_ERR(btq->cmd_channel)) {
|
|
ret = PTR_ERR(btq->cmd_channel);
|
|
goto destroy_acl_channel;
|
|
}
|
|
|
|
hdev = hci_alloc_dev();
|
|
if (!hdev) {
|
|
ret = -ENOMEM;
|
|
goto destroy_cmd_channel;
|
|
}
|
|
|
|
hci_set_drvdata(hdev, btq);
|
|
btq->hdev = hdev;
|
|
SET_HCIDEV_DEV(hdev, &pdev->dev);
|
|
|
|
hdev->bus = HCI_SMD;
|
|
hdev->open = btqcomsmd_open;
|
|
hdev->close = btqcomsmd_close;
|
|
hdev->send = btqcomsmd_send;
|
|
hdev->setup = btqcomsmd_setup;
|
|
hdev->set_bdaddr = btqcomsmd_set_bdaddr;
|
|
|
|
ret = hci_register_dev(hdev);
|
|
if (ret < 0)
|
|
goto hci_free_dev;
|
|
|
|
platform_set_drvdata(pdev, btq);
|
|
|
|
return 0;
|
|
|
|
hci_free_dev:
|
|
hci_free_dev(hdev);
|
|
destroy_cmd_channel:
|
|
rpmsg_destroy_ept(btq->cmd_channel);
|
|
destroy_acl_channel:
|
|
rpmsg_destroy_ept(btq->acl_channel);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int btqcomsmd_remove(struct platform_device *pdev)
|
|
{
|
|
struct btqcomsmd *btq = platform_get_drvdata(pdev);
|
|
|
|
hci_unregister_dev(btq->hdev);
|
|
hci_free_dev(btq->hdev);
|
|
|
|
rpmsg_destroy_ept(btq->cmd_channel);
|
|
rpmsg_destroy_ept(btq->acl_channel);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id btqcomsmd_of_match[] = {
|
|
{ .compatible = "qcom,wcnss-bt", },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(of, btqcomsmd_of_match);
|
|
|
|
static struct platform_driver btqcomsmd_driver = {
|
|
.probe = btqcomsmd_probe,
|
|
.remove = btqcomsmd_remove,
|
|
.driver = {
|
|
.name = "btqcomsmd",
|
|
.of_match_table = btqcomsmd_of_match,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(btqcomsmd_driver);
|
|
|
|
MODULE_AUTHOR("Bjorn Andersson <bjorn.andersson@sonymobile.com>");
|
|
MODULE_DESCRIPTION("Qualcomm SMD HCI driver");
|
|
MODULE_LICENSE("GPL v2");
|