Trond Myklebust 26bebd5a78 SUNRPC: Don't call __UDPX_INC_STATS() from a preemptible context ...

[ Upstream commit 0afa6b4412988019db14c6bfb8c6cbdf120ca9ad ]

Calling __UDPX_INC_STATS() from a preemptible context leads to a
warning of the form:

 BUG: using __this_cpu_add() in preemptible [00000000] code: kworker/u5:0/31
 caller is xs_udp_data_receive_workfn+0x194/0x270
 CPU: 1 PID: 31 Comm: kworker/u5:0 Not tainted 4.15.0-rc8-00076-g90ea9f1 #2
 Workqueue: xprtiod xs_udp_data_receive_workfn
 Call Trace:
  dump_stack+0x85/0xc1
  check_preemption_disabled+0xce/0xe0
  xs_udp_data_receive_workfn+0x194/0x270
  process_one_work+0x318/0x620
  worker_thread+0x20a/0x390
  ? process_one_work+0x620/0x620
  kthread+0x120/0x130
  ? __kthread_bind_mask+0x60/0x60
  ret_from_fork+0x24/0x30

Since we're taking a spinlock in those functions anyway, let's fix the
issue by moving the call so that it occurs under the spinlock.

Reported-by: kernel test robot <fengguang.wu@intel.com>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-04-26 11:02:19 +02:00

..

auth_gss

sunrpc: remove incorrect HMAC request initialization

2018-04-19 08:56:20 +02:00

xprtrdma

svcrdma: Fix Read chunk round-up

2018-04-26 11:02:19 +02:00

addr.c

…

auth_generic.c

NFS client updates for Linux 4.9

2016-10-13 21:28:20 -07:00

auth_null.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

auth_unix.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

auth.c

sched/headers: Prepare to remove <linux/cred.h> inclusion from <linux/sched.h>

2017-03-02 08:42:31 +01:00

backchannel_rqst.c

SUNRPC: Don't hold the transport lock when receiving backchannel data

2017-08-16 15:10:16 -04:00

cache.c

NFS client updates for Linux 4.11

2017-03-01 16:10:30 -08:00

clnt.c

SUNRPC: remove some dead code.

2017-09-06 12:31:15 -04:00

debugfs.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

Kconfig

svcrdma: Introduce local rdma_rw API helpers

2017-04-25 17:25:55 -04:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

netns.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

rpc_pipe.c

rpc_pipefs: fix double-dput()

2018-04-24 09:36:38 +02:00

rpcb_clnt.c

sunrpc: mark all struct rpc_procinfo instances as const

2017-07-13 15:57:57 -04:00

sched.c

sunrpc: Fix rpc_task_begin trace point

2017-12-14 09:53:09 +01:00

socklib.c

sunrpc: do not pull udp headers on receive

2016-04-11 15:31:33 -04:00

stats.c

sunrpc: move pc_count out of struct svc_procinfo

2017-07-13 15:58:02 -04:00

sunrpc_syms.c

SUNRPC: cleanup ida information when removing sunrpc module

2017-01-24 15:29:24 -05:00

sunrpc.h

…

svc_xprt.c

sunrpc: Allocate up to RPCSVC_MAXPAGES per svc_rqst

2017-07-12 15:54:55 -04:00

svc.c

sunrpc: Const-ify struct sv_serv_ops

2017-08-24 22:13:50 -04:00

svcauth_unix.c

kernel: make groups_sort calling a responsibility group_info allocators

2017-12-20 10:10:18 +01:00

svcauth.c

locking/atomic, kref: Implement kref_put_lock()

2017-01-18 10:03:29 +01:00

svcsock.c

NFS client updates for Linux 4.14

2017-09-11 22:01:44 -07:00

sysctl.c

Replace <asm/uaccess.h> with <linux/uaccess.h> globally

2016-12-24 11:46:01 -08:00

timer.c

…

xdr.c

sunrpc: Fix xdr_init_decode_pages() documenting comment

2017-04-25 16:12:34 -04:00

xprt.c

SUNRPC: Fix a race in the receive code path

2017-12-20 10:10:21 +01:00

xprtmultipath.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

xprtsock.c

SUNRPC: Don't call __UDPX_INC_STATS() from a preemptible context

2018-04-26 11:02:19 +02:00