Josef Bacik
0eaf383c6a
btrfs: do not BUG_ON in link_to_fixup_dir
[ Upstream commit 91df99a6eb50d5a1bc70fff4a09a0b7ae6aab96d ]
While doing error injection testing I got the following panic
kernel BUG at fs/btrfs/tree-log.c:1862!
invalid opcode: 0000 [#1] SMP NOPTI
CPU: 1 PID: 7836 Comm: mount Not tainted 5.13.0-rc1+ #305
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.13.0-2.fc32 04/01/2014
RIP: 0010:link_to_fixup_dir+0xd5/0xe0
RSP: 0018:ffffb5800180fa30 EFLAGS: 00010216
RAX: fffffffffffffffb RBX: 00000000fffffffb RCX: ffff8f595287faf0
RDX: ffffb5800180fa37 RSI: ffff8f5954978800 RDI: 0000000000000000
RBP: ffff8f5953af9450 R08: 0000000000000019 R09: 0000000000000001
R10: 000151f408682970 R11: 0000000120021001 R12: ffff8f5954978800
R13: ffff8f595287faf0 R14: ffff8f5953c77dd0 R15: 0000000000000065
FS: 00007fc5284c8c40(0000) GS:ffff8f59bbd00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fc5287f47c0 CR3: 000000011275e002 CR4: 0000000000370ee0
Call Trace:
replay_one_buffer+0x409/0x470
? btree_read_extent_buffer_pages+0xd0/0x110
walk_up_log_tree+0x157/0x1e0
walk_log_tree+0xa6/0x1d0
btrfs_recover_log_trees+0x1da/0x360
? replay_one_extent+0x7b0/0x7b0
open_ctree+0x1486/0x1720
btrfs_mount_root.cold+0x12/0xea
? __kmalloc_track_caller+0x12f/0x240
legacy_get_tree+0x24/0x40
vfs_get_tree+0x22/0xb0
vfs_kern_mount.part.0+0x71/0xb0
btrfs_mount+0x10d/0x380
? vfs_parse_fs_string+0x4d/0x90
legacy_get_tree+0x24/0x40
vfs_get_tree+0x22/0xb0
path_mount+0x433/0xa10
__x64_sys_mount+0xe3/0x120
do_syscall_64+0x3d/0x80
entry_SYSCALL_64_after_hwframe+0x44/0xae
We can get -EIO or any number of legitimate errors from
btrfs_search_slot(), panicing here is not the appropriate response. The
error path for this code handles errors properly, simply return the
error.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-06-03 08:36:22 +02:00
..
2020-11-05 11:07:03 +01:00
2019-08-06 19:05:21 +02:00
2021-03-03 18:22:54 +01:00
2020-04-02 16:34:33 +02:00
2019-12-17 20:37:24 +01:00
2018-12-01 09:42:51 +01:00
2021-06-03 08:36:22 +02:00
2020-11-05 11:07:05 +01:00
2021-05-22 10:57:42 +02:00
2021-05-26 11:46:58 +02:00
2019-08-06 19:05:23 +02:00
2021-03-17 16:34:34 +01:00
2018-11-13 11:15:12 -08:00
2020-11-05 11:06:52 +01:00
2019-05-08 07:20:49 +02:00
2019-03-23 14:35:21 +01:00
2021-05-22 10:57:35 +02:00
2021-05-26 11:47:00 +02:00
2020-12-02 08:34:44 +01:00
2019-12-05 15:37:28 +01:00
2020-01-27 14:46:06 +01:00
2020-08-21 09:48:18 +02:00
2021-05-22 10:57:22 +02:00
2021-05-22 10:57:38 +02:00
2020-06-20 10:25:05 +02:00
2018-12-17 09:28:53 +01:00
2021-05-22 10:57:36 +02:00
2021-04-16 11:57:53 +02:00
2019-12-01 09:13:57 +01:00
2020-04-24 08:00:45 +02:00
2021-02-10 09:12:09 +01:00
2021-03-03 18:22:46 +01:00
2020-09-03 11:22:29 +02:00
2021-05-22 10:57:22 +02:00
2021-03-07 11:27:42 +01:00
2019-12-17 20:38:50 +01:00
2020-12-29 13:46:57 +01:00
2020-08-21 09:48:15 +02:00
2021-06-03 08:36:18 +02:00
2020-12-29 13:47:01 +01:00
2021-01-23 15:48:45 +01:00
2020-06-20 10:25:01 +02:00
2020-01-12 12:11:59 +01:00
2021-03-03 18:22:36 +01:00
2021-04-16 11:57:48 +02:00
2020-02-28 16:36:08 +01:00
2021-02-23 14:00:31 +01:00
2021-06-03 08:36:12 +02:00
2020-01-09 10:17:55 +01:00
2021-03-03 18:22:44 +01:00
2020-10-29 09:07:11 +01:00
2021-04-07 12:47:02 +02:00
2020-08-26 10:29:54 +02:00
2021-05-22 10:57:39 +02:00
2021-03-07 11:27:45 +01:00
2018-12-17 09:28:48 +01:00
2021-01-17 13:58:59 +01:00
2021-03-17 16:34:30 +01:00
2020-08-21 09:48:22 +02:00
2021-03-07 11:27:43 +01:00
2018-12-21 14:13:04 +01:00
2020-06-03 08:18:03 +02:00
2019-07-03 13:15:59 +02:00
2021-03-17 16:34:35 +01:00
2019-11-06 12:42:59 +01:00
2021-05-22 10:57:43 +02:00
2020-11-05 11:06:58 +01:00
2020-01-14 20:05:39 +01:00
2020-01-09 10:17:58 +01:00
2020-05-20 08:16:58 +02:00
2020-03-11 18:02:43 +01:00
2019-02-06 17:31:34 +01:00
2021-04-16 11:57:48 +02:00
2020-01-12 12:11:59 +01:00
2020-10-14 09:51:09 +02:00
2020-11-18 18:28:03 +01:00
2020-05-27 16:42:51 +02:00
2020-04-24 08:00:43 +02:00
2021-02-23 14:00:30 +01:00
2020-04-02 16:34:21 +02:00
2018-11-10 07:48:33 -08:00
2019-12-17 20:38:57 +01:00
2020-11-24 13:05:50 +01:00
2020-01-09 10:17:55 +01:00
2020-03-11 18:02:53 +01:00
2020-05-02 17:24:20 +02:00
2020-03-20 10:54:16 +01:00
2019-05-04 09:15:18 +02:00
2020-05-02 17:24:47 +02:00
2019-12-01 09:13:51 +01:00
2021-04-28 12:08:41 +02:00
2021-03-24 11:05:05 +01:00
2019-05-04 09:15:18 +02:00
2019-10-11 18:18:48 +02:00
2020-11-24 13:05:44 +01:00
2020-01-04 13:59:58 +01:00
2020-08-21 09:48:00 +02:00