malhuda/msm-4.14
1
0
Fork 0
mirror of https://github.com/rd-stuffs/msm-4.14.git synced 2025-02-20 11:45:48 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
msm-4.14/fs
History
Chao Yu 19c7377b56 f2fs: fix to avoid deadlock when merging inline data 
When testing with fsstress, kworker and user threads were both blocked:

INFO: task kworker/u16:1:16580 blocked for more than 120 seconds.
"echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message.
kworker/u16:1   D ffff8803f2595390     0 16580      2 0x00000000
Workqueue: writeback bdi_writeback_workfn (flush-251:0)
 ffff8802730e5760 0000000000000046 ffff880274729fc0 0000000000012440
 ffff8802730e5fd8 ffff8802730e4010 0000000000012440 0000000000012440
 ffff8802730e5fd8 0000000000012440 ffff880274729fc0 ffff88026eb50000
Call Trace:
 [<ffffffff816fe9d9>] schedule+0x29/0x70
 [<ffffffff816ff895>] rwsem_down_read_failed+0xa5/0xf9
 [<ffffffff81378584>] call_rwsem_down_read_failed+0x14/0x30
 [<ffffffffa0694feb>] f2fs_write_data_page+0x31b/0x420 [f2fs]
 [<ffffffffa0690f1a>] __f2fs_writepage+0x1a/0x50 [f2fs]
 [<ffffffffa06922a0>] f2fs_write_data_pages+0xe0/0x290 [f2fs]
 [<ffffffff811473b3>] do_writepages+0x23/0x40
 [<ffffffff811cc3ee>] __writeback_single_inode+0x4e/0x250
 [<ffffffff811cd4f1>] writeback_sb_inodes+0x2c1/0x470
 [<ffffffff811cd73e>] __writeback_inodes_wb+0x9e/0xd0
 [<ffffffff811cda0b>] wb_writeback+0x1fb/0x2d0
 [<ffffffff811cdb7c>] wb_do_writeback+0x9c/0x220
 [<ffffffff811ce232>] bdi_writeback_workfn+0x72/0x1c0
 [<ffffffff8106b74e>] process_one_work+0x1de/0x5b0
 [<ffffffff8106e78f>] worker_thread+0x11f/0x3e0
 [<ffffffff810750ce>] kthread+0xde/0xf0
 [<ffffffff817093f8>] ret_from_fork+0x58/0x90

fsstress thread stack:
 [<ffffffff81139f0e>] sleep_on_page+0xe/0x20
 [<ffffffff81139ef7>] __lock_page+0x67/0x70
 [<ffffffff8113b100>] find_lock_page+0x50/0x80
 [<ffffffff8113b24f>] find_or_create_page+0x3f/0xb0
 [<ffffffffa06983a9>] sync_node_pages+0x259/0x810 [f2fs]
 [<ffffffffa068d874>] write_checkpoint+0x1a4/0xce0 [f2fs]
 [<ffffffffa0686b0c>] f2fs_sync_fs+0x7c/0xd0 [f2fs]
 [<ffffffffa067c813>] f2fs_sync_file+0x143/0x5f0 [f2fs]
 [<ffffffff811d301b>] vfs_fsync_range+0x2b/0x40
 [<ffffffff811d304c>] vfs_fsync+0x1c/0x20
 [<ffffffff811d3291>] do_fsync+0x41/0x70
 [<ffffffff811d32d3>] SyS_fdatasync+0x13/0x20
 [<ffffffff817094a2>] system_call_fastpath+0x16/0x1b
 [<ffffffffffffffff>] 0xffffffffffffffff

The reason of this issue is:
CPU0:					CPU1:
 - f2fs_write_data_pages
					 - f2fs_sync_fs
					  - write_checkpoint
					   - block_operations
					    - f2fs_lock_all
					     - down_write(sbi->cp_rwsem)
  - lock_page(page)
  - f2fs_write_data_page
					    - sync_node_pages
					     - flush_inline_data
					      - pagecache_get_page(page, GFP_LOCK)
   - f2fs_lock_op
    - down_read(sbi->cp_rwsem)

This patch alters to use trylock_page in flush_inline_data to fix this ABBA
deadlock issue.

Signed-off-by: Chao Yu <chao2.yu@samsung.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
2016-02-26 11:52:03 -08:00
..
9p
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
adfs
fs/adfs/adfs.h: tidy up comments
2016-01-20 17:09:18 -08:00
affs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
afs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
autofs4
switch ->get_link() to delayed_call, kill ->put_link()
2015-12-30 13:01:03 -05:00
befs
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
bfs
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
btrfs
Merge branch 'for-linus-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs
2016-02-19 13:40:42 -08:00
cachefiles
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
ceph
ceph: fix snap context leak in error path
2016-02-04 18:25:15 +01:00
cifs
cifs: fix erroneous return value
2016-02-10 18:23:31 -06:00
coda
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-01-23 12:24:56 -08:00
configfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
cramfs
don't put symlink bodies in pagecache into highmem
2015-12-08 22:41:36 -05:00
debugfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
devpts
pty: make sure super_block is still valid in final /dev/tty close
2016-02-06 23:45:46 -08:00
dlm
[regression] fix braino in fs/dlm/user.c
2016-01-21 17:45:15 -05:00
ecryptfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
efivarfs
efi: Make efivarfs entries immutable by default
2016-02-10 16:25:52 +00:00
efs
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
exofs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
exportfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
ext2
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-01-23 12:24:56 -08:00
ext4
ext4: fix crashes in dioread_nolock mode
2016-02-19 00:33:21 -05:00
f2fs
f2fs: fix to avoid deadlock when merging inline data
2016-02-26 11:52:03 -08:00
fat
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
freevxfs
don't put symlink bodies in pagecache into highmem
2015-12-08 22:41:36 -05:00
fscache
FS-Cache: Handle a write to the page immediately beyond the EOF marker
2015-11-11 02:11:02 -05:00
fuse
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
gfs2
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
hfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
hfsplus
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
hostfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
hpfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
hugetlbfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
isofs
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
jbd2
fs: use block_device name vsprintf helper
2016-01-06 13:03:18 -05:00
jffs2
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-01-23 12:24:56 -08:00
jfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
kernfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
lockd
lockd: constify nlmsvc_binding structure
2016-01-07 10:10:50 -05:00
logfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
minix
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
ncpfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
nfs
NFS: Cleanup - rename NFS_LAYOUT_RETURN_BEFORE_CLOSE
2016-01-27 20:40:05 -05:00
nfs_common
…
nfsd
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
nilfs2
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
nls
…
notify
fsnotify: turn fsnotify reaper thread into a workqueue job
2016-02-18 16:23:24 -08:00
ntfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
ocfs2
ocfs2/dlm: clear refmap bit of recovery lock while doing local recovery cleanup
2016-02-05 18:10:40 -08:00
omfs
…
openpromfs
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
overlayfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
proc
proc: revert /proc/<pid>/maps [stack:TID] annotation
2016-02-03 08:28:43 -08:00
pstore
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
qnx4
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
qnx6
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
quota
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
ramfs
don't put symlink bodies in pagecache into highmem
2015-12-08 22:41:36 -05:00
reiserfs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
romfs
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
squashfs
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
sysfs
platform/chrome: Branch for v4.4
2015-11-13 21:53:18 -08:00
sysv
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
tracefs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
ubifs
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
udf
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-01-23 12:24:56 -08:00
ufs
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
xfs
xfs: fix endianness error when checking log block crc on big endian platforms
2016-02-08 11:03:58 +11:00
aio.c
…
anon_inodes.c
…
attr.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
bad_inode.c
fs/bad_inode.c: is_bad_inode can be boolean
2015-12-06 21:17:14 -05:00
binfmt_aout.c
…
binfmt_elf_fdpic.c
libnvdimm for 4.4:
2015-11-10 12:07:22 -08:00
binfmt_elf.c
ELF: Also pass any interpreter's file header to `arch_check_elf'
2016-01-20 00:39:20 +01:00
binfmt_em86.c
…
binfmt_flat.c
…
binfmt_misc.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
binfmt_script.c
…
block_dev.c
block: fix pfn_mkwrite() DAX fault handler
2016-02-05 18:10:40 -08:00
buffer.c
fs: use block_device name vsprintf helper
2016-01-06 13:03:18 -05:00
char_dev.c
…
compat_binfmt_elf.c
…
compat_ioctl.c
Bluetooth: Add missing COMPATIBLE_IOCTL for UART line discipline
2016-01-27 10:48:26 -05:00
compat.c
saner calling conventions for copy_mount_options()
2016-01-04 10:28:32 -05:00
coredump.c
fs/coredump: prevent "" / "." / ".." core path components
2016-01-20 17:09:18 -08:00
dax.c
dax: dirty inode only if required
2016-02-05 18:10:40 -08:00
dcache.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
dcookies.c
…
direct-io.c
block: fix use-after-free in dio_bio_complete
2016-01-30 22:02:10 -07:00
drop_caches.c
…
eventfd.c
Documentation: filesystem: Fix typo in fs/eventfd.c
2015-12-08 14:52:03 +01:00
eventpoll.c
epoll: restrict EPOLLEXCLUSIVE to POLLIN and POLLOUT
2016-02-05 18:10:40 -08:00
exec.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
fcntl.c
fcntl: allow to set O_DIRECT flag on pipe
2016-01-09 02:55:37 -05:00
fhandle.c
…
file_table.c
…
file.c
kmemcg: account certain kmem allocations to memcg
2016-01-14 16:00:49 -08:00
filesystems.c
find_filesystem(): simplify comparison
2016-01-19 12:02:23 -05:00
fs_pin.c
…
fs_struct.c
…
fs-writeback.c
writeback: keep superblock pinned during cgroup writeback association switches
2016-02-16 11:34:07 -07:00
inode.c
writeback: initialize inode members that track writeback history
2016-02-16 14:57:21 -07:00
internal.h
Merge branch 'for-linus' into work.misc
2016-01-08 21:20:11 -05:00
ioctl.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
Kconfig
dax: re-enable dax pmd mappings
2016-01-15 17:56:32 -08:00
Kconfig.binfmt
…
libfs.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
locks.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
Makefile
…
mbcache.c
…
mount.h
…
mpage.c
mm, fs: introduce mapping_gfp_constraint()
2015-11-06 17:50:42 -08:00
namei.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
namespace.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
no-block.c
…
nsfs.c
…
open.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
pipe.c
pipe: limit the per-user amount of pages allocated in pipes
2016-01-19 19:25:21 -05:00
pnode.c
…
pnode.h
…
posix_acl.c
xattr handlers: Simplify list operation
2015-12-13 19:46:12 -05:00
proc_namespace.c
vfs: show_vfsstat: remove redundant initialization and check of error code
2015-12-06 21:17:16 -05:00
read_write.c
vfs: abort dedupe loop if fatal signals are pending
2016-01-22 20:29:55 -05:00
readdir.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
select.c
poll: plug an unused argument to do_poll
2016-01-06 08:26:52 -05:00
seq_file.c
fs, seqfile: always allow oom killer
2015-11-06 17:50:42 -08:00
signalfd.c
…
splice.c
fs: __generic_file_splice_read retry lookup on AOP_TRUNCATED_PAGE
2016-01-09 02:55:35 -05:00
stack.c
…
stat.c
fs/stat.c: drop the last new_valid_dev check
2016-01-16 11:17:23 -08:00
statfs.c
…
super.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2016-01-14 17:04:19 -08:00
sync.c
fs/sync.c: make sync_file_range(2) use WB_SYNC_NONE writeback
2015-11-06 17:50:42 -08:00
timerfd.c
timerfd: Handle relative timers with CONFIG_TIME_LOW_RES proper
2016-01-17 11:13:55 +01:00
userfaultfd.c
…
utimes.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00
xattr.c
wrappers for ->i_mutex access
2016-01-22 18:04:28 -05:00