Josef Bacik
0c7086ee62
btrfs: fixup error handling in fixup_inode_link_counts ...
commit 011b28acf940eb61c000059dd9e2cfcbf52ed96b upstream.
This function has the following pattern
while (1) {
ret = whatever();
if (ret)
goto out;
}
ret = 0
out:
return ret;
However several places in this while loop we simply break; when there's
a problem, thus clearing the return value, and in one case we do a
return -EIO, and leak the memory for the path.
Fix this by re-arranging the loop to deal with ret == 1 coming from
btrfs_search_slot, and then simply delete the
ret = 0;
out:
bit so everybody can break if there is an error, which will allow for
proper error handling to occur.
CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-06-10 12:43:51 +02:00
2020-11-05 11:07:03 +01:00
2019-08-06 19:05:21 +02:00
2021-03-03 18:22:54 +01:00
2020-04-02 16:34:33 +02:00
2019-12-17 20:37:24 +01:00
2018-12-01 09:42:51 +01:00
2021-06-10 12:43:51 +02:00
2020-11-05 11:07:05 +01:00
2021-05-22 10:57:42 +02:00
2021-06-03 08:36:22 +02:00
2019-08-06 19:05:23 +02:00
2021-03-17 16:34:34 +01:00
2018-11-13 11:15:12 -08:00
2020-11-05 11:06:52 +01:00
2019-05-08 07:20:49 +02:00
2019-03-23 14:35:21 +01:00
2021-05-22 10:57:35 +02:00
2021-05-26 11:47:00 +02:00
2020-12-02 08:34:44 +01:00
2019-12-05 15:37:28 +01:00
2020-01-27 14:46:06 +01:00
2020-08-21 09:48:18 +02:00
2021-06-10 12:43:51 +02:00
2021-05-22 10:57:38 +02:00
2020-06-20 10:25:05 +02:00
2018-12-17 09:28:53 +01:00
2021-05-22 10:57:36 +02:00
2021-04-16 11:57:53 +02:00
2019-12-01 09:13:57 +01:00
2020-04-24 08:00:45 +02:00
2021-06-03 08:36:25 +02:00
2021-03-03 18:22:46 +01:00
2020-09-03 11:22:29 +02:00
2021-05-22 10:57:22 +02:00
2021-03-07 11:27:42 +01:00
2019-12-17 20:38:50 +01:00
2020-12-29 13:46:57 +01:00
2020-08-21 09:48:15 +02:00
2021-06-03 08:36:18 +02:00
2020-12-29 13:47:01 +01:00
2021-01-23 15:48:45 +01:00
2020-06-20 10:25:01 +02:00
2020-01-12 12:11:59 +01:00
2021-03-03 18:22:36 +01:00
2021-06-10 12:43:51 +02:00
2020-02-28 16:36:08 +01:00
2021-02-23 14:00:31 +01:00
2021-06-03 08:36:12 +02:00
2020-01-09 10:17:55 +01:00
2021-03-03 18:22:44 +01:00
2020-10-29 09:07:11 +01:00
2021-04-07 12:47:02 +02:00
2020-08-26 10:29:54 +02:00
2021-05-22 10:57:39 +02:00
2021-03-07 11:27:45 +01:00
2018-12-17 09:28:48 +01:00
2021-01-17 13:58:59 +01:00
2021-03-17 16:34:30 +01:00
2020-08-21 09:48:22 +02:00
2021-03-07 11:27:43 +01:00
2018-12-21 14:13:04 +01:00
2020-06-03 08:18:03 +02:00
2019-07-03 13:15:59 +02:00
2021-03-17 16:34:35 +01:00
2019-11-06 12:42:59 +01:00
2021-05-22 10:57:43 +02:00
2020-11-05 11:06:58 +01:00
2020-01-14 20:05:39 +01:00
2020-01-09 10:17:58 +01:00
2020-05-20 08:16:58 +02:00
2020-03-11 18:02:43 +01:00
2019-02-06 17:31:34 +01:00
2021-04-16 11:57:48 +02:00
2020-01-12 12:11:59 +01:00
2020-10-14 09:51:09 +02:00
2020-11-18 18:28:03 +01:00
2020-05-27 16:42:51 +02:00
2020-04-24 08:00:43 +02:00
2021-02-23 14:00:30 +01:00
2020-04-02 16:34:21 +02:00
2018-11-10 07:48:33 -08:00
2019-12-17 20:38:57 +01:00
2020-11-24 13:05:50 +01:00
2020-01-09 10:17:55 +01:00
2020-03-11 18:02:53 +01:00
2020-05-02 17:24:20 +02:00
2020-03-20 10:54:16 +01:00
2019-05-04 09:15:18 +02:00
2020-05-02 17:24:47 +02:00
2019-12-01 09:13:51 +01:00
2021-04-28 12:08:41 +02:00
2021-03-24 11:05:05 +01:00
2019-05-04 09:15:18 +02:00
2019-10-11 18:18:48 +02:00
2020-11-24 13:05:44 +01:00
2020-01-04 13:59:58 +01:00
2020-08-21 09:48:00 +02:00
0c7086ee62