Eric Biggers 28e7c9a8e5 KEYS: reject NULL restriction string when type is specified ...

commit 18026d866801d0c52e5550210563222bd6c7191d upstream.

keyctl_restrict_keyring() allows through a NULL restriction when the
"type" is non-NULL, which causes a NULL pointer dereference in
asymmetric_lookup_restriction() when it calls strcmp() on the
restriction string.

But no key types actually use a "NULL restriction" to mean anything, so
update keyctl_restrict_keyring() to reject it with EINVAL.

Reported-by: syzbot <syzkaller@googlegroups.com>
Fixes: 97d3aa0f3134 ("KEYS: Add a lookup_restriction function for the asymmetric key type")
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2017-12-14 09:52:53 +01:00

..

encrypted-keys

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

big_key.c

KEYS: Fix race between updating and finding a negative key

2017-10-18 09:12:40 +01:00

compat_dh.c

KEYS: DH: validate __spare field

2017-07-14 11:01:38 +10:00

compat.c

KEYS: add SP800-56A KDF support for DH

2017-04-04 22:33:38 +01:00

dh.c

KEYS: DH: validate __spare field

2017-07-14 11:01:38 +10:00

gc.c

KEYS: Fix race between updating and finding a negative key

2017-10-18 09:12:40 +01:00

internal.h

KEYS: prevent creating a different user's keyrings

2017-09-25 15:19:57 +01:00

Kconfig

security/keys: BIG_KEY requires CONFIG_CRYPTO

2017-10-18 09:12:40 +01:00

key.c

KEYS: don't let add_key() update an uninstantiated key

2017-10-18 09:12:40 +01:00

keyctl.c

KEYS: reject NULL restriction string when type is specified

2017-12-14 09:52:53 +01:00

keyring.c

KEYS: return full count in keyring_read() if buffer is too small

2017-11-02 20:58:05 +11:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

permission.c

KEYS: load key flags and expiry time atomically in key_validate()

2017-10-18 09:12:41 +01:00

persistent.c

sched/headers: Prepare to remove <linux/cred.h> inclusion from <linux/sched.h>

2017-03-02 08:42:31 +01:00

proc.c

KEYS: load key flags and expiry time atomically in proc_keys_show()

2017-10-18 09:12:41 +01:00

process_keys.c

KEYS: Fix race between updating and finding a negative key

2017-10-18 09:12:40 +01:00

request_key_auth.c

KEYS: Fix race between updating and finding a negative key

2017-10-18 09:12:40 +01:00

request_key.c

KEYS: add missing permission check for request_key() destination

2017-12-14 09:52:52 +01:00

sysctl.c

security: Convert use of typedef ctl_table to struct ctl_table

2014-04-15 13:39:58 +10:00

trusted.c

KEYS: trusted: fix writing past end of buffer in trusted_read()

2017-11-02 20:58:07 +11:00

trusted.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

user_defined.c

KEYS: Fix race between updating and finding a negative key

2017-10-18 09:12:40 +01:00