Filipe Manana
292cbd51ec
Btrfs: fix invalid block group rbtree access after bg is removed ...
If we grab a block group, for example in btrfs_trim_fs(), we will be holding
a reference on it but the block group can be removed after we got it (via
btrfs_remove_block_group), which means it will no longer be part of the
rbtree.
However, btrfs_remove_block_group() was only calling rb_erase() which leaves
the block group's rb_node left and right child pointers with the same content
they had before calling rb_erase. This was dangerous because a call to
next_block_group() would access the node's left and right child pointers (via
rb_next), which can be no longer valid.
Fix this by clearing a block group's node after removing it from the tree,
and have next_block_group() do a tree search to get the next block group
instead of using rb_next() if our block group was removed.
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Josef Bacik <jbacik@fb.com>
Signed-off-by: Chris Mason <clm@fb.com>
2014-12-02 18:19:17 -08:00
2014-10-09 02:39:04 -04:00
2014-08-08 15:57:24 -07:00
2014-10-14 02:18:22 +02:00
2014-10-13 16:23:15 +02:00
2014-10-14 02:18:16 +02:00
2014-10-14 02:18:20 +02:00
2014-08-08 15:57:24 -07:00
2014-12-02 18:19:17 -08:00
2014-10-14 08:40:15 +02:00
2014-11-13 22:19:05 +03:00
2014-10-17 17:17:12 -05:00
2014-08-08 15:57:20 -07:00
2014-08-08 15:57:25 -07:00
2014-07-09 16:58:21 -07:00
2014-10-14 15:11:48 -05:00
2014-10-24 00:14:39 +02:00
2014-08-08 15:57:18 -07:00
2014-10-19 20:22:32 +03:00
2014-09-08 09:51:29 +09:00
2014-10-22 09:02:48 +02:00
2014-10-30 10:53:17 -04:00
2014-10-07 11:54:41 -07:00
2014-10-14 02:18:20 +02:00
2014-10-13 17:52:21 +01:00
2014-10-09 02:38:57 -04:00
2014-10-13 11:28:42 +02:00
2014-10-14 02:18:20 +02:00
2014-06-12 10:30:18 -07:00
2014-08-07 14:40:09 -04:00
2014-08-08 15:57:22 -07:00
2014-10-31 06:33:17 -04:00
2014-10-22 10:02:04 +02:00
2014-10-30 10:53:17 -04:00
2014-10-09 02:39:01 -04:00
2014-10-13 16:23:15 +02:00
2014-10-09 02:38:56 -04:00
2014-10-11 13:21:34 -04:00
2014-08-06 18:01:12 -07:00
2014-08-08 15:57:20 -07:00
2014-10-14 02:18:16 +02:00
2014-11-12 17:19:04 -05:00
2014-09-17 16:33:11 -04:00
2014-10-23 13:39:51 -04:00
2014-10-14 02:18:20 +02:00
2014-11-13 16:17:06 -08:00
2014-10-16 12:53:35 +01:00
2014-11-05 15:21:18 -05:00
2014-10-14 02:18:22 +02:00
2014-11-05 08:49:38 -05:00
2014-10-14 02:18:28 +02:00
2014-10-15 13:51:33 -07:00
2014-08-08 15:57:26 -07:00
2014-10-22 09:08:03 +02:00
2014-08-08 15:57:18 -07:00
2014-10-14 02:18:20 +02:00
2014-08-08 15:57:25 -07:00
2014-08-06 18:01:13 -07:00
2014-09-30 09:29:44 +03:00
2014-10-09 13:06:14 +02:00
2014-10-14 02:18:20 +02:00
2014-11-07 08:33:52 +11:00
2014-09-24 13:31:50 -04:00
2014-06-10 13:57:22 -07:00
2014-08-07 14:40:09 -04:00
2014-10-09 02:39:00 -04:00
2014-10-09 02:39:00 -04:00
2014-10-09 02:39:00 -04:00
2014-10-14 02:18:16 +02:00
2014-10-31 06:33:26 -04:00
2014-10-21 13:55:11 -06:00
2014-07-11 13:53:04 +03:00
2014-10-09 02:39:16 -04:00
2014-10-14 02:18:21 +02:00
2014-10-23 22:30:18 -04:00
2014-09-26 21:16:51 -04:00
2014-09-10 15:42:12 -07:00
2014-10-09 02:39:00 -04:00
2014-09-09 16:01:36 -04:00
2014-10-13 11:28:42 +02:00
2014-10-13 15:44:12 +02:00
2014-08-07 14:40:09 -04:00
2014-07-16 15:10:39 +02:00
2014-08-08 15:57:31 -07:00
2014-10-24 00:14:35 +02:00
2014-10-24 00:14:38 +02:00
2014-10-07 14:06:12 -04:00
2014-10-07 14:06:13 -04:00
2014-10-24 00:14:38 +02:00
2014-06-25 22:08:29 -04:00
2014-10-09 02:38:55 -04:00
2014-10-09 22:25:53 -04:00
2014-11-02 10:28:43 -08:00
2014-10-24 00:14:36 +02:00
2014-10-24 00:14:35 +02:00
2014-08-30 18:31:41 -04:00
2014-07-29 18:08:50 -07:00
2014-10-09 02:39:05 -04:00
2014-07-03 09:21:54 -07:00
2014-10-24 00:14:35 +02:00
2014-08-26 09:35:56 +02:00
2014-10-13 11:28:42 +02:00
2014-09-05 08:16:21 -07:00
2014-08-27 11:17:48 +02:00
2014-10-12 17:09:10 -04:00
292cbd51ec