Christian Borntraeger
4265f161b6
virtio: fix race in enable_cb ...
There is a race in virtio_net, dealing with disabling/enabling the callback.
I saw the following oops:
kernel BUG at /space/kvm/drivers/virtio/virtio_ring.c:218!
illegal operation: 0001 [#1 ] SMP
Modules linked in: sunrpc dm_mod
CPU: 2 Not tainted 2.6.25-rc1zlive-host-10623-gd358142-dirty #99
Process swapper (pid: 0, task: 000000000f85a610, ksp: 000000000f873c60)
Krnl PSW : 0404300180000000 00000000002b81a6 (vring_disable_cb+0x16/0x20)
R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:0 CC:3 PM:0 EA:3
Krnl GPRS: 0000000000000001 0000000000000001 0000000010005800 0000000000000001
000000000f3a0900 000000000f85a610 0000000000000000 0000000000000000
0000000000000000 000000000f870000 0000000000000000 0000000000001237
000000000f3a0920 000000000010ff74 00000000002846f6 000000000fa0bcd8
Krnl Code: 00000000002b819a: a7110001 tmll %r1,1
00000000002b819e: a7840004 brc 8,2b81a6
00000000002b81a2: a7f40001 brc 15,2b81a4
>00000000002b81a6: a51b0001 oill %r1,1
00000000002b81aa: 40102000 sth %r1,0(%r2)
00000000002b81ae: 07fe bcr 15,%r14
00000000002b81b0: eb7ff0380024 stmg %r7,%r15,56(%r15)
00000000002b81b6: a7f13e00 tmll %r15,15872
Call Trace:
([<000000000fa0bcd0>] 0xfa0bcd0)
[<00000000002b8350>] vring_interrupt+0x5c/0x6c
[<000000000010ab08>] do_extint+0xb8/0xf0
[<0000000000110716>] ext_no_vtime+0x16/0x1a
[<0000000000107e72>] cpu_idle+0x1c2/0x1e0
The problem can be triggered with a high amount of host->guest traffic.
I think its the following race:
poll says netif_rx_complete
poll calls enable_cb
enable_cb opens the interrupt mask
a new packet comes, an interrupt is triggered----\
enable_cb sees that there is more work |
enable_cb disables the interrupt |
. V
. interrupt is delivered
. skb_recv_done does atomic napi test, ok
some waiting disable_cb is called->check fails->bang!
.
poll would do napi check
poll would do disable_cb
The fix is to let enable_cb not disable the interrupt again, but expect the
caller to do the cleanup if it returns false. In that case, the interrupt is
only disabled, if the napi test_set_bit was successful.
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> (cleaned up doco)
2008-03-17 22:58:21 +11:00
2008-02-08 09:22:32 -08:00
2008-01-28 14:54:13 -08:00
2008-02-06 10:41:15 -08:00
2008-02-01 16:42:02 -05:00
2008-02-07 08:42:23 -08:00
2008-02-08 13:30:02 -08:00
2007-12-12 20:01:01 +01:00
2008-02-07 10:30:48 +00:00
2008-03-10 16:41:06 -07:00
2008-01-31 19:27:40 -08:00
2007-10-15 12:26:29 -07:00
2008-01-31 19:27:36 -08:00
2008-01-31 19:27:39 -08:00
2008-02-14 21:17:08 -08:00
2008-03-04 16:35:18 -08:00
2008-02-05 09:44:13 -08:00
2008-02-20 20:11:49 -05:00
2008-02-10 18:11:16 -05:00
2007-12-26 19:36:35 -08:00
2008-02-05 03:20:13 -08:00
2008-03-10 16:42:26 -07:00
2008-02-08 09:22:30 -08:00
2008-02-06 10:41:02 -08:00
2008-02-06 10:41:10 -08:00
2008-01-30 13:30:18 +01:00
2008-02-14 02:43:39 -05:00
2008-02-05 14:33:32 +10:00
2008-02-05 14:33:32 +10:00
2008-02-19 10:04:00 +01:00
2007-12-17 19:28:16 -08:00
2007-10-10 16:51:59 -07:00
2008-02-06 10:12:18 -07:00
2008-02-06 06:54:17 -05:00
2008-02-24 00:27:33 -05:00
2008-01-28 15:00:14 -08:00
2008-01-28 15:00:12 -08:00
2008-02-08 09:22:38 -08:00
2008-02-04 13:16:39 +00:00
2007-10-17 08:42:47 -07:00
2008-01-23 11:29:17 -06:00
2008-02-14 21:17:08 -08:00
2007-10-17 08:43:00 -07:00
2007-10-17 08:42:45 -07:00
2007-10-11 22:24:13 +01:00
2007-10-17 08:43:07 -07:00
2008-02-19 10:04:00 +01:00
2007-10-18 14:37:29 -07:00
2007-10-19 11:53:42 -07:00
2007-10-19 11:53:42 -07:00
2008-03-04 11:18:17 +01:00
2008-01-29 21:55:15 +01:00
2008-02-07 08:42:25 -08:00
2008-02-13 16:21:18 -08:00
2008-01-28 14:54:10 -08:00
2008-02-05 09:44:20 -08:00
2008-02-01 23:09:24 +01:00
2008-03-04 16:35:12 -08:00
2008-02-23 17:13:24 -08:00
2007-10-19 11:53:36 -07:00
2008-02-03 17:45:46 +02:00
2007-10-14 22:57:45 +02:00
2008-01-30 13:30:02 +01:00
2008-02-06 10:41:03 -08:00
2008-01-28 23:21:18 +01:00
2008-02-09 23:24:09 +01:00
2007-10-18 14:37:32 -07:00
2007-10-17 08:42:47 -07:00
2008-03-04 16:35:12 -08:00
2007-12-06 17:40:19 -05:00
2008-02-14 20:58:05 -08:00
2008-02-26 18:42:44 -08:00
2007-10-16 09:43:20 -07:00
2007-10-18 14:37:19 -07:00
2007-10-17 08:42:52 -07:00
2008-01-30 13:32:42 +01:00
2008-01-25 21:08:02 +01:00
2008-02-06 22:57:58 -05:00
2008-02-14 00:09:55 -05:00
2008-01-30 13:31:10 +01:00
2008-02-11 20:48:29 -08:00
2007-10-17 08:42:53 -07:00
2008-01-11 08:17:01 +11:00
2008-02-03 17:45:46 +02:00
2008-02-03 15:42:53 +02:00
2008-02-08 15:33:33 -08:00
2008-02-14 21:17:09 -08:00
2008-02-03 04:28:53 -08:00
2008-02-14 21:17:08 -08:00
2008-01-25 21:08:02 +01:00
2008-03-04 14:47:06 -08:00
2008-03-04 16:35:12 -08:00
2007-10-19 11:53:36 -07:00
2008-02-08 02:10:01 +00:00
2008-02-05 09:44:10 -08:00
2008-01-25 14:46:04 -08:00
2008-01-25 14:46:04 -08:00
2008-02-11 11:06:35 -05:00
2008-02-08 02:09:56 +00:00
2008-02-05 09:44:11 -08:00
2008-03-04 10:16:46 -07:00
2008-02-08 09:22:24 -08:00
2008-02-08 09:22:37 -08:00
2008-02-07 08:42:06 -08:00
2007-10-23 15:49:47 +10:00
2007-10-10 16:53:56 -07:00
2007-10-22 08:13:19 -07:00
2007-12-18 08:29:28 +01:00
2008-02-08 09:22:30 -08:00
2008-02-07 09:02:26 -08:00
2008-02-29 08:06:37 -08:00
2008-02-07 08:42:30 -08:00
2008-01-28 23:21:18 +01:00
2008-02-07 18:04:10 -06:00
2008-02-07 08:42:25 -08:00
2008-02-13 16:21:19 -08:00
2008-03-07 11:11:13 -08:00
2007-10-29 07:41:32 -07:00
2008-03-14 09:49:57 -07:00
2007-10-17 08:43:02 -07:00
2007-11-29 09:24:53 -08:00
2007-10-17 08:42:48 -07:00
2008-02-07 08:42:27 -08:00
2008-02-25 16:54:37 -05:00
2008-01-29 00:19:52 -05:00
2008-01-29 00:19:52 -05:00
2008-02-10 01:11:44 -05:00
2007-10-17 18:49:58 -04:00
2007-11-08 08:42:46 -05:00
2007-10-16 09:43:22 -07:00
2007-10-17 08:43:01 -07:00
2008-02-13 16:21:18 -08:00
2007-10-17 21:21:26 -07:00
2007-10-17 00:00:08 +02:00
2008-03-10 16:33:33 -07:00
2007-10-18 14:37:19 -07:00
2007-10-10 16:54:03 -07:00
2008-02-14 21:13:33 -08:00
2008-02-19 10:04:00 +01:00
2008-02-06 10:41:05 -08:00
2007-11-29 09:24:54 -08:00
2008-02-23 17:12:15 -08:00
2008-03-12 12:34:37 -07:00
2008-02-13 16:21:18 -08:00
2007-10-10 08:55:27 +01:00
2008-03-04 16:35:10 -08:00
2008-02-29 18:46:50 +01:00
2008-02-06 10:41:00 -08:00
2008-02-07 08:42:34 -08:00
2008-02-05 13:31:39 -05:00
2007-10-14 12:41:51 -07:00
2008-02-03 15:42:53 +02:00
2008-02-19 01:41:26 +01:00
2008-02-11 13:01:51 +01:00
2007-10-15 08:12:00 -07:00
2008-02-05 09:44:19 -08:00
2008-01-30 13:30:27 +01:00
2008-02-10 10:48:03 +01:00
2008-02-13 16:21:18 -08:00
2008-02-05 09:44:23 -08:00
2007-10-09 22:56:30 -04:00
2007-10-13 23:56:32 +02:00
2008-02-07 20:39:44 -05:00
2008-02-24 20:03:42 +01:00
2007-10-16 11:21:00 +02:00
2007-10-22 00:56:52 -04:00
2008-02-11 09:20:50 -08:00
2008-02-01 16:13:16 -05:00
2008-01-28 14:53:58 -08:00
2007-10-10 16:51:59 -07:00
2008-01-28 14:54:09 -08:00
2007-12-07 15:00:32 -05:00
2007-10-15 12:26:29 -07:00
2007-10-10 16:51:16 -07:00
2008-02-23 20:09:11 -08:00
2007-10-17 08:42:52 -07:00
2008-01-28 15:07:58 -08:00
2007-10-10 16:49:13 -07:00
2007-10-10 16:52:04 -07:00
2008-01-28 14:56:28 -08:00
2008-01-28 15:07:57 -08:00
2008-01-28 14:55:09 -08:00
2008-02-05 16:20:22 -08:00
2008-01-28 14:55:09 -08:00
2008-01-28 15:08:44 -08:00
2007-12-05 05:37:32 -08:00
2008-01-31 19:28:31 -08:00
2008-01-30 13:34:11 +01:00
2008-02-05 09:44:20 -08:00
2008-02-19 21:00:18 +01:00
2007-10-21 02:37:38 -04:00
2008-02-07 12:57:44 -08:00
2008-02-13 16:21:18 -08:00
2008-02-19 10:04:00 +01:00
2008-03-04 16:35:17 -08:00
2008-01-30 13:30:32 +01:00
2008-01-28 10:50:29 +01:00
2008-02-08 09:22:26 -08:00
2008-02-08 09:22:23 -08:00
2007-10-30 08:06:55 -07:00
2007-10-18 14:37:32 -07:00
2008-01-31 19:28:20 -08:00
2008-02-13 16:21:18 -08:00
2008-02-06 10:41:07 -08:00
2008-02-07 08:42:33 -08:00
2008-02-07 08:42:34 -08:00
2007-10-09 22:07:28 -03:00
2007-10-09 22:07:23 -03:00
2008-01-28 23:58:27 -05:00
2008-02-06 10:41:21 -08:00
2008-02-08 09:22:29 -08:00
2007-11-05 15:12:32 -08:00
2007-10-17 08:42:52 -07:00
2008-03-12 12:34:37 -07:00
2007-11-29 09:24:52 -08:00
2007-10-18 14:37:28 -07:00
2008-02-08 09:22:41 -08:00
2008-02-07 08:42:25 -08:00
2007-10-17 08:42:57 -07:00
2008-01-08 16:10:35 -08:00
2007-10-19 11:53:33 -07:00
2008-01-24 21:27:06 -08:00
2008-03-04 16:35:11 -08:00
2008-01-24 20:40:05 -08:00
2008-02-14 22:08:30 +01:00
2008-03-04 15:19:40 +02:00
2008-01-30 18:01:22 +02:00
2008-01-30 18:01:18 +02:00
2008-03-03 11:22:25 +02:00
2008-01-25 21:08:34 +01:00
2008-02-07 09:49:38 +00:00
2008-02-04 23:49:57 +11:00
2007-10-25 15:02:50 +10:00
2008-02-24 00:27:33 -05:00
2008-02-13 16:21:18 -08:00
2007-10-19 11:53:35 -07:00
2008-02-03 17:45:46 +02:00
2007-10-19 11:53:38 -07:00
2008-02-06 10:41:03 -08:00
2008-02-06 10:41:01 -08:00
2008-02-06 10:41:01 -08:00
2007-10-19 11:53:36 -07:00
2008-02-26 14:03:47 +09:00
2008-03-04 16:35:14 -08:00
2007-11-14 18:45:41 -08:00
2007-10-10 16:54:03 -07:00
2008-03-04 16:35:15 -08:00
2007-10-16 09:43:02 -07:00
2007-10-22 08:13:17 -07:00
2007-10-19 11:53:36 -07:00
2008-03-10 18:01:18 -07:00
2008-02-05 09:44:23 -08:00
2008-03-04 16:35:12 -08:00
2008-03-12 12:34:37 -07:00
2008-02-05 09:44:18 -08:00
2008-02-05 09:44:08 -08:00
2008-02-14 20:58:04 -08:00
2008-02-13 16:21:19 -08:00
2007-11-07 04:08:55 -08:00
2007-10-19 11:53:44 -07:00
2008-02-13 16:21:18 -08:00
2008-02-08 09:22:31 -08:00
2007-10-30 14:32:16 -04:00
2008-01-26 15:04:01 +00:00
2008-01-26 15:03:59 +00:00
2008-02-14 21:13:33 -08:00
2008-02-08 09:22:41 -08:00
2008-01-28 14:56:29 -08:00
2008-02-15 07:33:07 -08:00
2007-12-14 13:54:39 -08:00
2008-01-28 14:53:55 -08:00
2008-01-28 14:53:55 -08:00
2008-02-27 12:21:18 -08:00
2008-01-31 19:28:23 -08:00
2008-03-04 12:28:49 -08:00
2008-01-30 02:06:07 -05:00
2008-03-07 14:35:37 -05:00
2007-12-06 17:40:25 -05:00
2008-01-30 02:05:24 -05:00
2008-01-30 02:06:08 -05:00
2008-02-01 16:42:05 -05:00
2008-01-28 14:59:52 -08:00
2007-10-17 08:42:58 -07:00
2007-10-16 09:42:58 -07:00
2008-02-01 18:30:53 -05:00
2007-10-19 11:53:37 -07:00
2008-02-05 09:44:24 -08:00
2008-01-17 14:53:22 +11:00
2007-10-17 21:17:42 -07:00
2008-02-06 16:29:59 +11:00
2007-10-17 08:42:46 -07:00
2008-02-21 16:40:15 -08:00
2007-10-16 09:43:02 -07:00
2007-10-16 09:43:02 -07:00
2008-02-13 16:21:18 -08:00
2007-10-23 19:53:16 -04:00
2008-02-14 21:13:33 -08:00
2008-01-24 20:40:14 -08:00
2008-03-10 18:01:19 -07:00
2008-02-02 11:32:01 -08:00
2008-02-01 15:04:29 -08:00
2008-03-13 10:21:09 -07:00
2008-01-28 15:00:35 -08:00
2008-02-02 02:44:34 +03:00
2007-10-17 08:42:44 -07:00
2008-02-06 10:41:04 -08:00
2008-02-07 23:11:56 -08:00
2007-10-19 11:53:41 -07:00
2008-01-23 19:33:58 -06:00
2008-02-03 04:28:41 -08:00
2008-02-08 09:22:23 -08:00
2008-02-13 16:21:18 -08:00
2008-02-05 16:21:04 -08:00
2008-01-31 19:28:35 -08:00
2008-01-24 20:40:06 -08:00
2008-01-24 20:40:43 -08:00
2008-01-11 12:26:47 -05:00
2008-02-05 09:44:22 -08:00
2008-02-23 10:40:04 -08:00
2008-03-13 10:09:27 +11:00
2008-02-06 10:41:20 -08:00
2007-10-17 18:49:58 -04:00
2008-02-05 21:15:50 -05:00
2008-02-05 09:44:20 -08:00
2008-02-08 09:22:31 -08:00
2007-10-19 20:35:04 +02:00
2007-10-19 11:53:41 -07:00
2008-03-07 11:08:40 -08:00
2007-10-17 08:42:55 -07:00
2007-10-17 08:42:45 -07:00
2008-02-08 09:22:26 -08:00
2008-02-07 08:42:28 -08:00
2007-12-23 12:54:36 -08:00
2007-10-17 08:42:56 -07:00
2008-02-03 16:12:47 +02:00
2008-02-29 18:46:50 +01:00
2008-02-06 10:41:06 -08:00
2008-01-25 21:08:24 +01:00
2008-02-29 18:46:50 +01:00
2008-02-05 09:44:22 -08:00
2008-01-30 13:31:47 +01:00
2008-02-03 15:42:53 +02:00
2008-02-08 09:22:41 -08:00
2008-02-07 08:42:18 -08:00
2008-01-31 19:26:46 -08:00
2008-02-07 08:42:19 -08:00
2007-11-29 09:24:54 -08:00
2008-02-05 03:17:22 -08:00
2008-02-13 16:21:18 -08:00
2008-01-28 10:54:49 +01:00
2008-03-07 16:42:59 +01:00
2007-11-29 09:24:54 -08:00
2008-02-05 10:59:07 -05:00
2007-10-14 12:41:51 -07:00
2008-03-06 08:40:53 +11:00
2007-10-16 09:43:17 -07:00
2008-01-30 08:17:26 +11:00
2007-10-19 11:53:44 -07:00
2008-02-14 21:17:08 -08:00
2008-02-07 08:42:34 -08:00
2008-02-05 09:44:09 -08:00
2008-02-13 16:21:18 -08:00
2008-02-26 14:52:45 +09:00
2008-02-07 08:42:30 -08:00
2008-02-08 09:22:41 -08:00
2008-02-08 09:22:27 -08:00
2008-02-03 15:12:15 +02:00
2008-02-18 20:52:13 -08:00
2008-03-06 16:21:49 -08:00
2008-01-02 13:04:48 -08:00
2008-03-03 12:22:32 -08:00
2008-03-04 16:35:13 -08:00
2008-03-04 16:35:13 -08:00
2008-01-25 21:08:33 +01:00
2008-01-30 13:33:17 +01:00
2008-01-31 19:28:30 -08:00
2008-01-28 14:56:57 -08:00
2008-01-24 00:47:27 -05:00
2008-02-03 17:45:46 +02:00
2008-01-30 13:31:20 +01:00
2008-01-30 13:31:20 +01:00
2008-02-08 09:22:31 -08:00
2008-01-28 14:53:30 -08:00
2008-01-25 21:08:34 +01:00
2008-02-07 08:42:34 -08:00
2007-10-30 21:44:00 -07:00
2008-02-01 18:30:53 -05:00
2008-02-05 09:44:17 -08:00
2008-02-13 16:21:18 -08:00
2008-02-09 11:08:33 -08:00
2008-02-05 09:44:07 -08:00
2008-02-05 09:44:20 -08:00
2008-01-24 20:40:40 -08:00
2008-01-23 11:29:18 -06:00
2007-10-18 14:37:28 -07:00
2008-01-28 14:54:07 -08:00
2008-02-09 04:01:48 -05:00
2008-02-01 17:45:14 +01:00
2008-02-01 17:45:14 +01:00
2008-03-10 18:01:18 -07:00
2008-03-09 08:42:57 +01:00
2008-02-08 09:22:37 -08:00
2008-03-09 08:42:57 +01:00
2008-01-25 21:08:20 +01:00
2008-02-07 08:42:16 -08:00
2008-02-08 09:22:39 -08:00
2008-02-08 09:22:34 -08:00
2008-02-08 09:22:36 -08:00
2007-10-19 11:53:42 -07:00
2008-01-24 20:40:26 -08:00
2008-02-01 14:34:49 -08:00
2008-03-04 14:57:43 -08:00
2008-02-01 14:34:58 -08:00
2008-02-08 09:22:23 -08:00
2007-12-26 19:36:35 -08:00
2007-10-12 14:51:04 -07:00
2008-02-18 12:18:05 -03:00
2008-02-18 12:18:05 -03:00
2007-10-23 13:47:31 -05:00
2008-02-04 23:50:13 +11:00
2008-02-04 23:50:01 +11:00
2008-02-04 23:50:03 +11:00
2007-10-23 15:49:55 +10:00
2008-02-04 23:50:02 +11:00
2008-02-04 23:50:12 +11:00
2008-02-04 23:50:00 +11:00
2008-03-17 22:58:21 +11:00
2008-02-05 09:44:14 -08:00
2008-02-29 08:36:13 -08:00
2008-02-06 10:41:03 -08:00
2007-10-19 11:53:34 -07:00
2008-02-06 10:41:15 -08:00
2008-02-13 16:21:18 -08:00
2008-02-03 15:42:53 +02:00
2008-02-13 16:21:18 -08:00
2008-02-05 09:44:19 -08:00
2008-02-05 09:44:20 -08:00
2008-01-31 19:27:03 -08:00
2007-10-12 14:05:17 +10:00
2007-10-10 16:53:57 -07:00
4265f161b6