Tony Battersby
4d2de3a50c
[SCSI] fix BUG when sum(scatterlist) > bufflen ...
When sending a SCSI command to a tape drive via the SCSI Generic (sg)
driver, if the command has a data transfer length more than
scatter_elem_sz (32 KB default) and not a multiple of 512, then I either
hit BUG_ON(!valid_dma_direction(direction)) in dma_unmap_sg() or else
the command never completes (depending on the LLDD).
When constructing scatterlists, the sg driver rounds up the scatterlist
element sizes to be a multiple of 512. This can result in
sum(scatterlist lengths) > bufflen. In this case, scsi_req_map_sg()
incorrectly sets bio->bi_size to sum(scatterlist lengths) rather than to
bufflen. When the command completes, req_bio_endio() detects that
bio->bi_size != 0, and so it doesn't call bio_endio(). This causes the
command to be resubmitted, resulting in BUG_ON or the command never
completing.
This patch makes scsi_req_map_sg() set bio->bi_size to bufflen rather
than to sum(scatterlist lengths), which fixes the problem.
Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Acked-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
2008-02-07 18:02:44 -06:00
2008-02-07 18:02:33 -06:00
2008-02-04 07:58:52 -08:00
2008-01-25 11:47:23 -06:00
2008-02-07 18:02:44 -06:00
2008-02-07 18:02:34 -06:00
2007-04-01 10:10:04 -05:00
2008-02-06 10:41:01 -08:00
2008-01-25 17:19:08 -08:00
2008-02-04 07:58:52 -08:00
2008-02-06 11:15:41 -08:00
2008-02-05 09:44:08 -08:00
2008-02-07 18:02:40 -06:00
2008-02-07 18:02:35 -06:00
2008-02-07 18:02:34 -06:00
2008-01-11 18:22:30 -06:00
2008-01-30 13:14:02 -06:00
2007-07-21 08:57:40 -05:00
2008-01-30 13:14:02 -06:00
2007-01-06 09:18:00 -06:00
2008-01-23 11:29:27 -06:00
2007-06-17 16:15:56 -05:00
2008-01-30 13:14:02 -06:00
2007-06-17 16:09:29 -05:00
2008-02-06 10:41:01 -08:00
2008-02-06 10:41:01 -08:00
2007-10-12 14:41:00 -04:00
2008-02-07 18:02:43 -06:00
2008-01-11 18:22:34 -06:00
2007-08-04 09:11:06 -05:00
2008-02-03 16:36:24 +02:00
2008-01-30 13:14:02 -06:00
2008-02-06 10:41:01 -08:00
2008-01-11 18:28:57 -06:00
2007-11-25 12:19:26 +02:00
2007-05-04 17:59:05 -07:00
2008-01-11 18:22:38 -06:00
2008-01-30 13:14:02 -06:00
2007-02-07 18:32:29 -05:00
2007-10-12 14:41:00 -04:00
2008-01-25 09:22:12 -06:00
2008-01-11 18:22:40 -06:00
2008-02-07 18:02:43 -06:00
2008-01-30 13:14:02 -06:00
2007-12-10 19:43:54 -08:00
2007-11-25 12:19:26 +02:00
2007-03-20 11:27:03 -05:00
2008-01-23 11:29:26 -06:00
2008-01-30 13:14:02 -06:00
2007-12-10 19:43:55 -08:00
2007-07-31 10:51:25 -05:00
2008-01-11 18:22:35 -06:00
2007-10-22 21:19:53 +02:00
2007-10-19 11:53:42 -07:00
2007-11-25 12:19:26 +02:00
2007-10-12 14:56:09 -04:00
2007-10-12 14:55:46 -04:00
2008-01-11 18:28:14 -06:00
2007-10-12 14:56:13 -04:00
2008-02-06 10:41:01 -08:00
2008-01-30 13:14:02 -06:00
2008-01-30 13:14:02 -06:00
2008-01-11 18:28:06 -06:00
2008-01-30 13:14:02 -06:00
2008-02-06 02:57:51 +01:00
2008-01-11 18:22:41 -06:00
2008-01-11 18:22:36 -06:00
2008-01-30 13:14:02 -06:00
2007-05-22 11:08:56 -05:00
2008-02-03 17:28:22 +02:00
2007-05-08 11:54:40 -05:00
2008-02-03 17:28:22 +02:00
2008-01-11 18:27:59 -06:00
2008-02-07 18:02:37 -06:00
2008-01-11 18:28:48 -06:00
2007-05-31 17:30:04 -04:00
2008-02-07 18:02:42 -06:00
2007-07-19 10:04:50 -07:00
2008-02-07 18:02:37 -06:00
2008-01-30 13:03:40 -06:00
2008-01-30 13:14:02 -06:00
2007-11-25 12:19:26 +02:00
2008-02-07 18:02:42 -06:00
2008-01-30 13:14:02 -06:00
2007-05-08 11:15:08 -05:00
2008-01-30 13:14:02 -06:00
2007-10-12 14:41:00 -04:00
2007-02-14 08:09:54 -08:00
2008-01-30 13:03:39 -06:00
2007-10-12 14:51:18 -04:00
2008-01-30 13:14:02 -06:00
2008-01-23 13:44:31 -06:00
2007-10-12 14:55:07 -04:00
2007-10-12 14:41:00 -04:00
2007-07-19 10:04:50 -07:00
2008-01-30 13:14:02 -06:00
2007-10-19 11:53:42 -07:00
2007-10-27 14:31:06 -05:00
2007-10-12 14:50:55 -04:00
2007-11-25 12:19:26 +02:00
2008-01-11 18:22:41 -06:00
2008-02-07 18:02:33 -06:00
2008-01-30 13:14:02 -06:00
2007-10-23 12:35:35 -04:00
2007-10-22 21:19:53 +02:00
2008-01-30 13:14:02 -06:00
2008-01-23 11:29:27 -06:00
2007-10-12 14:52:38 -04:00
2008-01-30 13:14:25 -06:00
2008-01-11 18:22:44 -06:00
2008-01-30 13:03:41 -06:00
2008-01-11 18:22:50 -06:00
2007-07-14 19:28:10 -05:00
2008-02-07 18:02:44 -06:00
2008-01-28 15:08:07 -08:00
2008-01-23 11:37:44 -06:00
2008-01-11 18:22:40 -06:00
2008-01-23 11:29:17 -06:00
2007-07-18 11:16:32 -05:00
2008-01-23 11:29:17 -06:00
2008-01-11 18:22:30 -06:00
2008-02-03 17:28:22 +02:00
2007-10-12 14:37:50 -04:00
2007-10-12 14:46:58 -04:00
2008-01-11 18:22:40 -06:00
2008-02-07 18:02:38 -06:00
2008-02-03 17:28:22 +02:00
2008-01-23 11:29:18 -06:00
2007-10-12 14:38:09 -04:00
2008-01-11 18:22:45 -06:00
2008-02-07 18:02:42 -06:00
2008-01-11 18:22:40 -06:00
2008-02-07 18:02:41 -06:00
2008-01-28 10:04:46 +01:00
2008-01-30 13:03:39 -06:00
2007-07-22 11:36:49 -07:00
2007-07-14 19:12:15 -05:00
2008-01-11 18:29:17 -06:00
2006-12-13 09:05:58 -08:00
2008-01-30 13:03:40 -06:00
2008-01-11 18:29:17 -06:00
2008-01-23 11:29:29 -06:00
2007-07-31 10:44:01 -05:00
2008-01-30 13:14:02 -06:00
2008-01-11 18:28:57 -06:00
2007-11-25 12:19:26 +02:00
2007-11-25 12:19:26 +02:00
2006-12-09 09:41:18 -08:00
2008-02-07 18:02:33 -06:00
2007-05-31 17:30:04 -04:00
2008-01-30 13:14:02 -06:00
2007-11-25 12:19:26 +02:00
2006-11-15 16:43:50 -06:00
2008-01-23 11:29:27 -06:00
2007-07-14 18:56:33 -05:00
2008-01-30 13:14:02 -06:00
2008-01-30 13:14:02 -06:00
2008-01-11 18:22:35 -06:00
2007-10-19 23:22:55 +02:00
2008-01-30 13:14:02 -06:00
2007-11-29 09:24:52 -08:00
4d2de3a50c