Xiyu Yang 4f7ade4152 btrfs: fix block group leak when removing fails
commit f6033c5e333238f299c3ae03fac8cc1365b23b77 upstream.

btrfs_remove_block_group() invokes btrfs_lookup_block_group(), which
returns a local reference of the block group that contains the given
bytenr to "block_group" with increased refcount.

When btrfs_remove_block_group() returns, "block_group" becomes invalid,
so the refcount should be decreased to keep refcount balanced.

The reference counting issue happens in several exception handling paths
of btrfs_remove_block_group(). When those error scenarios occur such as
btrfs_alloc_path() returns NULL, the function forgets to decrease its
refcnt increased by btrfs_lookup_block_group() and will cause a refcnt
leak.

Fix this issue by jumping to "out_put_group" label and calling
btrfs_put_block_group() when those error scenarios occur.

CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-05-05 19:15:48 +02:00
..
2020-04-02 16:34:33 +02:00
2019-08-06 19:05:23 +02:00
2019-12-17 20:38:33 +01:00
2020-02-28 16:36:05 +01:00
2019-12-17 20:38:44 +01:00
2019-12-17 20:38:15 +01:00
2018-12-21 14:13:04 +01:00
2020-03-11 18:02:43 +01:00
2020-04-24 08:00:38 +02:00
2020-04-02 16:34:21 +02:00