Eric Dumazet
6bd4f355df
ipv6: kill sk_dst_lock ...
While testing the np->opt RCU conversion, I found that UDP/IPv6 was
using a mixture of xchg() and sk_dst_lock to protect concurrent changes
to sk->sk_dst_cache, leading to possible corruptions and crashes.
ip6_sk_dst_lookup_flow() uses sk_dst_check() anyway, so the simplest
way to fix the mess is to remove sk_dst_lock completely, as we did for
IPv4.
__ip6_dst_store() and ip6_dst_store() share same implementation.
sk_setup_caps() being called with socket lock being held or not,
we have to use sk_dst_set() instead of __sk_dst_set()
Note that I had to move the "np->dst_cookie = rt6_get_cookie(rt);"
in ip6_dst_store() before the sk_setup_caps(sk, dst) call.
This is because ip6_dst_store() can be called from process context,
without any lock held.
As soon as the dst is installed in sk->sk_dst_cache, dst can be freed
from another cpu doing a concurrent ip6_dst_store()
Doing the dst dereference before doing the install is needed to make
sure no use after free would trigger.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2015-12-03 11:32:06 -05:00
2015-04-11 22:28:27 -04:00
2015-11-05 04:04:00 +01:00
2015-02-20 17:35:14 -05:00
2014-12-10 15:33:16 -05:00
2015-09-21 16:03:04 -07:00
2015-11-10 23:47:32 +01:00
2015-10-14 06:01:07 -07:00
2015-10-28 06:44:45 +01:00
2015-12-02 23:39:46 -05:00
2015-09-18 21:59:31 +02:00
2015-10-21 00:49:25 +02:00
2015-08-26 11:01:44 -07:00
2015-09-24 12:26:08 -07:00
2015-09-17 13:20:05 +02:00
2015-11-23 12:29:58 -05:00
2015-11-01 12:14:47 -05:00
2014-09-18 10:54:36 +02:00
2015-03-04 00:23:23 -05:00
2015-06-28 16:55:44 -07:00
2015-11-02 22:52:24 -05:00
2014-11-10 13:27:49 -05:00
2015-07-27 01:05:24 -07:00
2015-08-30 18:08:50 -04:00
2014-01-13 17:39:11 +01:00
2015-11-03 10:54:58 +01:00
2015-09-30 13:16:44 +02:00
2015-08-17 21:33:06 -07:00
2015-02-11 14:46:37 -05:00
2015-07-20 12:41:30 -07:00
2015-05-13 14:31:43 -04:00
2015-04-09 00:02:26 -04:00
2014-02-09 17:32:50 -08:00
2013-12-06 12:37:56 -05:00
2015-03-06 21:50:02 -05:00
2013-12-10 21:50:00 -05:00
2013-09-20 14:49:32 -04:00
2015-09-17 17:18:37 -07:00
2013-09-20 14:49:32 -04:00
2014-02-09 17:32:49 -08:00
2014-02-09 17:32:49 -08:00
2015-11-01 15:56:11 -05:00
2015-11-04 21:59:22 -05:00
2015-10-08 04:27:02 -07:00
2015-10-08 04:27:03 -07:00
2013-11-07 19:28:58 -05:00
2015-09-23 15:33:15 -07:00
2015-09-09 14:19:50 -07:00
2015-09-01 16:46:08 -07:00
2015-10-07 04:27:42 -07:00
2014-02-12 07:02:11 +01:00
2014-11-12 15:01:35 -05:00
2013-09-20 14:49:33 -04:00
2014-09-30 01:02:26 -04:00
2015-09-24 12:25:23 -07:00
2015-08-27 15:42:48 -07:00
2015-08-10 14:03:54 -07:00
2015-08-31 15:17:17 -07:00
2014-11-05 16:30:03 -05:00
2013-09-20 14:49:33 -04:00
2014-02-06 09:34:58 +01:00
2015-09-30 13:16:44 +02:00
2015-03-23 22:12:09 -04:00
2015-10-03 04:32:42 -07:00
2015-03-18 22:00:35 -04:00
2015-11-02 22:46:09 -05:00
2015-10-23 05:42:21 -07:00
2014-05-07 15:30:52 -04:00
2015-11-02 22:47:14 -05:00
2015-10-23 05:42:21 -07:00
2015-11-08 20:56:38 -05:00
2015-10-20 06:08:27 -07:00
2015-08-28 13:32:36 -07:00
2014-08-24 18:09:23 -07:00
2015-11-15 17:12:37 -05:00
2015-12-03 11:32:06 -05:00
2015-11-16 14:14:32 -05:00
2015-11-03 13:41:45 -05:00
2015-11-16 14:14:32 -05:00
2015-09-24 09:34:43 +09:00
2015-10-12 19:44:16 -07:00
2015-12-02 23:37:16 -05:00
2014-11-24 04:28:49 -05:00
2015-02-28 21:31:12 +01:00
2015-10-13 04:55:04 -07:00
2013-09-21 14:01:38 -04:00
2014-10-14 02:18:27 +02:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2014-12-10 15:21:24 -05:00
2015-05-11 10:50:17 -04:00
2013-09-21 14:01:38 -04:00
2014-01-01 22:22:43 -05:00
2013-09-21 14:01:38 -04:00
2013-09-21 14:01:38 -04:00
2014-12-10 15:21:24 -05:00
2013-09-21 14:01:38 -04:00
2014-01-03 20:56:48 -05:00
2015-10-08 04:27:03 -07:00
2015-11-03 11:15:48 +01:00
2015-10-21 00:49:24 +02:00
2013-12-06 12:37:56 -05:00
2014-09-22 16:23:15 -04:00
2015-10-23 06:26:42 -07:00
2014-11-05 23:52:33 -08:00
2013-10-01 17:06:14 -04:00
2015-12-01 15:07:59 -05:00
2015-08-10 13:46:21 -07:00
2015-08-07 11:50:56 +02:00
2013-09-21 14:01:39 -04:00
2014-08-07 20:55:21 -04:00
2015-09-30 13:16:44 +02:00
2014-02-08 10:36:58 -05:00
2013-09-21 14:01:39 -04:00
2015-09-30 13:16:44 +02:00
2013-09-21 14:01:39 -04:00
2015-03-02 13:06:31 -05:00
2014-10-06 18:02:32 -04:00
2015-08-27 14:18:48 -07:00
2014-05-23 16:28:53 -04:00
2013-09-23 01:51:08 -04:00
2013-09-23 01:51:08 -04:00
2013-09-23 01:51:08 -04:00
2014-01-21 23:17:20 -08:00
2014-12-17 11:49:55 +01:00
2015-10-16 00:52:19 -07:00
2013-09-23 01:51:08 -04:00
2015-10-07 04:27:44 -07:00
2015-10-21 19:15:20 -07:00
2015-09-17 21:09:07 -07:00
2013-09-23 01:51:09 -04:00
2014-06-02 11:00:41 -07:00
2014-10-15 07:48:18 +02:00
2015-12-03 11:32:06 -05:00
2013-12-19 18:51:20 -05:00
2013-09-23 01:51:09 -04:00
2015-11-16 15:24:37 -05:00
2013-10-21 18:43:02 -04:00
2015-03-12 22:58:12 -04:00
2015-10-23 05:42:21 -07:00
2015-07-09 15:12:20 -07:00
2014-01-19 19:53:18 -08:00
2015-10-26 22:24:22 -07:00
2015-08-29 13:07:54 -07:00
2015-03-02 13:06:31 -05:00
2015-02-04 01:34:15 -05:00
2015-09-26 22:40:55 -07:00
2013-09-23 16:29:40 -04:00
2014-09-05 17:35:28 -07:00
2013-09-23 16:29:41 -04:00
2015-10-08 04:27:03 -07:00
6bd4f355df