Denis V. Lunev
59b7435149
proc: introduce proc_create_data to setup de->data ...
This set of patches fixes an proc ->open'less usage due to ->proc_fops flip in
the most part of the kernel code. The original OOPS is described in the
commit 2d3a4e3666325a9709cc8ea2e88151394e8f20fc:
Typical PDE creation code looks like:
pde = create_proc_entry("foo", 0, NULL);
if (pde)
pde->proc_fops = &foo_proc_fops;
Notice that PDE is first created, only then ->proc_fops is set up to
final value. This is a problem because right after creation
a) PDE is fully visible in /proc , and
b) ->proc_fops are proc_file_operations which do not have ->open callback. So, it's
possible to ->read without ->open (see one class of oopses below).
The fix is new API called proc_create() which makes sure ->proc_fops are
set up before gluing PDE to main tree. Typical new code looks like:
pde = proc_create("foo", 0, NULL, &foo_proc_fops);
if (!pde)
return -ENOMEM;
Fix most networking users for a start.
In the long run, create_proc_entry() for regular files will go.
In addition to this, proc_create_data is introduced to fix reading from
proc without PDE->data. The race is basically the same as above.
create_proc_entries is replaced in the entire kernel code as new method
is also simply better.
This patch:
The problem is the same as for de->proc_fops. Right now PDE becomes visible
without data set. So, the entry could be looked up without data. This, in
most cases, will simply OOPS.
proc_create_data call is created to address this issue. proc_create now
becomes a wrapper around it.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Chris Mason <chris.mason@oracle.com>
Acked-by: David Howells <dhowells@redhat.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Grant Grundler <grundler@parisc-linux.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Jaroslav Kysela <perex@suse.cz>
Cc: Jeff Garzik <jgarzik@pobox.com>
Cc: Jeff Mahoney <jeffm@suse.com>
Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Karsten Keil <kkeil@suse.de>
Cc: Kyle McMartin <kyle@parisc-linux.org>
Cc: Len Brown <lenb@kernel.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Matthew Wilcox <matthew@wil.cx>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Mikael Starvik <starvik@axis.com>
Cc: Nadia Derbey <Nadia.Derbey@bull.net>
Cc: Neil Brown <neilb@suse.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Osterlund <petero2@telia.com>
Cc: Pierre Peiffer <peifferp@gmail.com>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 08:06:20 -07:00
2008-02-08 09:22:32 -08:00
2008-01-28 14:54:13 -08:00
2008-04-24 14:07:46 -03:00
2008-04-14 09:57:06 -07:00
2008-04-25 13:00:11 -04:00
2008-04-19 11:29:08 +01:00
2008-04-25 14:52:32 -07:00
2008-04-22 20:10:10 +01:00
2008-04-14 11:15:49 +02:00
2008-04-14 11:15:44 +02:00
2008-04-14 11:15:54 +02:00
2008-01-31 19:27:36 -08:00
2008-01-31 19:27:39 -08:00
2008-04-25 13:00:11 -04:00
2008-04-28 08:58:42 -07:00
2008-04-02 00:43:01 -04:00
2008-04-17 23:56:30 -07:00
2008-04-24 11:46:16 -07:00
2008-02-05 03:20:13 -08:00
2008-04-24 21:16:52 -07:00
2008-02-08 09:22:30 -08:00
2008-02-06 10:41:02 -08:00
2008-02-06 10:41:10 -08:00
2008-01-30 13:30:18 +01:00
2008-02-14 02:43:39 -05:00
2008-04-20 21:47:02 -07:00
2008-02-05 14:33:32 +10:00
2008-02-05 14:33:32 +10:00
2008-04-29 08:06:00 -07:00
2008-03-28 22:14:15 -04:00
2008-02-06 10:12:18 -07:00
2008-03-27 14:51:39 -04:00
2008-02-24 00:27:33 -05:00
2008-03-23 22:04:31 -07:00
2008-01-28 15:00:14 -08:00
2008-01-28 15:00:12 -08:00
2008-02-08 09:22:38 -08:00
2008-02-04 13:16:39 +00:00
2008-03-04 13:41:23 +01:00
2008-04-19 19:10:33 -07:00
2008-04-19 09:59:43 +10:00
2008-04-29 08:06:00 -07:00
2008-04-29 08:06:04 -07:00
2008-04-21 09:50:08 +02:00
2008-04-28 08:58:19 -07:00
2008-04-29 08:05:59 -07:00
2008-04-21 09:51:05 +02:00
2008-01-29 21:55:15 +01:00
2008-04-28 08:58:25 -07:00
2008-04-22 15:16:32 -05:00
2008-04-29 08:06:01 -07:00
2008-04-28 08:58:19 -07:00
2008-01-28 14:54:10 -08:00
2008-04-28 08:58:26 -07:00
2008-04-21 09:50:08 +02:00
2008-04-29 08:06:09 -07:00
2008-04-29 08:06:10 -07:00
2008-02-03 17:45:46 +02:00
2008-04-17 20:05:38 +02:00
2008-04-29 08:05:59 -07:00
2008-03-30 14:20:23 -07:00
2008-01-28 23:21:18 +01:00
2008-02-09 23:24:09 +01:00
2008-04-26 17:44:55 +02:00
2008-03-04 16:35:12 -08:00
2008-02-14 20:58:05 -08:00
2008-02-26 18:42:44 -08:00
2008-04-29 08:06:06 -07:00
2008-01-30 13:32:42 +01:00
2008-04-29 08:05:59 -07:00
2008-02-06 22:57:58 -05:00
2008-03-26 00:45:26 -04:00
2008-04-28 08:58:19 -07:00
2008-04-28 08:58:19 -07:00
2008-04-21 10:19:23 +08:00
2008-02-03 17:45:46 +02:00
2008-02-03 15:42:53 +02:00
2008-02-08 15:33:33 -08:00
2008-04-23 00:04:38 -04:00
2008-02-03 04:28:53 -08:00
2008-02-14 21:17:08 -08:00
2008-03-04 14:47:06 -08:00
2008-03-04 16:35:12 -08:00
2008-04-29 08:06:09 -07:00
2008-04-25 13:27:00 +01:00
2008-04-21 15:49:58 -07:00
2008-04-21 11:35:39 -05:00
2008-04-21 11:22:28 -05:00
2008-04-21 11:35:39 -05:00
2008-04-21 11:22:29 -05:00
2008-02-11 11:06:35 -05:00
2008-04-25 13:26:55 +01:00
2008-04-25 13:26:55 +01:00
2008-02-08 02:09:56 +00:00
2008-04-25 13:26:55 +01:00
2008-04-29 08:06:11 -07:00
2008-04-29 08:06:11 -07:00
2008-04-21 22:38:45 +00:00
2008-02-08 09:22:24 -08:00
2008-04-28 08:58:30 -07:00
2008-02-07 08:42:06 -08:00
2008-04-19 19:19:54 +02:00
2008-02-08 09:22:30 -08:00
2008-04-29 08:06:16 -07:00
2008-02-29 08:06:37 -08:00
2008-02-07 08:42:30 -08:00
2008-01-28 23:21:18 +01:00
2008-04-19 19:10:33 -07:00
2008-02-07 08:42:25 -08:00
2008-02-13 16:21:19 -08:00
2008-03-07 11:11:13 -08:00
2008-04-23 16:13:42 -04:00
2008-02-07 08:42:27 -08:00
2008-02-25 16:54:37 -05:00
2008-01-29 00:19:52 -05:00
2008-01-29 00:19:52 -05:00
2008-02-10 01:11:44 -05:00
2008-04-28 08:58:35 -07:00
2008-04-25 09:23:59 -04:00
2008-04-10 02:02:28 -07:00
2008-03-10 16:33:33 -07:00
2008-02-14 21:13:33 -08:00
2008-04-29 08:06:00 -07:00
2008-04-16 20:09:35 -04:00
2008-02-06 10:41:05 -08:00
2008-02-23 17:12:15 -08:00
2008-03-12 12:34:37 -07:00
2008-04-29 08:05:58 -07:00
2008-03-04 16:35:10 -08:00
2008-03-28 14:45:21 -07:00
2008-02-06 10:41:00 -08:00
2008-02-07 08:42:34 -08:00
2008-02-05 13:31:39 -05:00
2008-04-18 00:46:24 +02:00
2008-04-28 10:03:31 -07:00
2008-04-22 11:34:59 +02:00
2008-02-05 09:44:19 -08:00
2008-04-18 22:22:54 -04:00
2008-04-04 18:36:49 +02:00
2008-04-17 12:22:31 +02:00
2008-04-28 08:58:25 -07:00
2008-04-19 19:10:28 -07:00
2008-04-22 22:16:46 +02:00
2008-04-24 14:09:42 -03:00
2008-04-22 22:16:46 +02:00
2008-02-24 20:03:42 +01:00
2008-04-28 08:58:34 -07:00
2008-03-05 20:58:10 -08:00
2008-04-28 23:44:42 +02:00
2008-04-23 21:25:36 -04:00
2008-01-28 14:53:58 -08:00
2008-03-03 12:20:57 -08:00
2008-02-23 20:09:11 -08:00
2008-01-28 15:07:58 -08:00
2008-04-18 22:16:54 -04:00
2008-01-28 14:56:28 -08:00
2008-04-12 18:48:58 -07:00
2008-04-03 10:06:00 +09:00
2008-04-16 00:48:04 -07:00
2008-01-28 14:55:09 -08:00
2008-03-23 22:05:44 -07:00
2008-04-12 13:43:19 +09:00
2008-03-17 22:48:46 -07:00
2008-03-26 04:39:53 +09:00
2008-01-30 13:34:11 +01:00
2008-04-28 08:58:26 -07:00
2008-04-29 08:06:03 -07:00
2008-04-02 00:41:00 -04:00
2008-04-29 08:06:02 -07:00
2008-04-15 09:25:33 +02:00
2008-03-04 16:35:17 -08:00
2008-04-20 21:47:08 -07:00
2008-01-28 10:50:29 +01:00
2008-04-29 08:06:13 -07:00
2008-02-08 09:22:23 -08:00
2008-04-29 08:06:15 -07:00
2008-04-29 08:06:15 -07:00
2008-04-14 02:30:23 -07:00
2008-04-17 07:47:05 +02:00
2008-04-19 19:19:54 +02:00
2008-04-19 19:10:28 -07:00
2008-04-15 00:30:16 -07:00
2008-02-07 08:42:33 -08:00
2008-02-07 08:42:34 -08:00
2008-04-18 22:16:54 -04:00
2008-04-18 22:16:54 -04:00
2008-04-21 16:36:46 -07:00
2008-04-29 08:06:04 -07:00
2008-04-29 08:06:14 -07:00
2008-04-18 22:16:54 -04:00
2008-02-07 08:42:25 -08:00
2008-04-29 08:06:17 -07:00
2008-04-15 01:30:32 -04:00
2008-04-29 08:06:16 -07:00
2008-04-17 20:05:42 +02:00
2008-04-28 08:58:32 -07:00
2008-04-19 19:44:57 +02:00
2008-04-27 18:21:46 +03:00
2008-04-27 12:00:27 +03:00
2008-04-27 12:01:15 +03:00
2008-04-27 18:21:37 +03:00
2008-04-24 23:49:30 +01:00
2008-03-28 11:05:54 +11:00
2008-04-25 00:46:09 -04:00
2008-04-11 08:29:13 -07:00
2008-04-29 08:06:04 -07:00
2008-02-03 17:45:46 +02:00
2008-03-31 10:41:44 +01:00
2008-04-15 21:22:17 +10:00
2008-02-06 10:41:03 -08:00
2008-02-06 10:41:01 -08:00
2008-02-06 10:41:01 -08:00
2008-02-26 14:03:47 +09:00
2008-03-04 16:35:14 -08:00
2008-04-15 19:35:41 -07:00
2008-03-27 14:51:39 -04:00
2008-04-29 08:06:01 -07:00
2008-04-29 08:06:10 -07:00
2008-04-28 08:58:25 -07:00
2008-04-29 08:06:12 -07:00
2008-04-28 08:58:25 -07:00
2008-04-19 19:10:29 -07:00
2008-04-24 14:07:43 -03:00
2008-04-19 19:10:28 -07:00
2008-04-29 08:06:17 -07:00
2008-04-29 08:06:17 -07:00
2008-04-28 08:58:25 -07:00
2008-04-23 00:05:03 -04:00
2008-02-05 09:44:08 -08:00
2008-02-14 20:58:04 -08:00
2008-02-13 16:21:19 -08:00
2008-04-23 00:04:51 -04:00
2008-04-13 23:21:16 -07:00
2008-04-04 10:44:42 +09:00
2008-04-28 08:58:47 -07:00
2008-04-29 08:06:12 -07:00
2008-04-07 12:15:39 -05:00
2008-02-13 16:21:18 -08:00
2008-02-08 09:22:31 -08:00
2008-01-26 15:04:01 +00:00
2008-02-14 21:13:33 -08:00
2008-02-08 09:22:41 -08:00
2008-04-28 08:58:29 -07:00
2008-03-22 17:18:47 -07:00
2008-04-16 02:02:18 -07:00
2008-04-14 11:15:52 +02:00
2008-01-28 14:53:55 -08:00
2008-04-14 11:15:49 +02:00
2008-01-31 19:28:23 -08:00
2008-03-04 12:28:49 -08:00
2008-04-23 16:13:37 -04:00
2008-04-19 16:54:56 -04:00
2008-04-19 16:55:29 -04:00
2008-01-30 02:05:24 -05:00
2008-04-19 16:53:15 -04:00
2008-02-01 16:42:05 -05:00
2008-03-06 15:30:41 -05:00
2008-04-28 08:58:19 -07:00
2008-04-29 08:06:13 -07:00
2008-02-05 09:44:24 -08:00
2008-04-17 07:46:11 +10:00
2008-04-17 07:46:11 +10:00
2008-04-07 13:49:23 +10:00
2008-04-28 08:58:18 -07:00
2008-04-28 08:58:22 -07:00
2008-02-13 16:21:18 -08:00
2008-04-18 22:22:54 -04:00
2008-02-14 21:13:33 -08:00
2008-03-10 18:01:19 -07:00
2008-04-20 21:47:03 -07:00
2008-02-01 15:04:29 -08:00
2008-04-20 21:47:03 -07:00
2008-04-20 21:47:07 -07:00
2008-02-02 02:44:34 +03:00
2008-04-29 08:06:04 -07:00
2008-04-29 08:06:02 -07:00
2008-02-07 23:11:56 -08:00
2008-04-29 08:06:02 -07:00
2008-04-25 02:08:52 -04:00
2008-02-08 09:22:23 -08:00
2008-02-13 16:21:18 -08:00
2008-04-04 10:44:42 +09:00
2008-03-17 22:46:46 -07:00
2008-01-31 19:28:35 -08:00
2008-02-05 09:44:22 -08:00
2008-04-19 19:10:26 -07:00
2008-04-19 19:10:26 -07:00
2008-03-13 10:09:27 +11:00
2008-04-11 08:06:44 -07:00
2008-02-05 21:15:50 -05:00
2008-04-28 08:58:26 -07:00
2008-02-08 09:22:31 -08:00
2008-04-29 08:06:20 -07:00
2008-02-08 09:22:26 -08:00
2008-02-07 08:42:28 -08:00
2008-04-28 08:58:33 -07:00
2008-04-28 08:58:33 -07:00
2008-02-03 16:12:47 +02:00
2008-04-19 19:10:33 -07:00
2008-02-29 18:46:50 +01:00
2008-02-06 10:41:06 -08:00
2008-03-19 18:53:36 -07:00
2008-02-05 09:44:22 -08:00
2008-01-30 13:31:47 +01:00
2008-02-03 15:42:53 +02:00
2008-04-28 08:58:46 -07:00
2008-04-29 08:06:10 -07:00
2008-04-29 08:05:59 -07:00
2008-01-31 19:26:46 -08:00
2008-02-07 08:42:19 -08:00
2008-04-23 22:10:48 -07:00
2008-02-13 16:21:18 -08:00
2008-04-07 12:15:45 -05:00
2008-04-29 08:06:10 -07:00
2008-02-05 10:59:07 -05:00
2008-04-28 08:58:26 -07:00
2008-04-29 08:06:16 -07:00
2008-04-19 09:53:46 +10:00
2008-04-17 10:43:01 -04:00
2008-04-02 00:10:28 -07:00
2008-04-23 00:04:38 -04:00
2008-04-25 00:25:08 +02:00
2008-02-07 08:42:34 -08:00
2008-04-28 08:58:32 -07:00
2008-04-17 20:05:37 +02:00
2008-02-26 14:52:45 +09:00
2008-04-15 13:26:52 -04:00
2008-02-07 08:42:30 -08:00
2008-04-28 08:58:25 -07:00
2008-02-08 09:22:27 -08:00
2008-02-03 15:12:15 +02:00
2008-04-21 15:51:36 -07:00
2008-03-06 16:21:49 -08:00
2008-04-27 18:28:18 +03:00
2008-03-04 16:35:13 -08:00
2008-03-04 16:35:13 -08:00
2008-04-29 08:06:05 -07:00
2008-03-17 07:49:27 -04:00
2008-01-30 13:33:17 +01:00
2008-01-31 19:28:30 -08:00
2008-01-28 14:56:57 -08:00
2008-02-03 17:45:46 +02:00
2008-01-30 13:31:20 +01:00
2008-01-30 13:31:20 +01:00
2008-04-17 12:22:31 +02:00
2008-01-28 14:53:30 -08:00
2008-02-07 08:42:34 -08:00
2008-02-01 18:30:53 -05:00
2008-04-28 08:58:36 -07:00
2008-04-28 08:58:20 -07:00
2008-02-09 11:08:33 -08:00
2008-04-28 08:58:29 -07:00
2008-04-29 08:06:06 -07:00
2008-02-05 09:44:20 -08:00
2008-04-19 19:44:59 +02:00
2008-04-22 15:16:31 -05:00
2008-03-21 16:33:01 -07:00
2008-04-15 19:35:41 -07:00
2008-04-17 12:22:30 +02:00
2008-02-01 17:45:14 +01:00
2008-03-10 18:01:18 -07:00
2008-03-09 08:42:57 +01:00
2008-02-08 09:22:37 -08:00
2008-03-09 08:42:57 +01:00
2008-04-19 19:44:59 +02:00
2008-04-19 19:10:33 -07:00
2008-04-17 20:05:37 +02:00
2008-02-07 08:42:16 -08:00
2008-02-08 09:22:39 -08:00
2008-04-17 20:05:36 +02:00
2008-04-17 14:22:23 +02:00
2008-03-23 22:06:51 -07:00
2008-04-24 21:16:42 -07:00
2008-04-24 21:16:57 -07:00
2008-04-24 21:16:54 -07:00
2008-02-08 09:22:23 -08:00
2008-04-24 14:07:56 -03:00
2008-02-18 12:18:05 -03:00
2008-02-04 23:50:13 +11:00
2008-02-04 23:50:01 +11:00
2008-02-04 23:50:03 +11:00
2008-02-04 23:50:02 +11:00
2008-02-04 23:50:12 +11:00
2008-02-04 23:50:00 +11:00
2008-04-07 13:14:22 -07:00
2008-04-28 08:58:21 -07:00
2008-04-28 08:58:23 -07:00
2008-02-06 10:41:03 -08:00
2008-02-06 10:41:15 -08:00
2008-02-13 16:21:18 -08:00
2008-03-06 15:30:40 -05:00
2008-04-17 09:24:58 -04:00
2008-02-13 16:21:18 -08:00
2008-02-05 09:44:19 -08:00
2008-04-29 08:06:06 -07:00
2008-04-25 00:29:34 -07:00
59b7435149