Nick Black
192f211d6f
scsi: iscsi: Don't destroy session if there are outstanding connections
[ Upstream commit 54155ed4199c7aa3fd20866648024ab63c96d579 ]
A faulty userspace that calls destroy_session() before destroying the
connections can trigger the failure. This patch prevents the issue by
refusing to destroy the session if there are outstanding connections.
------------[ cut here ]------------
kernel BUG at mm/slub.c:306!
invalid opcode: 0000 [#1] SMP PTI
CPU: 1 PID: 1224 Comm: iscsid Not tainted 5.4.0-rc2.iscsi+ #7
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
RIP: 0010:__slab_free+0x181/0x350
[...]
[ 1209.686056] RSP: 0018:ffffa93d4074fae0 EFLAGS: 00010246
[ 1209.686694] RAX: ffff934efa5ad800 RBX: 000000008010000a RCX: ffff934efa5ad800
[ 1209.687651] RDX: ffff934efa5ad800 RSI: ffffeb4041e96b00 RDI: ffff934efd402c40
[ 1209.688582] RBP: ffffa93d4074fb80 R08: 0000000000000001 R09: ffffffffbb5dfa26
[ 1209.689425] R10: ffff934efa5ad800 R11: 0000000000000001 R12: ffffeb4041e96b00
[ 1209.690285] R13: ffff934efa5ad800 R14: ffff934efd402c40 R15: 0000000000000000
[ 1209.691213] FS: 00007f7945dfb540(0000) GS:ffff934efda80000(0000) knlGS:0000000000000000
[ 1209.692316] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 1209.693013] CR2: 000055877fd3da80 CR3: 0000000077384000 CR4: 00000000000006e0
[ 1209.693897] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 1209.694773] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 1209.695631] Call Trace:
[ 1209.695957] ? __wake_up_common_lock+0x8a/0xc0
[ 1209.696712] iscsi_pool_free+0x26/0x40
[ 1209.697263] iscsi_session_teardown+0x2f/0xf0
[ 1209.698117] iscsi_sw_tcp_session_destroy+0x45/0x60
[ 1209.698831] iscsi_if_rx+0xd88/0x14e0
[ 1209.699370] netlink_unicast+0x16f/0x200
[ 1209.699932] netlink_sendmsg+0x21a/0x3e0
[ 1209.700446] sock_sendmsg+0x4f/0x60
[ 1209.700902] ___sys_sendmsg+0x2ae/0x320
[ 1209.701451] ? cp_new_stat+0x150/0x180
[ 1209.701922] __sys_sendmsg+0x59/0xa0
[ 1209.702357] do_syscall_64+0x52/0x160
[ 1209.702812] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[ 1209.703419] RIP: 0033:0x7f7946433914
[...]
[ 1209.706084] RSP: 002b:00007fffb99f2378 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
[ 1209.706994] RAX: ffffffffffffffda RBX: 000055bc869eac20 RCX: 00007f7946433914
[ 1209.708082] RDX: 0000000000000000 RSI: 00007fffb99f2390 RDI: 0000000000000005
[ 1209.709120] RBP: 00007fffb99f2390 R08: 000055bc84fe9320 R09: 00007fffb99f1f07
[ 1209.710110] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000038
[ 1209.711085] R13: 000055bc8502306e R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
---[ end trace a2d933ede7f730d8 ]---
Link: https://lore.kernel.org/r/20191226203148.2172200-1-krisman@collabora.com
Signed-off-by: Nick Black <nlb@google.com>
Co-developed-by: Salman Qazi <sqazi@google.com>
Signed-off-by: Salman Qazi <sqazi@google.com>
Co-developed-by: Junho Ryu <jayr@google.com>
Signed-off-by: Junho Ryu <jayr@google.com>
Co-developed-by: Khazhismel Kumykov <khazhy@google.com>
Signed-off-by: Khazhismel Kumykov <khazhy@google.com>
Co-developed-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Reviewed-by: Lee Duncan <lduncan@suse.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-02-28 16:36:04 +01:00
..
2019-03-23 14:35:20 +01:00
2020-02-28 16:36:01 +01:00
2019-02-12 19:46:13 +01:00
2017-08-10 19:40:50 -04:00
2018-04-26 11:02:10 +02:00
2017-08-07 14:04:01 -04:00
2020-01-14 20:05:46 +01:00
2019-06-19 08:20:57 +02:00
2020-01-23 08:20:36 +01:00
2020-02-14 16:32:16 -05:00
2020-01-17 19:45:53 +01:00
2019-02-12 19:46:12 +01:00
2019-11-10 11:25:09 +01:00
2017-06-20 12:18:27 +02:00
2020-01-23 08:20:36 +01:00
2019-08-09 17:53:31 +02:00
2020-02-05 14:18:23 +00:00
2019-04-05 22:31:26 +02:00
2019-08-16 10:13:54 +02:00
2018-10-20 09:48:50 +02:00
2019-12-01 09:13:29 +01:00
2020-01-27 14:46:40 +01:00
2020-01-09 10:17:51 +01:00
2020-01-09 10:17:51 +01:00
2020-02-14 16:32:23 -05:00
2020-01-04 13:59:34 +01:00
2018-05-25 16:17:50 +02:00
2018-01-02 20:31:05 +01:00
2017-11-02 11:10:55 +01:00
2020-01-04 13:59:47 +01:00
2020-01-09 10:17:58 +01:00
2019-06-19 08:20:56 +02:00
2020-02-28 16:35:54 +01:00
2020-02-14 16:32:16 -05:00
2019-06-25 11:36:53 +08:00
2017-11-02 11:10:55 +01:00
2019-11-20 17:59:54 +01:00
2020-02-28 16:36:01 +01:00
2018-09-19 22:43:42 +02:00
2018-09-19 22:43:42 +02:00
2018-09-19 22:43:42 +02:00
2019-03-13 14:03:15 -07:00
2017-11-02 11:10:55 +01:00
2017-08-25 17:21:10 -04:00
2017-11-02 11:10:55 +01:00
2017-08-25 17:21:10 -04:00
2017-11-02 11:10:55 +01:00
2017-08-25 17:21:11 -04:00
2017-11-02 11:10:55 +01:00
2017-08-24 22:29:07 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-01-04 13:59:44 +01:00
2017-11-02 11:10:55 +01:00
2019-10-29 09:17:32 +01:00
2017-11-02 11:10:55 +01:00
2019-12-01 09:13:34 +01:00
2017-11-02 11:10:55 +01:00
2017-08-25 17:21:11 -04:00
2017-08-10 19:55:35 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-25 17:21:12 -04:00
2018-11-13 11:14:56 -08:00
2018-11-13 11:14:56 -08:00
2017-08-25 17:21:10 -04:00
2017-08-25 17:21:10 -04:00
2017-08-25 17:21:11 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-07 14:04:01 -04:00
2017-11-02 11:10:55 +01:00
2017-08-25 17:21:10 -04:00
2017-11-02 11:10:55 +01:00
2018-08-15 18:12:47 +02:00
2019-07-10 09:54:35 +02:00
2019-08-25 10:50:13 +02:00
2018-08-15 18:12:47 +02:00
2017-08-25 17:21:10 -04:00
2017-08-25 17:21:11 -04:00
2017-11-02 11:10:55 +01:00
2018-10-20 09:48:51 +02:00
2018-10-20 09:48:51 +02:00
2019-12-01 09:13:27 +01:00
2017-06-20 12:18:27 +02:00
2020-02-28 16:36:04 +01:00
2019-11-10 11:25:11 +01:00
2017-08-22 16:34:36 +02:00
2019-12-21 10:47:52 +01:00
2017-08-07 14:04:02 -04:00
2017-11-02 11:10:55 +01:00
2018-11-13 11:14:56 -08:00
2020-01-04 13:59:44 +01:00
2017-11-02 11:10:55 +01:00
2019-10-29 09:16:53 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2020-01-04 13:59:48 +01:00
2019-11-20 18:00:48 +01:00
2017-11-02 11:10:55 +01:00
2017-09-01 11:59:17 +02:00
2017-11-02 11:10:55 +01:00
2017-08-25 17:21:11 -04:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-24 22:29:01 -04:00
2017-11-02 11:10:55 +01:00
2017-08-24 22:29:05 -04:00
2017-08-07 14:04:01 -04:00
2017-08-25 17:21:11 -04:00
2017-11-02 11:10:55 +01:00
2017-08-25 17:21:11 -04:00
2017-11-02 11:10:55 +01:00
2017-08-25 17:21:11 -04:00
2017-08-28 22:15:46 -04:00
2017-11-02 11:10:55 +01:00
2019-05-16 19:42:27 +02:00
2017-11-02 11:10:55 +01:00
2020-01-04 13:59:48 +01:00
2017-12-20 10:10:20 +01:00
2019-05-08 07:20:49 +02:00
2019-05-08 07:20:49 +02:00
2019-10-29 09:17:31 +01:00
2017-08-25 17:08:07 -04:00
2017-11-02 11:10:55 +01:00
2019-11-20 17:59:24 +01:00
2019-10-07 18:55:06 +02:00
2017-11-02 11:10:55 +01:00
2019-01-23 08:09:48 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2019-04-05 22:31:30 +02:00
2019-10-29 09:17:32 +01:00
2020-01-23 08:20:37 +01:00
2017-11-02 11:10:55 +01:00
2017-10-11 14:33:12 -04:00
2020-02-28 16:36:04 +01:00
2017-08-29 21:51:45 -04:00
2018-06-05 11:41:59 +02:00
2017-09-07 12:12:43 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-07-25 11:25:06 +02:00
2020-01-29 15:02:38 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-03-19 08:42:51 +01:00
2018-08-06 16:20:52 +02:00
2017-08-25 17:21:10 -04:00
2019-11-10 11:25:10 +01:00
2018-05-30 07:51:49 +02:00
2017-11-02 11:10:55 +01:00
2018-08-15 18:12:47 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-08-08 11:49:51 -04:00
2017-11-02 11:10:55 +01:00
2019-05-08 07:20:50 +02:00
2020-01-04 13:59:44 +01:00
2017-06-27 21:46:55 -04:00
2019-03-23 14:35:20 +01:00
2019-07-03 13:16:00 +02:00
2017-08-25 17:21:10 -04:00
2017-11-02 11:10:55 +01:00
2018-08-24 13:09:01 +02:00
2017-08-22 16:34:36 +02:00