Dave Chinner
7db37c5e65
xfs: fix log ticket leak on forced shutdown.
The kmemleak detector shows this after test 139:
unreferenced object 0xffff880079b88bb0 (size 264):
comm "xfs_io", pid 4904, jiffies 4294909382 (age 276.824s)
hex dump (first 32 bytes):
00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N..........
ff ff ff ff ff ff ff ff 48 7b c9 82 ff ff ff ff ........H{......
backtrace:
[<ffffffff81afb04d>] kmemleak_alloc+0x2d/0x60
[<ffffffff8115c6cf>] kmem_cache_alloc+0x13f/0x2b0
[<ffffffff814aaa97>] kmem_zone_alloc+0x77/0xf0
[<ffffffff814aab2e>] kmem_zone_zalloc+0x1e/0x50
[<ffffffff8148f394>] xlog_ticket_alloc+0x34/0x170
[<ffffffff81494444>] xlog_cil_push+0xa4/0x3f0
[<ffffffff81494eca>] xlog_cil_force_lsn+0x15a/0x160
[<ffffffff814933a5>] _xfs_log_force_lsn+0x75/0x2d0
[<ffffffff814a264d>] _xfs_trans_commit+0x2bd/0x2f0
[<ffffffff8148bfdd>] xfs_iomap_write_allocate+0x1ad/0x350
[<ffffffff814ac17f>] xfs_map_blocks+0x21f/0x370
[<ffffffff814ad1b7>] xfs_vm_writepage+0x1c7/0x550
[<ffffffff8112200a>] __writepage+0x1a/0x50
[<ffffffff81122df2>] write_cache_pages+0x1c2/0x4c0
[<ffffffff81123117>] generic_writepages+0x27/0x30
[<ffffffff814aba5d>] xfs_vm_writepages+0x5d/0x80
By inspection, the leak occurs when xlog_write() returns and error
and we jump to the abort path without dropping the reference on the
active ticket.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Alex Elder <aelder@sgi.com>
2011-01-27 12:02:00 +11:00
..
2011-01-12 20:03:43 -05:00
2011-01-12 20:02:45 -05:00
2011-01-12 20:03:42 -05:00
2011-01-15 20:07:48 -05:00
2011-01-18 01:21:29 -05:00
2011-01-13 08:03:15 -08:00
2011-01-07 17:50:26 +11:00
2011-01-17 14:43:43 -08:00
2011-01-13 10:25:24 -08:00
2011-01-17 11:17:51 -08:00
2011-01-13 10:27:28 -08:00
2011-01-16 21:22:29 +00:00
2011-01-13 08:03:23 -08:00
2010-10-29 04:16:28 -04:00
2010-10-29 04:16:28 -04:00
2011-01-16 21:22:37 +00:00
2011-01-17 13:01:25 -06:00
2011-01-07 17:50:26 +11:00
2011-01-07 17:50:26 +11:00
2011-01-07 17:50:31 +11:00
2011-01-11 14:37:31 -08:00
2011-01-13 10:45:01 -08:00
2011-01-17 02:25:31 -05:00
2011-01-12 20:02:43 -05:00
2011-01-07 17:50:26 +11:00
2011-01-14 09:23:36 -08:00
2011-01-12 20:02:44 -05:00
2011-01-17 02:25:31 -05:00
2011-01-12 20:02:45 -05:00
2011-01-12 20:02:45 -05:00
2011-01-12 20:03:42 -05:00
2011-01-17 05:11:37 -05:00
2011-01-07 17:50:26 +11:00
2011-01-07 17:50:26 +11:00
2011-01-12 20:02:43 -05:00
2010-12-10 16:04:28 +01:00
2011-01-13 10:05:56 -08:00
2011-01-17 11:15:30 -08:00
2011-01-13 10:45:01 -08:00
2011-01-04 13:10:37 -05:00
2011-01-13 10:45:01 -08:00
2011-01-12 20:02:44 -05:00
2011-01-12 20:03:43 -05:00
2011-01-15 20:07:48 -05:00
2011-01-16 11:31:50 -08:00
2011-01-13 10:45:01 -08:00
2011-01-13 10:05:56 -08:00
2011-01-12 08:35:53 -08:00
2011-01-17 02:25:31 -05:00
2011-01-07 17:50:26 +11:00
2011-01-13 14:47:54 +01:00
2011-01-13 17:32:43 -08:00
2011-01-07 17:50:26 +11:00
2011-01-10 19:04:05 +01:00
2010-10-29 04:16:31 -04:00
2011-01-13 10:45:01 -08:00
2011-01-07 17:50:26 +11:00
2011-01-13 21:38:46 +00:00
2011-01-10 16:10:33 -08:00
2011-01-12 20:02:44 -05:00
2011-01-07 17:50:26 +11:00
2011-01-11 14:45:52 -08:00
2011-01-07 17:50:26 +11:00
2011-01-27 12:02:00 +11:00
2011-01-17 05:12:44 -05:00
2011-01-16 13:47:07 -05:00
2011-01-07 17:50:29 +11:00
2011-01-13 08:03:12 -08:00
2010-10-29 04:16:28 -04:00
2011-01-03 15:01:48 +01:00
2010-11-10 14:40:43 +01:00
2011-01-14 18:44:22 +01:00
2010-12-17 15:18:05 +01:00
2011-01-13 10:45:01 -08:00
2011-01-07 14:39:20 -08:00
2011-01-17 04:54:38 -05:00
2011-01-16 11:31:50 -08:00
2011-01-13 08:03:12 -08:00
2010-12-15 12:30:36 -08:00
2011-01-17 03:26:27 -05:00
2011-01-07 17:50:27 +11:00
2011-01-16 13:47:07 -05:00
2011-01-13 17:32:48 -08:00
2011-01-07 17:50:29 +11:00
2011-01-07 17:50:26 +11:00
2011-01-17 01:47:59 -05:00
2011-01-17 08:21:42 -05:00
2010-11-15 10:23:31 +01:00
2011-01-17 03:30:37 -05:00
2011-01-12 20:03:43 -05:00
2011-01-14 13:17:26 -08:00
2011-01-10 19:04:08 +01:00
2011-01-13 17:32:32 -08:00
2011-01-18 01:21:26 -05:00
2011-01-17 01:47:59 -05:00
2011-01-17 02:25:31 -05:00
2011-01-16 13:47:07 -05:00
2011-01-07 17:50:33 +11:00
2011-01-12 20:06:58 -05:00
2011-01-13 08:03:12 -08:00
2011-01-13 10:45:01 -08:00
2011-01-15 20:07:33 -05:00
2011-01-16 13:47:07 -05:00