Xin Long
7de5d0c7e7
tipc: add NULL pointer check before calling kfree_rcu
[ Upstream commit 42dec1dbe38239cf91cc1f4df7830c66276ced37 ]
Unlike kfree(p), kfree_rcu(p, rcu) won't do NULL pointer check. When
tipc_nametbl_remove_publ returns NULL, the panic below happens:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000068
RIP: 0010:__call_rcu+0x1d/0x290
Call Trace:
<IRQ>
tipc_publ_notify+0xa9/0x170 [tipc]
tipc_node_write_unlock+0x8d/0x100 [tipc]
tipc_node_link_down+0xae/0x1d0 [tipc]
tipc_node_check_dest+0x3ea/0x8f0 [tipc]
? tipc_disc_rcv+0x2c7/0x430 [tipc]
tipc_disc_rcv+0x2c7/0x430 [tipc]
? tipc_rcv+0x6bb/0xf20 [tipc]
tipc_rcv+0x6bb/0xf20 [tipc]
? ip_route_input_slow+0x9cf/0xb10
tipc_udp_recv+0x195/0x1e0 [tipc]
? tipc_udp_is_known_peer+0x80/0x80 [tipc]
udp_queue_rcv_skb+0x180/0x460
udp_unicast_rcv_skb.isra.56+0x75/0x90
__udp4_lib_rcv+0x4ce/0xb90
ip_local_deliver_finish+0x11c/0x210
ip_local_deliver+0x6b/0xe0
? ip_rcv_finish+0xa9/0x410
ip_rcv+0x273/0x362
Fixes: 97ede29e80ee ("tipc: convert name table read-write lock to RCU")
Reported-by: Li Shuang <shuali@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-09-19 09:08:02 +02:00
..
2018-10-03 17:00:47 -07:00
2019-07-31 07:28:39 +02:00
2019-05-16 19:42:34 +02:00
2019-04-20 09:15:07 +02:00
2019-04-27 09:35:33 +02:00
2019-06-22 08:16:14 +02:00
2019-09-16 08:20:45 +02:00
2019-07-31 07:28:43 +02:00
2019-09-19 09:07:59 +02:00
2019-05-08 07:20:45 +02:00
2019-07-21 09:04:22 +02:00
2019-08-29 08:26:42 +02:00
2019-09-19 09:08:01 +02:00
2018-09-19 22:43:43 +02:00
2019-04-03 06:25:08 +02:00
2018-02-25 11:07:52 +01:00
2018-07-22 14:28:49 +02:00
2019-05-16 19:42:34 +02:00
2019-03-19 13:13:22 +01:00
2019-04-27 09:35:40 +02:00
2018-04-29 11:33:13 +02:00
2019-09-19 09:08:02 +02:00
2019-09-19 09:08:00 +02:00
2018-03-31 18:10:41 +02:00
2019-04-17 08:37:45 +02:00
2019-09-16 08:20:44 +02:00
2019-08-09 17:53:35 +02:00
2019-06-22 08:16:14 +02:00
2019-06-09 09:18:10 +02:00
2019-09-06 10:20:59 +02:00
2018-09-09 19:55:52 +02:00
2019-03-13 14:03:09 -07:00
2019-08-29 08:26:39 +02:00
2019-03-13 14:03:08 -07:00
2019-04-03 06:25:08 +02:00
2019-07-31 07:28:46 +02:00
2019-07-31 07:28:45 +02:00
2018-07-22 14:28:49 +02:00
2019-07-31 07:28:45 +02:00
2019-08-25 10:50:26 +02:00
2019-03-23 14:35:16 +01:00
2019-09-10 10:32:21 +01:00
2018-08-24 13:09:13 +02:00
2019-06-11 12:21:45 +02:00
2018-05-16 10:10:26 +02:00
2019-05-02 09:40:34 +02:00
2019-07-31 07:28:45 +02:00
2019-09-19 09:08:01 +02:00
2019-09-19 09:08:01 +02:00
2019-09-06 10:20:50 +02:00
2018-07-22 14:28:47 +02:00
2019-07-21 09:04:29 +02:00
2019-09-19 09:08:02 +02:00
2018-12-05 19:41:11 +01:00
2019-03-19 13:13:24 +01:00
2019-09-16 08:20:45 +02:00
2019-09-06 10:20:59 +02:00
2019-03-19 13:13:23 +01:00
2019-09-16 08:20:44 +02:00
2019-01-09 17:14:46 +01:00
2019-08-25 10:50:02 +02:00