Eric Biggers 89aca68d2f ubifs: don't trigger assertion on invalid no-key filename ...

If userspace provides an invalid fscrypt no-key filename which encodes a
hash value with any of the UBIFS node type bits set (i.e. the high 3
bits), gracefully report ENOENT rather than triggering ubifs_assert().

Test case with kvm-xfstests shell:

    . fs/ubifs/config
    . ~/xfstests/common/encrypt
    dev=$(__blkdev_to_ubi_volume /dev/vdc)
    ubiupdatevol $dev -t
    mount $dev /mnt -t ubifs
    mkdir /mnt/edir
    xfs_io -c set_encpolicy /mnt/edir
    rm /mnt/edir/_,,,,,DAAAAAAAAAAAAAAAAAAAAAAAAAA

With the bug, the following assertion fails on the 'rm' command:

    [   19.066048] UBIFS error (ubi0:0 pid 379): ubifs_assert_failed: UBIFS assert failed: !(hash & ~UBIFS_S_KEY_HASH_MASK), in fs/ubifs/key.h:170

Fixes: f4f61d2cc6d8 ("ubifs: Implement encrypted filenames")
Cc: <stable@vger.kernel.org> # v4.10+
Link: https://lore.kernel.org/r/20200120223201.241390-5-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>

2020-02-13 15:12:08 -08:00

..

budget.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

commit.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

compress.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

crypto.c

fscrypt: introduce fscrypt_decrypt_block_inplace()

2019-08-30 09:20:28 -07:00

debug.c

ubifs: Fix cut and paste error on sb type comparisons

2017-05-08 20:48:41 +02:00

debug.h

…

dir.c

ubifs: don't trigger assertion on invalid no-key filename

2020-02-13 15:12:08 -08:00

file.c

ubifs: switch to fscrypt_get_symlink()

2018-04-08 03:34:54 -07:00

find.c

…

gc.c

ubifs: Remove some dead code

2016-12-12 23:06:28 +01:00

io.c

ubifs: Use dirty_writeback_interval value for wbuf timer

2016-12-12 23:06:24 +01:00

ioctl.c

ubifs: wire up new fscrypt ioctls

2019-09-23 19:07:12 -07:00

journal.c

ubifs: Set double hash cookie also for RENAME_EXCHANGE

2017-07-14 22:50:57 +02:00

Kconfig

fscrypt: Allow modular crypto algorithms

2020-02-13 15:12:04 -08:00

key.h

ubifs: Add assert to dent_key_init()

2017-07-14 22:49:06 +02:00

log.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

lprops.c

UBIFS: improve function-level documentation

2016-10-02 22:55:02 +02:00

lpt_commit.c

UBIFS: improve function-level documentation

2016-10-02 22:55:02 +02:00

lpt.c

UBIFS: use kmemdup rather than duplicating its implementation

2015-10-03 20:03:14 +02:00

Makefile

fscrypt: remove filesystem specific build config option

2019-04-16 18:05:24 -07:00

master.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

misc.c

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

misc.h

fs: ubifs: replace CURRENT_TIME_SEC with current_time

2017-05-08 17:15:15 -07:00

orphan.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

recovery.c

ubifs: Remove unnecessary assignment

2017-05-08 20:48:47 +02:00

replay.c

ubifs: Implement encrypted filenames

2016-12-12 23:07:38 +01:00

sb.c

fscrypt: remove filesystem specific build config option

2019-04-16 18:05:24 -07:00

scan.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

shrinker.c

…

super.c

ubifs: wire up new fscrypt ioctls

2019-09-23 19:07:12 -07:00

tnc_commit.c

ubifs: Fail commit if TNC is obviously inconsistent

2017-07-14 22:49:07 +02:00

tnc_misc.c

UBIFS: extend debug/message capabilities

2015-03-25 11:08:41 +02:00

tnc.c

ubifs: Massage debug prints wrt. fscrypt

2017-07-14 22:49:07 +02:00

ubifs-media.h

ubifs: Raise write version to 5

2016-12-12 23:07:38 +01:00

ubifs.h

fscrypt: remove filesystem specific build config option

2019-04-16 18:05:24 -07:00

xattr.c

fs, fscrypt: add an S_ENCRYPTED inode flag

2018-01-04 16:17:15 -08:00